Select button for Associated Category doesn't work

bartuelen
Topic Author
Offline

13 years 4 months ago #103179 by bartuelen

Select button for Associated Category doesn't work was created by bartuelen

In the Hikashop menu option the Select button for choosing an Associated category or an Associated module does not work.

Get reference / invalid assignment error according to Firebug.

Looks like something is not correct in the HTML

See attached screenprints.

This attachment is hidden for guests.
Please log in or register to see it.

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

13 years 4 months ago - 13 years 4 months ago #103221 by Jerome

Replied by Jerome on topic Select button for Associated Category doesn't work

Hi,

Please edit the file "administrator/com_hikashop/helper/popup.php" and replace the code

Code:

						if(!empty($id)) {
							if($type == 'button')
								$html = '<button '.$this->getAttr($attr,'btn btn-small').' id="'.$id.'" onclick="window.hikashop.openBox(this,\''.$url.'\',true); return false;">';
							else
								$html = '<a '.$attr.' href="#" id="'.$id.'" onclick="window.hikashop.openBox(this,null,true); return false;">';
						} else {

By this one

Code:

						if(!empty($id)) {
							if($type == 'button') {
								if($dynamicUrl)
									$html = '<button '.$this->getAttr($attr,'btn btn-small').' id="'.$id.'" onclick="window.hikashop.openBox(this,'.$url.',true); return false;">';
								else
									$html = '<button '.$this->getAttr($attr,'btn btn-small').' id="'.$id.'" onclick="window.hikashop.openBox(this,\''.$url.'\',true); return false;">';
							} else
								$html = '<a '.$attr.' href="#" id="'.$id.'" onclick="window.hikashop.openBox(this,null,true); return false;">';
						} else {

It will fix the problem.
We will update the HikaShop package with this patch as soon as possible.

Sorry for the inconvenient, my fault.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Last edit: 13 years 4 months ago by Jerome.

Please Log in or Create an account to join the conversation.

bartuelen
Topic Author
Offline

13 years 4 months ago #103379 by bartuelen

Replied by bartuelen on topic Select button for Associated Category doesn't work

Thanks for the swift response.

Changed the code and it works all right!

Bart

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

13 years 4 months ago #103384 by Jerome

Replied by Jerome on topic Select button for Associated Category doesn't work

Hi,

We updated the HikaShop package with the fix (I updated my previous post with the latest patch version).

Regards,

Please Log in or Create an account to join the conversation.

bartuelen
Topic Author
Offline

13 years 4 months ago - 13 years 4 months ago #104109 by bartuelen

Replied by bartuelen on topic Select button for Associated Category doesn't work

Hi,

The above code fix repaired the bug.
The issue was that from a menu-item --> Hikashop option screen it was not possible to get the pop-up to select an associate category from.
The fix made the pop-up appear correctly.

BUT...

Now the Add button on the Hikashop product screen doesn't work. It give the same kind of result as the Associate category Select button did before the bugfix.

I changed back the popup.php to the old version before the code fix and the Add button does work well now but the Associate category Select button does not work anymore.

Looks like both button types call the same popup.php but it is only one of both working correctly. Some kind of interference or so?

I can apply the workaround for the time being, but the end-user will not be able to do this tric.

I'm sure you are able to repair this too? ;-)

See also issues:

www.hikashop.com/en/forum/3-bug-report/8...category.html#103937

and

www.hikashop.com/en/forum/2-general-talk...products.html#103335

Thanks in advance,

Bart

Last edit: 13 years 4 months ago by bartuelen.

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

13 years 4 months ago #104119 by Jerome

Replied by Jerome on topic Select button for Associated Category doesn't work

Hi,

I tested the latest HikaShop package (2.1.3) in Joomla 3 and Joomla 2.5, all "Add" button works in the product page.

Regards,

Please Log in or Create an account to join the conversation.

Time to create page: 0.214 seconds