Custom serial plugin generating duplicate serials

-- HikaShop version -- : 2.6.2
-- HikaSerial version -- : 1.10.2

Hi Guys,

I expect I'm missing something obvious here, but I have a custom serial generator plugin that creates serials for the shopping cart against products, using custom field information that is entered when a product is added to the cart.

A product will only have a quantity of ONE, but can exist in the cart multiple times. When only one product exists in the cart, all if fine - I get a single serial number generated.

If the cart has 'n' products in the cart though, I get 'n' serials, duplicated 'n' times. I've attached my generator code (modified to remove the actual serial number algorithm!) but can you see where I've gone wrong please?

It feels as though the plugin is running over ALL products in the cart for each and every product, but I can't see how to get just the single product line that's being iterated over - or that might be nonsense!

Many thanks,
Oliver

Hi Jerome,

Thanks for the response. I'm not sure the first option would work as - because each product can have different custom fields associated with it - you can have multiple order lines of the *same* product (but different metadata).

I'll try the second option of keeping track of which order lines have already been processed.

Thanks again,
Oliver

Hi Jerome,
I'm implementing the change in the generator, and wondering if the various structures ($order, $pack, etc.) are documented anywhere? I have been using $pack->main_product_id but your example says $pack->product_id - and I don't know what the differences are.

Thanks,
Oliver