Bug ? in ACL configuration for price / quantity

  • Posts: 21
  • Thank you received: 0
9 years 10 months ago #160933

Hello

I have noticed that when setting ACL for a group allowing to edit price and choose currency, price tax is also displayed by default even if tax setting is not allowed in backend ACL settings

Is it a bug or something on purpose ?

We would need a way to hide price with tax as this is intended for general public, so displaying tax may trigger lots of useless questions to our client support

Thanks
Jean

Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 26000
  • Thank you received: 4004
  • MODERATOR
9 years 10 months ago #160942

Hi,

The price edition have two different modes, a "classical" and a "minimal".
The minimal design is used when the "currency", the "quantity" and the "acl" are not available.
Otherwise the "classical" design is used.

Even if the vendor can't edit the tax, it does not means that there is no a tax for the product (in the product template for example).
So the price with tax is display and available, to help the vendors to configure the price. It is something on purpose.

How many currencies do you have in your website ?
Do you want the vendors configure the prices for all currencies ?
Did you test the price edition without the "currency" ? Maybe the design will be more appropriate to your requirements.

To make a fast fix, it is something you can override in the price edition.
In the view "productmarket | form_price" you can remove the blocks

			<th class="title"><?php
				echo JText::_('PRICE_WITH_TAX');
			?></th>
			<td class="hikam_price">
				<?php echo $pre_price; ?><input size="10" type="text" id="hikamarket_price_<?php echo $i;?>_with_tax" name="price_with_tax_<?php echo $i;?>" value="<?php echo @$price->price_value_with_tax; ?>" onchange="window.productMgr.updatePrice(<?php echo $i; ?>, true)"/><?php echo $post_price; ?>
			</td>

And replace the content
window.productMgr.updatePrice = function(id, taxed) {
/* Remove the javascript+php which is here */
}
if(!window.productMgr.cpt)
	window.productMgr.cpt = {};
In order to not make the ajax call when the price without tax is modified.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 21
  • Thank you received: 0
9 years 9 months ago #161566

Hi,

We will have at least 3 or 4 currencies for the website and any vendor will be allowed to choose a currency for a product and even add different prices for different currencies. So we need the currency display.

What we want to achieve is :

- for professional vendors (joomla group P), display of price, tax and currency
- for individual vendors (default registered joomla group R), display of only price and currency

We could achieve this with product template in the back end that could be affected to vendors group but I think that this is not implemented yet ?

Any idea ? or timetable for implementation of product templates to vendors group ? :-)

thanks
Jean

Please Log in or Create an account to join the conversation.

  • Posts: 26000
  • Thank you received: 4004
  • MODERATOR
9 years 9 months ago #161575

Hi,

Regarding the code of the page, I think that the best will be to use the "product / edit / price / tax" acl.
So, if you take the previous modifcations, you can simply put a

<?php if($acls['tax']){ ?>
and
<?php } ?>
in order to display the three elements only if the vendor have the right ACL.
Otherwise, the content won't be displayed and you should have the required result.
(And I will include these modification in the next HikaMarket build, for sure).

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 21
  • Thank you received: 0
9 years 9 months ago #161583

Thanks for the info !

Don't forget to also correct the new price template, I have attached the corrected form, hope I did not miss something it seems to work this way :-)

Jean

Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 26000
  • Thank you received: 4004
  • MODERATOR
9 years 9 months ago #161586

Hi,

Thanks.
Yes I will update the new price template too. I just create a note in my todo list for that !

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

Moderators: Obsidev
Time to create page: 0.065 seconds
Powered by Kunena Forum