Vendor rating not working for Hikamarket

Hi,

The page you linked does not allow to vote so I cannot perform any test (and analyze) in your website.

Regards,

Hi,

Thanks.

I was able to reproduce your issue in my local website and I found 6 bugs in the vote system of HikaShop 2.6.1.
I submitted a patch in order to fix these problems in HikaShop and make the vote triggers work again.
But, because the vote structure changed ; if you apply the HikaShop patch without applying a patch in HikaMarket, you will have some SQL errors in HikaShop.

So, you will have to modify the plugin "plugins/hikashop/market/market.php" and replace

	if($vendor) {
		$currentElement->vote_type = 'vendor';
		$currentElement->vote_ref_id = $element->vote_ref_id;
		$currentElement->average_score = $vendor->vendor_average_score;
		$currentElement->total_vote = $vendor->vendor_total_vote;
	}

	if(!$vendor) {
		$do = false;
		return;
	}
	$currentElement->vote_type = 'vendor';
	$currentElement->vote_ref_id = (int)$element->vote_ref_id;

public function onAfterVoteUpdate(&$element) {

public function onAfterVoteUpdate(&$element, $return_data) {

	if(!isset($element->average_score) || !isset($element->total_vote))
		return;

	$vendor = new stdClass();
	$vendor->vendor_id = (int)$element->vote_ref_id;
	$vendor->vendor_average_score = hikamarket::toFloat($element->average_score);
	$vendor->vendor_total_vote = (int)$element->total_vote;

	$vendor = new stdClass();
	$vendor->vendor_id = (int)$element->vote_ref_id;
	$vendor->vendor_average_score = (float)hikamarket::toFloat($return_data['average']);
	$vendor->vendor_total_vote = (int)$return_data['total'];

Hi,

It would be easier if I could have an FTP access so I can apply the patch and test directly that the all system is working fine.
And if you can also provide a super-admin account ; I would be able to see the content in the database in the same time ; but it should be ok without.

Please use the "contact us" form for such kind of private information.
By including a link to that forum thread, the support team will assign directly the message to me.

Regards,

Hi,

I am sorry but the FTP account is not working.
I don't know if my IP has been block or else ; but I can't make a connection with your FTP server.
And even if the backend access is working ; it does not provide me the right interface to perform some debugging on the HikaShop vote system.

Regards,

Hi,

I finally figured it out the issue with the FTP ; your server have a partial IPv6 support but the FTP port seems to only response in IPv4.

I fixed the patch ; the votes are now saved correctly.

Regards,

Hi,

Did you apply all previous patches mentioned in that thread ?
I see that you have a very recent HikaShop 2.6.2 package so you have all patches for the HikaShop part.

If so, please also add the function in the "market" plugin.

	public function onAfterVoteCreate(&$element, $return_data) {
		$this->onAfterVoteUpdate($element, $return_data);
	}

public function onAfterVoteCreate(&$element, $return_data) {
	$this->onAfterVoteUpdate($element, $return_data);
}

public function onAfterVoteUpdate(&$element, $return_data) {

Hi,

Yesterday I updated the HikaShop demo website in order to test the issue.
I was able to reproduce it but it was late and I had to eat and sleep.
In that time I didn't feel that I should notice you that I got some clues and that I think some patches are missing in the HikaShop 2.6.2 release (that I should have in the dev-release of HikaShop 2.6.3)

It requires some investigations and for what I could see, it should be related to HikaShop and not to the HikaMarket patches.
HikaShop 2.6.2 changed a lot of things in the vote system and unfortunately, the HikaShop team did not warn me of that so I could correctly test and improve HikaMarket.

I am always answering asap and you can be sure that I'm doing as fast as I can.
As you know I'm working on a new release of HikaMarket so I want to be sure that what HikaShop 2.6.2 as broke in the vote system won't be break anymore with new HikaMarket release.

Regards,

Hi,

With HikaShop 2.6.2 ; I was able to see the problem but with HikaShop 2.6.3, the problem is fixed.
I saw with Nicolas and they want to release that new version soon, it is almost finished but they will wait beginning of next week (to do not perform a release during the French Joomla day).

So, the patches in HikaMarket are there but there is some patches missing in HikaShop 2.6.2 for the vote system.

Regards,

Hi,

Please see that directly with the HikaShop support team.
I know that there is already a forum thread, in the HikaShop forum section, for the issue on the vendor votes.

Regards,