#__hikashop_address keeps growing?

-- url of the page with the problem -- : local
-- HikaShop version -- : 2.5.0 Starter
-- Joomla version -- : 3.4.4
-- PHP version -- : 5.5.3

Hi,

I'm presently in dev mode and playing with 3-5 users who I register in checkout with minimal address details: "Ask address on registration" = yes, published are only 1st & last names, country & state, "Use the same address as for billing" is checked for shipping address.

These dummy users order something, and then I'm deleting them to start all over again. Deletion goes "by the book", supposedly: in the backend only, first orders, then J users. I have also tried deleting shop users after the orders, then J users, but it's all the same as far as the "issue" goes.
BTW, Emerald is involved, but no extra action, subscription are deleted without a trace upon J user deletion.

Upon checking the database just to verify that all goes by the infamous book, indeed all is good and clean. With the exception of the table #__hikashop_address. And that's the issue: after a few cycles I'm left with some 20 rows there. Most fields are NULL, also the aforementioned ones which had been in use.
Further testing shows that it keeps going this way: address details are being stored in a new row, but upon user deletion the row stays - mostly NULL except for
address_id (= auto_increment number maintained)
address_user_id (= 0)
address_published (= 1)
address_default (= 1)

What is preventing from proper housekeeping?

I have no problem deleting those rows now with no user other than admin around, but my concern is the future:
Upon launch, the database will hold >10k addresses, hopefully growing, but with a certain fluctuation including deletions. At some point housekeeping might become a big mess, or this table will just keep growing... who knows to what size.

So, it'd be great if you could take a look at what is yet a small issue. Should be easily reproducible, otherwise it must be uniquely my problem, and I'll take any hint and get you what you need to find the culprit.

Thanks again!

P.S.: I should maybe add that it's really only J!3.4.4, HikaShop and Emerald, and not one file modded, even still Protostar

Friendly "bump"...

Maybe it takes a bit longer to dig into this, or maybe my post only fell off the edge of the world. No stress, but would be nice hearing something. Thanks!

Hi again,

I understand it's not a priority - as I said, it's only a small issue, obviously, and there are more important things to do.
Was just wondering because usually no question here goes without reply within a few hours unless the OP answers it himself.

Anyway, glad you took the time to answer, and thanks for the hints on function and SQL query. That'll do!

Following the previous posts, adding the following at the end of the delete() function in /administrator/components/com_hikashop/classes/address.php seems to do the trick:

        $db = JFactory::getDbo();
        $query = $db->getQuery(true);
        $conditions = array(
          $db->quoteName('address_country') . ' IS NULL'
        );
        $query->delete($db->quoteName('#__hikashop_address'));
        $query->where($conditions);
        $db->setQuery($query);
        $result = $db->execute();

Thanks for the input. Would it be better to delete records where address_user_id=0 then? I noticed that was another common value in deleted users.

It seems like the deleted users are having their address_user_id fields properly zeroed out (and other fields also become NULL). Using address_user_id=0 has been working in my tests so far.

Is there a case where an address would be in the #__hikashop_address table with the ID of a user who's already been deleted?

I think it's much clearer now. When I was testing before, I forgot to put in some orders. That's why I didn't come across the case where Hikashop users were kept when Joomla users were deleted

My adjusted SQL statement:

$db = JFactory::getDbo();
$sql = 'DELETE FROM #__hikashop_address WHERE address_user_id NOT IN (SELECT user_id FROM #__hikashop_user)';
$db->setQuery($sql);
$result = $db->execute();