Error notices when using cursor filter

  • Posts: 200
  • Thank you received: 75
7 years 8 months ago #248195

-- HikaShop version -- : 2.6.3
-- Joomla version -- : 3.6.2

Hi,

when using a cursor filter for anything else than the price we get several error notices, see attached screenshot.

In the filter.php file, we can see on line 2039 the currency variables are only defined if($filter->filter_data=='price')

However, on line 2066 and line 2081 the variables $currencies and $crurency_id are assumed to always exist. If we're not mistaken, this can be fixed by checking the filter_data again first by changing line 2066 and 2081 from

if($currencies[$crurency_id]->currency_locale['p_cs_precedes']){

to
if($filter->filter_data=='price' && $currencies[$crurency_id]->currency_locale['p_cs_precedes']){

Hopefully this can be fixed with the next release, thanks!
Kind regards,

Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 26004
  • Thank you received: 4004
  • MODERATOR
7 years 8 months ago #248201

Hi,

Thanks for the report ; we will fix that issue in the next release.

Regards,


Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 200
  • Thank you received: 75
7 years 2 months ago #262783

Hi,

the error we mentioned in our first post months ago appears again in Hikashop 3 [1702171813] when having a cursor filter applied on anything other than the price:

Notice: Undefined variable: currency_id in \administrator\components\com_hikashop\classes\filter.php on line 2094
Notice: Undefined variable: currency_id in \administrator\components\com_hikashop\classes\filter.php on line 2109

Because $currency_id is defined on line 2069 only if($filter->filter_data == 'price').
Hopefully this can be fixed again, thanks!

Please Log in or Create an account to join the conversation.

  • Posts: 81539
  • Thank you received: 13069
  • MODERATOR
7 years 2 months ago #262804

Hi,

Thank you for your feedback. It's actually a new message but yes, the cause is pretty similar. I've added a patch on our end in order to fix that.

Please Log in or Create an account to join the conversation.

Time to create page: 0.061 seconds
Powered by Kunena Forum