Troubles adter Upgrade from 3.4.3 Joomla to 3.4.4

progreccor
Topic Author
Offline
SEO, webdesign

11 years 2 weeks ago - 11 years 2 weeks ago #214139 by progreccor

Troubles adter Upgrade from 3.4.3 Joomla to 3.4.4 was created by progreccor

-- HikaShop version -- : 2.5.0
-- Joomla version -- : 3.4.4
-- PHP version -- : 5.5.6
-- Browser(s) name and version -- : Mozilla

If I upgrading from 3.4.3 Joomla to 3.4.4 I have a bug in the "IMAGES AND FILES".
I can't delete images

the problem with iframe.php file

If I restore it from backup - it is ok.

Я не явлюсь официальной службой поддержки!
Я здесь добровольно!

Хочешь получить купон на скидку Hikashop? Спроси меня как!

Last edit: 11 years 2 weeks ago by progreccor.

Please Log in or Create an account to join the conversation.

nicolas
Away

11 years 2 weeks ago #214144 by nicolas

Replied by nicolas on topic Troubles adter Upgrade from 3.4.3 Joomla to 3.4.4

Hi,

We don't have that problem on our end.
This indicates that there is a javascript error on the page. Open your browser's error console and look for the javascript error which appears for that page.
That should give more information in order to identify the problem.

Please Log in or Create an account to join the conversation.

progreccor
Topic Author
Offline
SEO, webdesign

11 years 2 weeks ago - 11 years 2 weeks ago #214210 by progreccor

Replied by progreccor on topic Troubles adter Upgrade from 3.4.3 Joomla to 3.4.4

I have tested many sites and see that the problem with all versions of hikashop - 2.4.3 and 2.5.0 - all versions have problem after upgrading Joomla from 3.4.3 to 3.4.4

I have feedback from 4 customers that have the same problems.

Try to install hikashop on 3.4.3 Joomla and after that upgrade to 3.4.4

Here is screenshots:

Last edit: 11 years 2 weeks ago by progreccor.

Please Log in or Create an account to join the conversation.

progreccor
Topic Author
Offline
SEO, webdesign

11 years 2 weeks ago #214211 by progreccor

Replied by progreccor on topic Troubles adter Upgrade from 3.4.3 Joomla to 3.4.4

here is from another site

Please Log in or Create an account to join the conversation.

progreccor
Topic Author
Offline
SEO, webdesign

11 years 2 weeks ago #214212 by progreccor

Replied by progreccor on topic Troubles adter Upgrade from 3.4.3 Joomla to 3.4.4

this is really big problem. On all sites appears this problem

Please Log in or Create an account to join the conversation.

progreccor
Topic Author
Offline
SEO, webdesign

11 years 2 weeks ago #214216 by progreccor

Replied by progreccor on topic Troubles adter Upgrade from 3.4.3 Joomla to 3.4.4

I have noticed that the problem appears only if we use Russian language.
If we switch from Russian to English - all is working ok.

Could you help please?

Please Log in or Create an account to join the conversation.

progreccor
Topic Author
Offline
SEO, webdesign

11 years 2 weeks ago - 11 years 2 weeks ago #214218 by progreccor

Replied by progreccor on topic Troubles adter Upgrade from 3.4.3 Joomla to 3.4.4

I found the problem

Here is the trouble string:

Before:

Code:

ADD_TO_CART_HTML_CODE="HTML ссылка 'Добавить в корзину'"

After:

Code:

ADD_TO_CART_HTML_CODE="HTML ссылка - Добавить в корзину"

I think that problem was with apostrophe (') symbol.

So please change this line in Russian translation and it will fix the problem

Last edit: 11 years 2 weeks ago by progreccor.

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

11 years 2 weeks ago - 11 years 1 week ago #214229 by Jerome

Replied by Jerome on topic Troubles adter Upgrade from 3.4.3 Joomla to 3.4.4

Hi,

Thanks for the report.
We will see to "secure" the text in order to avoid the issues when the apostrophe is used. So even if someone change the translation to put that special character, it will not break the page.

So in the file "administrator/components/com_hikashop/views/product/view.html.php" you can replace (twice)

Code:

array('name' => 'popup','icon'=>'upload','alt'=>JText::_('ADD_TO_CART_HTML_CODE'),'url'=>$url),

Code:

array('name' => 'popup','icon'=>'upload','alt'=>JText::_('ADD_TO_CART_HTML_CODE', true),'url'=>$url),

It should activate the "jsSafe" from the Joomla Text, and avoid the javascript issue.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Last edit: 11 years 1 week ago by Jerome.

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

11 years 1 week ago - 11 years 1 week ago #214269 by Jerome

Replied by Jerome on topic Troubles adter Upgrade from 3.4.3 Joomla to 3.4.4

Hi,

File "layouts/joomla/modal/main.php", replace:

Code:

$script[] = "       modalBody.prepend('" . trim($iframeHtml) . "');";

Code:

$script[] = "       modalBody.prepend('" . str_replace("'", "\'", trim($iframeHtml)) . "');";

The patch from the previous post avoid the javascript error but display a backslash in the button content.... Which is not very nice.

Edit
Instead of that patch, please apply the official patch (which won't have side effect on dynamic URL).
github.com/joomla/joomla-cms/pull/7845/files

Regards,

Last edit: 11 years 1 week ago by nicolas.

The following user(s) said Thank You: handlyweb

Please Log in or Create an account to join the conversation.

progreccor
Topic Author
Offline
SEO, webdesign

11 years 1 week ago - 11 years 1 week ago #214271 by progreccor

Replied by progreccor on topic Troubles adter Upgrade from 3.4.3 Joomla to 3.4.4

Yes, I really think that the problem with the last update of Joomla. It is not the problem of the HIkashop, but it can be more safer to escape apostrophe symbols in that file.

The problem with /layouts/joomla/modal/iframe.php file

Need to see the changes from latest version of the file to understand what's wrong with it

Last edit: 11 years 1 week ago by progreccor.

The following user(s) said Thank You: romduf

Please Log in or Create an account to join the conversation.

Cattelan
Offline

11 years 1 week ago - 11 years 1 week ago #214272 by Cattelan

Replied by Cattelan on topic Troubles adter Upgrade from 3.4.3 Joomla to 3.4.4

Hallo there.

I have the same problem after upgrading to joomla 3.4.4. All popups in the admin order mask are broken. Iìm working on italian language. I didn't apply your patches yet. should i do this ?

--- edit

also the invoice and the order confirmation bill are blank

Last edit: 11 years 1 week ago by Cattelan.

Please Log in or Create an account to join the conversation.

nicolas
Away

11 years 1 week ago #214274 by nicolas

Replied by nicolas on topic Troubles adter Upgrade from 3.4.3 Joomla to 3.4.4

You should yes.

Please Log in or Create an account to join the conversation.

Cattelan
Offline

11 years 1 week ago #214275 by Cattelan

Replied by Cattelan on topic Troubles adter Upgrade from 3.4.3 Joomla to 3.4.4

I applied your patch. Isn't it a joomla core file ? what happens with further upgrades of joomla or Hikashop? Thanks for your reply

Please Log in or Create an account to join the conversation.

nicolas
Away

11 years 1 week ago #214277 by nicolas

Replied by nicolas on topic Troubles adter Upgrade from 3.4.3 Joomla to 3.4.4

Note that the problem has been reported :
issues.joomla.org/tracker/joomla-cms/7890

The following user(s) said Thank You: progreccor

Please Log in or Create an account to join the conversation.

erickb
Offline

10 years 9 months ago #223164 by erickb

Replied by erickb on topic Troubles adter Upgrade from 3.4.3 Joomla to 3.4.4

the problem is the same with a new installation (without upgrade) of Joomla 3.4.5 and Hikashop 2.6.0

Please Log in or Create an account to join the conversation.

progreccor
Topic Author
Offline
SEO, webdesign

10 years 9 months ago #223169 by progreccor

Replied by progreccor on topic Troubles adter Upgrade from 3.4.3 Joomla to 3.4.4

please change in file /layouts/joomla/modal/iframe.php line 40

Code:

$iframeAttributes['name'] = $params['title'];

change to

Code:

$iframeAttributes['name'] = addslashes($params['title']);

The following user(s) said Thank You: erickb, Wtor22

Please Log in or Create an account to join the conversation.

erickb
Offline

10 years 9 months ago #223170 by erickb

Replied by erickb on topic Troubles adter Upgrade from 3.4.3 Joomla to 3.4.4

it works thank you

Please Log in or Create an account to join the conversation.

Time to create page: 0.294 seconds