[Skip to main content](#vessel-content)

#   Request for modification in groupfilterconsumer plugin

##

- **[sabroso](/forum/user/38789-sabroso "View sabroso's Profile")**
- [![sabroso's Avatar](https://www.hikashop.com/media/kunena/core/svg/person.svg)](/forum/user/38789-sabroso "View sabroso's Profile") Topic Author
- [ Offline](/forum/user/38789-sabroso)

Less More

- Posts: 128
- Thank you received: 2
-
-

9 years 10 months ago [\#259523](#259523) by [sabroso](/forum/user/38789-sabroso "View sabroso's Profile")  *[Request for modification in groupfilterconsumer plugin](/forum/14-hikaserial/888312-request-for-modification-in-groupfilterconsumer-plugin#259523 "-- HikaShop version -- : 2.6.4 -- HikaSerial version -- : 1.10.4 -- Joomla version -- : 3.6.5 -- PHP version -- : 5.6  Hi there,  It is great that we can control what user groups can consume certain serials with the groupfilterconsumer plugin, but I feel it is missing an error message in case the user is not authorized to consume the serial. I feel we need to show the reason why there is a problem when the serial consumption does not work due to this plugin.  I propose the following change in groupfilterconsumer.php  Replace this (line 73)  By this  Would this be possible please?  Many thanks!")* was created by *[sabroso](/forum/user/38789-sabroso "View sabroso's Profile")*

-- HikaShop version -- : 2.6.4
-- HikaSerial version -- : 1.10.4
-- Joomla version -- : 3.6.5
-- PHP version -- : 5.6

Hi there,

It is great that we can control what user groups can consume certain serials with the groupfilterconsumer plugin, but I feel it is missing an error message in case the user is not authorized to consume the serial. I feel we need to show the reason why there is a problem when the serial consumption does not work due to this plugin.

I propose the following change in groupfilterconsumer.php

Replace this (line 73) Code:

if(!$f) $do = false;

By this Code:

if(!$f){ $do = false; $app = JFactory::getApplication(); $app-&gt;enqueueMessage(JText::_('HIKASERIAL_NOT_AUTHORISED'), 'error'); }

Would this be possible please?

Many thanks!

Please [Log in](/login?return=aHR0cHM6Ly93d3cuaGlrYXNob3AuY29tL2ZvcnVtLzE0LWhpa2FzZXJpYWwvODg4MzEyLXJlcXVlc3QtZm9yLW1vZGlmaWNhdGlvbi1pbi1ncm91cGZpbHRlcmNvbnN1bWVyLXBsdWdpbj90bXBsPW1hcmtkb3du) or [Create an account](/component/users/registration?Itemid=101) to join the conversation.

- **[Jerome](/forum/user/80-jerome "View Jerome's Profile")**
- [![Jerome's Avatar](https://www.hikashop.com/media/kunena/avatars/resized/size144/users/avatar80.png)](/forum/user/80-jerome "View Jerome's Profile")
- [ Offline](/forum/user/80-jerome)
- HikaShop core developer

Less More

- Posts: 26400
- Thank you received: 4080
-
- [](http://obsi.dev)
-

9 years 10 months ago [\#259528](#259528) by [Jerome](/forum/user/80-jerome "View Jerome's Profile")  Replied by *[Jerome](/forum/user/80-jerome "View Jerome's Profile")* on topic *[Request for modification in groupfilterconsumer plugin](/forum/14-hikaserial/888312-request-for-modification-in-groupfilterconsumer-plugin#259528 "-- HikaShop version -- : 2.6.4 -- HikaSerial version -- : 1.10.4 -- Joomla version -- : 3.6.5 -- PHP version -- : 5.6  Hi there,  It is great that we can control what user groups can consume certain serials with the groupfilterconsumer plugin, but I feel it is missing an error message in case the user is not authorized to consume the serial. I feel we need to show the reason why there is a problem when the serial consumption does not work due to this plugin.  I propose the following change in groupfilterconsumer.php  Replace this (line 73)  By this  Would this be possible please?  Many thanks!")*

Hi,

I understand your request but in the other hand, I didn't add that message for a very specific reason : security.
Displaying a message to indicate the reason why the consumption is not made can give indications to the end user for some elements which he shouldn't know.
That's why a user won't know if a serial exist or not, he won't know that the serial is entered is assigned to someone else, that he does not have the right to perform the action, etc. It is security purposes !

I can see to add an option in the plugin instance configuration. So when you add a group filter, you could authorize the display of a message.
But I won't add that kind of message by default for everybody.

Regards,

---

Jerome - Obsidev.com
HikaMarket &amp; HikaSerial developer / HikaShop core dev team.

Please [Log in](/login?return=aHR0cHM6Ly93d3cuaGlrYXNob3AuY29tL2ZvcnVtLzE0LWhpa2FzZXJpYWwvODg4MzEyLXJlcXVlc3QtZm9yLW1vZGlmaWNhdGlvbi1pbi1ncm91cGZpbHRlcmNvbnN1bWVyLXBsdWdpbj90bXBsPW1hcmtkb3du) or [Create an account](/component/users/registration?Itemid=101) to join the conversation.

- **[sabroso](/forum/user/38789-sabroso "View sabroso's Profile")**
- [![sabroso's Avatar](https://www.hikashop.com/media/kunena/core/svg/person.svg)](/forum/user/38789-sabroso "View sabroso's Profile") Topic Author
- [ Offline](/forum/user/38789-sabroso)

Less More

- Posts: 128
- Thank you received: 2
-
-

9 years 10 months ago [\#259553](#259553) by [sabroso](/forum/user/38789-sabroso "View sabroso's Profile")  Replied by *[sabroso](/forum/user/38789-sabroso "View sabroso's Profile")* on topic *[Request for modification in groupfilterconsumer plugin](/forum/14-hikaserial/888312-request-for-modification-in-groupfilterconsumer-plugin#259553 "-- HikaShop version -- : 2.6.4 -- HikaSerial version -- : 1.10.4 -- Joomla version -- : 3.6.5 -- PHP version -- : 5.6  Hi there,  It is great that we can control what user groups can consume certain serials with the groupfilterconsumer plugin, but I feel it is missing an error message in case the user is not authorized to consume the serial. I feel we need to show the reason why there is a problem when the serial consumption does not work due to this plugin.  I propose the following change in groupfilterconsumer.php  Replace this (line 73)  By this  Would this be possible please?  Many thanks!")*

I see your point, somebody could try to guess valid serials by looking at the error message provided when trying to consume it.

OK, let's leave it as it is, thanks!

Please [Log in](/login?return=aHR0cHM6Ly93d3cuaGlrYXNob3AuY29tL2ZvcnVtLzE0LWhpa2FzZXJpYWwvODg4MzEyLXJlcXVlc3QtZm9yLW1vZGlmaWNhdGlvbi1pbi1ncm91cGZpbHRlcmNvbnN1bWVyLXBsdWdpbj90bXBsPW1hcmtkb3du) or [Create an account](/component/users/registration?Itemid=101) to join the conversation.

Board Categories HikaShop Install &amp; Update Product &amp; Category Display Content Creation Sales and Orders Orders management Reports &amp; Statistics Customers Checkout Payment Methods Shipping Methods Import &amp; Export (CSV, XLS…) Specific Features Affilation Taxes Wishlist Vote Carousel &amp; Slider Mass Actions Filters &amp; Search Discount &amp; Coupon Feature Request Integrations Showcase General Talk about HikaShop Development HikaShop 3.0 Beta Translation Commercial Jobs HikaShop Components HikaMarket Market: Feature requests Market: How to? Market: Bug Report HikaSerial General talk about HikaSerial Serial: Bug Report Serial: How to? Support en Français de HikaSerial (French Support) HikaSubscription HikaAuction Auction: Feature requests Auction: How to? Auction: Bug report Hikashop around the world Support en Français (French Support) Russian FAQ. Курс выживания с Hikashop. Частые вопросы и о Расширения Hikashop Наши сайты на Hikashop 日本語版サポート(Japanese Support) Thai German Archives Bug Report How to?

Moderators: [Obsidev](/forum/user/7040-obsidev "View Obsidev's Profile")

[](/forum/topics/feed/mode-topics?format=feed&type=rss)

Time to create page: 0.052 seconds

[Powered by](/forum/credits) [Kunena Forum](https://www.kunena.org)
