Filters shouldn't apply to the selector in list view

mikekiy
Topic Author
Offline

8 years 8 months ago #286339 by mikekiy

Filters shouldn't apply to the selector in list view was created by mikekiy

-- HikaShop version -- : 3.2.2
-- Joomla version -- : 3.8.3

Hello,

You are filtering the Display -> Views view filters when a filter has been set.

I.E. Select Template 'Protostar' the list of items should be filters by protostar as they are great! But then change to say another template, you can't as only Protostar is selectable. You need to stop the filtering on this filter.

I looked at the codebase, but it doesn't follow the Joomla! MVC so thought it would be quicker to report it since you know your codebase.

Many thanks
Tony

Please Log in or Create an account to join the conversation.

nicolas
Away

8 years 8 months ago #286379 by nicolas

Replied by nicolas on topic Filters shouldn't apply to the selector in list view

Hi,

Thank you for your feedback.
It requires changing the code:

Code:

						if(!empty($pageInfo->filter->template) && $joomlaTemplates[$i]->directory!=$pageInfo->filter->template){
							continue;
						}

						$templateValues[$joomlaTemplates[$i]->directory]=$joomlaTemplates[$i]->directory;

to:

Code:

						$templateValues[$joomlaTemplates[$i]->directory]=$joomlaTemplates[$i]->directory;

						if(!empty($pageInfo->filter->template) && $joomlaTemplates[$i]->directory!=$pageInfo->filter->template){
							continue;
						}

in the file administrator/components/com_hikashop/views/view/view.html.php
We'll add that to the next version on our end.

The following user(s) said Thank You: mikekiy

Please Log in or Create an account to join the conversation.

Time to create page: 0.194 seconds