- Posts: 15
- Thank you received: 2
inc/boxpacker.php file typo
6 years 5 months ago #317264
by brodders
inc/boxpacker.php file typo was created by brodders
-- HikaShop version -- : 4.2.3
While reviewing our project codebase to ensure no php shortcodes in use, we've spotted what looks like a potential mistake in the Hikashop inc/boxpack.php file:
Line 10 is:
?><?<?php
Suspect it should be:
?><?php
Hope this is useful!
While reviewing our project codebase to ensure no php shortcodes in use, we've spotted what looks like a potential mistake in the Hikashop inc/boxpack.php file:
Line 10 is:
?><?<?php
Suspect it should be:
?><?php
Hope this is useful!
Please Log in or Create an account to join the conversation.
6 years 5 months ago #317266
by nicolas
Replied by nicolas on topic inc/boxpacker.php file typo
Hi,
Thanks. Yes, it is a mistake. This file is actually not used for now. It's something we have in the making to better calculate packages dimensions for shipping methods in the future. Having that extra text in there won't change anything but we'll have to clen it when we work on it so I've removed the extra text for the next release.
Thanks. Yes, it is a mistake. This file is actually not used for now. It's something we have in the making to better calculate packages dimensions for shipping methods in the future. Having that extra text in there won't change anything but we'll have to clen it when we work on it so I've removed the extra text for the next release.
Please Log in or Create an account to join the conversation.
6 years 5 months ago #317347
by brodders
Replied by brodders on topic inc/boxpacker.php file typo
Great, thanks Nicolas!
The following user(s) said Thank You: Philip
Please Log in or Create an account to join the conversation.
Time to create page: 0.177 seconds