inc/boxpacker.php file typo

  • Posts: 15
  • Thank you received: 2
2 years 1 month ago #317264

-- HikaShop version -- : 4.2.3

While reviewing our project codebase to ensure no php shortcodes in use, we've spotted what looks like a potential mistake in the Hikashop inc/boxpack.php file:

Line 10 is:
?><?<?php

Suspect it should be:
?><?php

Hope this is useful!

Please Log in or Create an account to join the conversation.

  • Posts: 75479
  • Thank you received: 11747
  • MODERATOR
2 years 1 month ago #317266

Hi,

Thanks. Yes, it is a mistake. This file is actually not used for now. It's something we have in the making to better calculate packages dimensions for shipping methods in the future. Having that extra text in there won't change anything but we'll have to clen it when we work on it so I've removed the extra text for the next release.

Please Log in or Create an account to join the conversation.

  • Posts: 15
  • Thank you received: 2
2 years 1 month ago #317347

Great, thanks Nicolas!

The following user(s) said Thank You: Philip

Please Log in or Create an account to join the conversation.

Time to create page: 0.058 seconds
Powered by Kunena Forum