- Posts: 14
- Thank you received: 2
Billing address edit button floating
13 years 6 months ago - 13 years 6 months ago #100190
by bootfair
Billing address edit button floating was created by bootfair
Hi,
I am using a third party bootsrap plugin to have responsive lay out in hikashop. It wokrs fine except for on the check out the billing address edit icon floats on the top of the page in an already open modal box like here;
image missing http://your-sandbox.info/modal-css.jpg
When I turn the modal.less off from the plugin's panel, it sits where it should do, but then I lose the css styling on the next step in choosing payment methods. I have already written to the developers of the bootstrap plugin but I am wondering if I can find a solution here too.
What I would like to be able to do is either add some css to the third party's modal.less styling sheet so that the address edit icon and the modal works correctly OR have the non-responsive css for the payment options step where I can have radio buttons to select payment method (This way I can have the modals.less turned off, have my address edit icon in place and have at least readio buttons on the payment method page.
Any chance for help in this.
Many thanks.
PS. Attaching the modals.less file if needed and the url where I am working on this is brightstar.your-sandbox.info/
//////////
I have found that this behaviour is related to hikashop after testing this situation with 4 more templates with built in bootstrap with the thridparty bootstrap plugin disabled. Because the problem was still there even with the plugin disabled.
In the mean time I have received a reply from the developers saying;
"We've had time to initially review your issue, and we think we've a solution. Seems that you have assigned an incorrect class to the billing address button. "modal" should be used only in the <div> containing address form, not in the button itself. In our test, removing class has corrected behavior, as you can see in attached screenshots.".
Screen shot is here;
image missing http://your-sandbox.info/bootstrap.jpg
I have tried to find the file to edit with no luck. any chance for you guys pointing me to the right file to edit this.
Many thanks
I am using a third party bootsrap plugin to have responsive lay out in hikashop. It wokrs fine except for on the check out the billing address edit icon floats on the top of the page in an already open modal box like here;
image missing http://your-sandbox.info/modal-css.jpg
When I turn the modal.less off from the plugin's panel, it sits where it should do, but then I lose the css styling on the next step in choosing payment methods. I have already written to the developers of the bootstrap plugin but I am wondering if I can find a solution here too.
What I would like to be able to do is either add some css to the third party's modal.less styling sheet so that the address edit icon and the modal works correctly OR have the non-responsive css for the payment options step where I can have radio buttons to select payment method (This way I can have the modals.less turned off, have my address edit icon in place and have at least readio buttons on the payment method page.
Any chance for help in this.
Many thanks.
PS. Attaching the modals.less file if needed and the url where I am working on this is brightstar.your-sandbox.info/
//////////
I have found that this behaviour is related to hikashop after testing this situation with 4 more templates with built in bootstrap with the thridparty bootstrap plugin disabled. Because the problem was still there even with the plugin disabled.
In the mean time I have received a reply from the developers saying;
"We've had time to initially review your issue, and we think we've a solution. Seems that you have assigned an incorrect class to the billing address button. "modal" should be used only in the <div> containing address form, not in the button itself. In our test, removing class has corrected behavior, as you can see in attached screenshots.".
Screen shot is here;
image missing http://your-sandbox.info/bootstrap.jpg
I have tried to find the file to edit with no luck. any chance for you guys pointing me to the right file to edit this.
Many thanks
Last edit: 13 years 6 months ago by bootfair. Reason: Updated info from plugin developer
Please Log in or Create an account to join the conversation.
13 years 6 months ago #100283
by nicolas
Replied by nicolas on topic Billing address edit button floating
Hi,
I'm surprised of their answer actually.
Having a class="modal" on the a tags is the standard method in joomla in order to have mootools popups: stackoverflow.com/questions/8612431/how-...omla/8622928#8622928
You will have the same issue with any extension using the joomla popup system. For example :
forum.virtuemart.net/index.php?topic=111364.0
The proper solution would be to not use .modal but div.modal in the their extension's modal.less file.
Nevertheless, if you want to remove the class="modal" on a tags, you can change the code:
$this->getAttr($attr,'modal')
to:
$this->getAttr($attr,'')
in the file administrator/components/com_hikashop/helpers/popup.php
I'm surprised of their answer actually.
Having a class="modal" on the a tags is the standard method in joomla in order to have mootools popups: stackoverflow.com/questions/8612431/how-...omla/8622928#8622928
You will have the same issue with any extension using the joomla popup system. For example :
forum.virtuemart.net/index.php?topic=111364.0
The proper solution would be to not use .modal but div.modal in the their extension's modal.less file.
Nevertheless, if you want to remove the class="modal" on a tags, you can change the code:
$this->getAttr($attr,'modal')
to:
$this->getAttr($attr,'')
in the file administrator/components/com_hikashop/helpers/popup.php
Please Log in or Create an account to join the conversation.
Less
More
- Posts: 502
- Thank you received: 12
13 years 3 weeks ago #126583
by fafamaster
Replied by fafamaster on topic Billing address edit button floating
hello,
I have exactly the same problem but the solution does not work!
I'm running joomla 3.1.5 with the latest version of Hikashop
an idea?
site: dev.lalumieredesfees.com
thanks
I have exactly the same problem but the solution does not work!
I'm running joomla 3.1.5 with the latest version of Hikashop
an idea?
site: dev.lalumieredesfees.com
thanks
Please Log in or Create an account to join the conversation.
13 years 3 weeks ago #126584
by Jerome
Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.
Replied by Jerome on topic Billing address edit button floating
Hi,
www.hikashop.com/forum/2-general-talk-ab...4-shopping-cart.html
www.hikashop.com/forum/4-how-to/84196-an...obile-bootstrap.html
www.hikashop.com/forum/install-update/86...terms-condition.html
We are working on the address improvements in order to let them editable like in the HikaShop backend (HikaMarket ajax style).
Regards,
www.hikashop.com/forum/2-general-talk-ab...4-shopping-cart.html
www.hikashop.com/forum/4-how-to/84196-an...obile-bootstrap.html
www.hikashop.com/forum/install-update/86...terms-condition.html
We are working on the address improvements in order to let them editable like in the HikaShop backend (HikaMarket ajax style).
Regards,
Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.
Please Log in or Create an account to join the conversation.
Less
More
- Posts: 502
- Thank you received: 12
13 years 3 weeks ago #126608
by fafamaster
Replied by fafamaster on topic Billing address edit button floating
Thank you jerome, it's ok for me:
change ".modal" to "div.modal" in the bootstrap.css
still a little problem:
Terms of the popup does not open!
either this is a mootools full article pages
either bootstrap, this is a black voil but no popup
I try to change the popup as mentioned here (above)
but nothing works!
Thank you for your help
change ".modal" to "div.modal" in the bootstrap.css
still a little problem:
Terms of the popup does not open!
either this is a mootools full article pages
either bootstrap, this is a black voil but no popup
I try to change the popup as mentioned here (above)
but nothing works!
Thank you for your help
Please Log in or Create an account to join the conversation.
13 years 3 weeks ago #126612
by bootfair
Hi,
I am attaching the solution that has worked for me. A "Read me" text with instructions is also included in the zip file. Just unzip and follow simple instructions on the "Read Me" file.
I hope this works for you too.
Regards
Replied by bootfair on topic Billing address edit button floating
fafamaster wrote: hello,
I have exactly the same problem but the solution does not work!
I'm running joomla 3.1.5 with the latest version of Hikashop
an idea?
site: dev.lalumieredesfees.com
thanks
Hi,
I am attaching the solution that has worked for me. A "Read me" text with instructions is also included in the zip file. Just unzip and follow simple instructions on the "Read Me" file.
I hope this works for you too.
Regards
The following user(s) said Thank You: fafamaster
Please Log in or Create an account to join the conversation.
13 years 3 weeks ago #126614
by Jerome
Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.
Replied by Jerome on topic Billing address edit button floating
Hi,
You don't have to modify the classname in the HTML content, just in the CSS part.
Your popup link is now:
and his classname does not allow mootools to work properly.
I am working on a patch in order to not use anymore this "modal" classname but I need to make more test before release it (I don't want to break something in users' websites).
Regards,
You don't have to modify the classname in the HTML content, just in the CSS part.
Your popup link is now:
Code:
<a class="div.modal" id="shop_terms_and_cond" href="/index.php/component/content/article?id=39&tmpl=component" rel="{handler: 'iframe', size: {x: 450, y: 480}}">Veuillez accepter les conditions générales de vente avant de continuer</a>
I am working on a patch in order to not use anymore this "modal" classname but I need to make more test before release it (I don't want to break something in users' websites).
Regards,
Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.
Please Log in or Create an account to join the conversation.
Time to create page: 0.082 seconds