HikaShop no SSL outside checkout plugin - WHY?
11 years 2 months ago - 11 years 2 months ago #207762
by iedwards
HikaShop no SSL outside checkout plugin - WHY? was created by iedwards
-- HikaShop version -- : 2.5.0
-- Joomla version -- : 3.4.1
Hi,
What is the purpose of the "HikaShop no SSL outside checkout" plugin?
I have been trying to implement SSL across my site and have spent all day trying to track down the cause of a "too many redirects" error to discover that every time Joomla tried to redirect a page to https this plugin was redirecting it back to http, and so causing a redirect loop. In my opinion Hikashop has no place over riding other settings in Joomla.
Anyway I have disabled the plugin but now the geolocation plugin breaks my home page with an error, it doesn't seem to like https, I have disabled that as I don't really need it, but now a script of my own which tries to access hikashop_config() to read the users affiliate id throws an undefined function error with SSL enabled. Worked fine with non SSL. Or is it that the redirect plugin was making the hikashop_config() function available?
Many thanks,
Ian
-- Joomla version -- : 3.4.1
Hi,
What is the purpose of the "HikaShop no SSL outside checkout" plugin?
I have been trying to implement SSL across my site and have spent all day trying to track down the cause of a "too many redirects" error to discover that every time Joomla tried to redirect a page to https this plugin was redirecting it back to http, and so causing a redirect loop. In my opinion Hikashop has no place over riding other settings in Joomla.
Anyway I have disabled the plugin but now the geolocation plugin breaks my home page with an error, it doesn't seem to like https, I have disabled that as I don't really need it, but now a script of my own which tries to access hikashop_config() to read the users affiliate id throws an undefined function error with SSL enabled. Worked fine with non SSL. Or is it that the redirect plugin was making the hikashop_config() function available?
Many thanks,
Ian
Last edit: 11 years 2 months ago by iedwards.
Please Log in or Create an account to join the conversation.
11 years 2 months ago - 11 years 1 month ago #207769
by nicolas
Replied by nicolas on topic HikaShop no SSL outside checkout plugin - WHY?
Hi,
Its purpose is to redirect to HTTP outside of the checkout so that only the checkout uses HTTPS.
It is to be used in conjunction with the "force SSL on checkout" setting of the HikaShop configuration.
This plugin is disabled by default so if it was active, it means that you must have activated it. As you say, it has no place overriding Joomla on that and that's why it is disabled by default. But some merchants want to be able to have HTTPS only on the checkout so the plugin is there. It doesn't mean that you should use it.
hikashop_config is not available unless you include the HikaShop main helper file. The no SSL outside checkout will load that helper when checking if the current page uses SSL or not.
But in your own code, you should always load the main helper if you need HikaShop functions and you're not sure whether HikaShop is already loaded or not:
Its purpose is to redirect to HTTP outside of the checkout so that only the checkout uses HTTPS.
It is to be used in conjunction with the "force SSL on checkout" setting of the HikaShop configuration.
This plugin is disabled by default so if it was active, it means that you must have activated it. As you say, it has no place overriding Joomla on that and that's why it is disabled by default. But some merchants want to be able to have HTTPS only on the checkout so the plugin is there. It doesn't mean that you should use it.
hikashop_config is not available unless you include the HikaShop main helper file. The no SSL outside checkout will load that helper when checking if the current page uses SSL or not.
But in your own code, you should always load the main helper if you need HikaShop functions and you're not sure whether HikaShop is already loaded or not:
Code:
if (!defined('DS'))
define('DS', DIRECTORY_SEPARATOR);
if(!include_once(rtrim(JPATH_ADMINISTRATOR,DS).DS.'components'.DS.'com_hikashop'.DS.'helpers'.DS.'helper.php')) return true;
Last edit: 11 years 1 month ago by Jerome.
Please Log in or Create an account to join the conversation.
11 years 1 month ago #213064
by iedwards
Replied by iedwards on topic HikaShop no SSL outside checkout plugin - WHY?
Hi Nicolas,
Just an update on this, I recently had to do a re-instal of Hikashop over my existing installation and after the re-install the "HikaShop no SSL outside checkout" plugin had enabled itself. I haven't tried a fresh install to verify this but it leads me to think this plugin is actually enabled by default, not disabled as you say.
Ian
Just an update on this, I recently had to do a re-instal of Hikashop over my existing installation and after the re-install the "HikaShop no SSL outside checkout" plugin had enabled itself. I haven't tried a fresh install to verify this but it leads me to think this plugin is actually enabled by default, not disabled as you say.
Ian
Please Log in or Create an account to join the conversation.
11 years 1 month ago #213066
by Jerome
Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.
Replied by Jerome on topic HikaShop no SSL outside checkout plugin - WHY?
Hi,
No.
Here the code from the HikaShop Update Helper :
the plugin is unpublished by defaul (last "0").
So Nicolas was right.
Regards,
No.
Here the code from the HikaShop Update Helper :
Code:
'plg_system_nossloutsidecheckout' => array('HikaShop no SSL outside checkout plugin',0,0)
So Nicolas was right.
Regards,
Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.
Please Log in or Create an account to join the conversation.
11 years 1 month ago #213110
by iedwards
Replied by iedwards on topic HikaShop no SSL outside checkout plugin - WHY?
I'm just reporting that I had the plugin switched off, re-installed Hikashop over the existing installation after which the plugin was switched on. That's not the behaviour I expected. There must be some other reason why that would be which you might like to investigate.
Ian
Ian
Please Log in or Create an account to join the conversation.
11 years 1 month ago #213112
by Jerome
Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.
Replied by Jerome on topic HikaShop no SSL outside checkout plugin - WHY?
Hi,
We will investigate.
Regards,
We will investigate.
Regards,
Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.
Please Log in or Create an account to join the conversation.
Time to create page: 0.176 seconds