Menu config setting always auto-generated

-- HikaShop version -- : 4.2.2
-- Joomla version -- : 3.9.16
-- PHP version -- : 7.4.3
-- Browser(s) name and version -- : Chrome
-- Error-message(debug-mod must be tuned on) -- : Menu config setting always auto-generated.

The problem is that 'modules' data is not presented in 'menu_XXX' config, Hikashop tries to insert new config value but
'modules' are no auto-generated via hikashopMenusClass::createAssocModule() because it has the test:
if(HIKASHOP_J30)
return false;

The problem is that 'modules' data is not presented in 'menu_XXX' config, Hikashop tries to insert/update new config value in hikashopMenusClass::createMenuOption() but 'modules' are no auto-generated via hikashopMenusClass::createAssocModule() because it has the test:

HIKASHOP_J30 is TRUE for Hikashop 4.2.2

Hi,

That's normal. HIKASHOP_J30 will be true if Joomla is at least in version 3.0.0.
And for Joomla 3.0.0, modules and menu items settings are not stored any more in the hikashop_config table.
they are now stored automatically by Joomla with the rest of the settings of your menu items / modules.

But menu_XXX config value is always updated on each page load even if there is no need to update it!

Hi,

Where does it do that ?
I'm surprised you're saying that. When you click on the "save" button of a modules / menu item setting, Joomla has no plugin trigger. So HikaShop is not even called to do the saving. So I don't see why menu_XX would be updated when you do this.

The only reason it would is if you're on Joomla 2.5 and editing the menus/modules via the menu Display>Content menus, which is removed for Joomla 3.

Hikashop config named menu_XXX doesn't have 'modules' param
On each page load the config value is loaded, next checked for 'modules' param presence.
If it's not presented, Hikashop tries to add it and update menu_XXX config value.
The problem is that 'modules' param is never generated, hence menu_XXX config value is always updated on each page load - completely useless.

Just research the SQL queries produced by Hikashop.

Hi,

It looks obvious to you but it wasn't for me.
I understand now that you were talking about the products listing pages on your frontend and not the saving of the settings in the backend.
I could indeed found the useless query. I've added a patch for that for the next version of HikaShop.