Filtered values container not showing right after update 4.4.0

-- HikaShop version -- : 4.4.0
-- Joomla version -- : 3.9.23
-- PHP version -- : 7.3.25
-- Browser(s) name and version -- : Firefox 83.0

Hi there,

After filtering products the filtered values container is altered in the last update and not showing the right way. It's now a <ul class="hiakshop_filter_selected_list"> instead of a <span class="filter_values_container">, with hikashop wrongly spelled as hiakshop. Maybe there's the problem! See screenshots (first and last ones are from the updated/wrong site, the others are right).

Hello,

Quite strange because, for us this little mistake was corrected a long time ago, maybe a remainder ? Or maybe despite you use the last HikaShop version this come from an old override view ?

Process a test with a default template like ProtoStar, and check if that correct your html class, and if not provide us backend references (with full access) use our Contact us form to provide these elements, just don't forget to add an Url link to this topic.

Awaiting your returns to progress on your subject.
Regards

Hi Philip,
When assigning protostar as template the problem remains. It's strange, because we didn't have this problem in 4.3.0 (still in use on our other website ). Occurred after updating to 4.4.0. I will send you back-end access via the form.

Cheers,
Remco

Hi,

So two things here:
- Regarding the typo in the class name, we indeed made a mistake there. I've made a patch on our end to fix that.
You can download the install package again on our website and install it on yours and it will add the change, or just directly do the change in the file administrator/components/com_hikashop/classes/filter.php
- Regarding the fact that the HTML changed. We indeed changed the way it displays in order to use a ul/li list instead of the translations HIKA_FILTER_LIST_PREPEND and HIKA_FILTER_LIST_SEPARATOR which you had apparently used to customize the way it looked before. We did this change so that the customization of the look can now be done purely with CSS.
Note that the span with the class filter_values_container is still there as it encompass the whole area, as before.
I believe that it is a good change going forward but it will indeed require that you adapt a bit the CSS if you want it to look like before.

Hi Nicolas,

I never customized HIKA_FILTER_LIST_PREPEND and HIKA_FILTER_LIST_SEPARATOR, so that's not the reason it changed. I've changed hikashop_filter_checkbox (see screenshot for all changes) in display: flex. Otherwise the checkboxes will appear above the label instead of next to it for the unselected filters

Can you let me know if this is the proper way to show 'fa fa-times-circle' at the right of the selected filter label -> give span "filter_values_container" property -> display: ruby-text;


Cheers,
Remco

Hi,

You can add such CSS and it will display relatively the same:
.hiakshop_filter_selected_list li, ul.hiakshop_filter_selected_list {
display: inline;
}

Hi Nicolas,

Thanks for the info! Maybe it's an idea to make a change log for users before making changes like this in the code. So we know what we can expect when updating.

Cheers, Remco