Strange work of your Hikashop AlphaUserPoints Plug

lacasetta
Topic Author
Offline

13 years 4 months ago #104142 by lacasetta

Strange work of your Hikashop AlphaUserPoints Plug was created by lacasetta

Hi,
I notice a bad behavior of you payment points plugin.
So, first i have this first points situation

I have this setting on your plugin

I do a purchase of Euro 15,40 plus Euro 8 of shipping cost: the total is 23,40 - euro 1,80 for 36points = Euro 21,60

I set the order to payed and i have this situation

Then i set the order to confirmed and i have this

Finally i set the order to shipped and the final situation is

The sistem gives me an amount of 72 points
But i must have only 15 points that are the points of my last purchase.
What's wrong?

my site with Hikashop
www.lacasettabio.it

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

13 years 4 months ago #104175 by Jerome

Replied by Jerome on topic Strange work of your Hikashop AlphaUserPoints Plug

Hi,

You have a wrong configuration in the plugin.
In the option "Give points on statuses" you should list all "valid" statuses. So "shipped" should be in the list too.

Can you provide some text values instead of big screenshots, it is a little bit complicated to analyse the history of order/points.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

lacasetta
Topic Author
Offline

13 years 4 months ago #104263 by lacasetta

Replied by lacasetta on topic Strange work of your Hikashop AlphaUserPoints Plug

Yes, now it is better but it is not perfect.
So I have theese order statuses:
-none
-created
-waiting payment
-payed
-confirmed
-on shipping
-shipped
-cancelled
-refunded
The statuse i like to give points is payed, confirmed, on shipping and shipped (set on "Give points on statuses").
When a customer make an order the status is created and the system picks up the points to make the discount. This is OK.
Then, if i set the order on waiting payment the system refund the points. This is bad!

If I go from the order status created to the confirmed status directly the points system work well.
But i can not jump the waiting payment status and I can not give the point untill the order is payed.
What can i do to fix that?

my site with Hikashop
www.lacasettabio.it

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

13 years 4 months ago #104400 by Jerome

Replied by Jerome on topic Strange work of your Hikashop AlphaUserPoints Plug

Hi,

Please replace in the plugin

Code:

		if( !empty($order->order_status) &&
			$order->order_status != $this->previousOrderStatus &&
			!in_array($order->order_status, $confirmed) &&
			(in_array($this->previousOrderStatus, $confirmed) || $this->previousOrderStatus == $created)
		){

Code:

		if( !empty($order->order_status) &&
			$order->order_status != $this->previousOrderStatus &&
			!in_array($order->order_status, $confirmed) &&
			in_array($this->previousOrderStatus, $confirmed)
		){

It will fix the problem in your configuration.
I will make more tests in order to finish the patch (there are some specific cases to support).

Regards,

Please Log in or Create an account to join the conversation.

lacasetta
Topic Author
Offline

13 years 4 months ago #104740 by lacasetta

Replied by lacasetta on topic Strange work of your Hikashop AlphaUserPoints Plug

Hi,
i think there is something wrong on it.
I change the code on plugin>hikashoppayment>alphauserpoints>alphauserpoint.php
After that when i manage the status order i have a system block with a white page. It is the same, on frontend, when i add something on my cart.
When i come back to the original code all of things go fine.

my site with Hikashop
www.lacasettabio.it

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

13 years 4 months ago #104828 by Jerome

Replied by Jerome on topic Strange work of your Hikashop AlphaUserPoints Plug

Hi,

The white page should be a php error (error 500), but I test the file in my side, I didn't have such problem.
Please check if you had an error logged in the "php error log" for this specific file (the plugin file).

Regards,

Please Log in or Create an account to join the conversation.

lacasetta
Topic Author
Offline

13 years 4 months ago - 13 years 4 months ago #104839 by lacasetta

Replied by lacasetta on topic Strange work of your Hikashop AlphaUserPoints Plug

Ok, i tried again and now it works.
Maybe i made a mistake with a bracket.
:whistle:
Excuse me, Thanks!

Will it be on the next release or i have to keep it in mind?

my site with Hikashop
www.lacasettabio.it

Last edit: 13 years 4 months ago by lacasetta.

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

13 years 4 months ago #104847 by Jerome

Replied by Jerome on topic Strange work of your Hikashop AlphaUserPoints Plug

Hi,

It will be.

Regards,

The following user(s) said Thank You: lacasetta

Please Log in or Create an account to join the conversation.

lacasetta
Topic Author
Offline

13 years 4 months ago #104945 by lacasetta

Replied by lacasetta on topic Strange work of your Hikashop AlphaUserPoints Plug

Hi,
I'm sorry but i have another problem.
I set the access level for only registered user like this:

Access level Custom

Public
- - Manager
- - - - Administrator
X- - Registered
- - - - Author
- - - - - - Editor
- - - - - - - - Publisher
- - - - GAS
- - - - Rivenditori
- - Super Users

I tried with a GAS user and the plugin give me the discount
Why?

my site with Hikashop
www.lacasettabio.it

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

13 years 4 months ago #104965 by Jerome

Replied by Jerome on topic Strange work of your Hikashop AlphaUserPoints Plug

Hi,

GAS is under Registered. So I do not see any dysfunction.

Regards,

Please Log in or Create an account to join the conversation.

lacasetta
Topic Author
Offline

13 years 4 months ago #104975 by lacasetta

Replied by lacasetta on topic Strange work of your Hikashop AlphaUserPoints Plug

Excuse me, i'm sorry
But I can not understand haw does it work.
Yes Gas is under registered but i did'nt select the GAS. So, if i'll select registered it is like if i select all the user under registered without choice. Isn't it?

And also i tried with this:

Public
- - Manager
- - - - Administrator
- - - - GAS
X- - Registered
- - - - Author
- - - - - - Editor
- - - - - - - - Publisher
- - - - Rivenditori
- - Super Users

where GAS is under administrator and i selected only registered
The system give discount also to GAS. Is it ok for you?
If yes ...
How can i do to have a level forbidden to the discount?

my site with Hikashop
www.lacasettabio.it

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

13 years 4 months ago #105010 by Jerome

Replied by Jerome on topic Strange work of your Hikashop AlphaUserPoints Plug

Hi,

Please edit again the payment plugin and add the indicated code:

Code:

	function onAfterCartProductsLoad(&$cart) {
		$method = $this->getMethod();
		if(@$method->payment_params->virtual_coupon) {
// Begin: code to add
			if(hikashop_level(2) && !hikashop_isAllowed($method->payment_access))
				return;
// End: code to add
			if(isset($cart->additional['aup']))
				return;

It will test the user access even if the payment plugin is only called by triggers (and not filtered in the payment listing).

Regards,

Please Log in or Create an account to join the conversation.

lacasetta
Topic Author
Offline

13 years 4 months ago #105071 by lacasetta

Replied by lacasetta on topic Strange work of your Hikashop AlphaUserPoints Plug

I'm not very good to php program.
So, could you explain better how i have to add the code, please?
I tried just with a copy and paste at the end of the plugin code but the system goes block/error.

my site with Hikashop
www.lacasettabio.it

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

13 years 4 months ago #105098 by Jerome

Replied by Jerome on topic Strange work of your Hikashop AlphaUserPoints Plug

Hi,

It is the same thing are before when I gave you some code. Instead of, there is no replacement but insertion.
But finally, it is same process.

Replace

Code:

	function onAfterCartProductsLoad(&$cart) {
		$method = $this->getMethod();
		if(@$method->payment_params->virtual_coupon) {
			if(isset($cart->additional['aup']))
				return;

By:

Code:

	function onAfterCartProductsLoad(&$cart) {
		$method = $this->getMethod();
		if(@$method->payment_params->virtual_coupon) {
			if(hikashop_level(2) && !hikashop_isAllowed($method->payment_access))
				return;
			if(isset($cart->additional['aup']))
				return;

Regards,

Please Log in or Create an account to join the conversation.

lacasetta
Topic Author
Offline

13 years 4 months ago #105120 by lacasetta

Replied by lacasetta on topic Strange work of your Hikashop AlphaUserPoints Plug

Yes,
now i understand and it works.

Thanks a lot, Jerome!

my site with Hikashop
www.lacasettabio.it

Please Log in or Create an account to join the conversation.

lacasetta
Topic Author
Offline

13 years 4 months ago #105123 by lacasetta

Replied by lacasetta on topic Strange work of your Hikashop AlphaUserPoints Plug

Please, Just to understand the entire plugin could you explain me what is the use of:

Images
Price € EUR
Percentage %

I've looked for on the help instruction but there is any instruction.

my site with Hikashop
www.lacasettabio.it

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

13 years 4 months ago #105130 by Jerome

Replied by Jerome on topic Strange work of your Hikashop AlphaUserPoints Plug

Hi,

It is generic options of payment plugins when the plugin is used as a payment method (display as a payment method in the checkout).

Regards,

The following user(s) said Thank You: lacasetta

Please Log in or Create an account to join the conversation.

Time to create page: 0.258 seconds