Skip to main content

Category images overlap

More
10 years 1 month ago - 10 years 1 month ago #247207 by SnoozeULooze.co.za
-- HikaShop version -- : 2.6.0

Hi
I am having a problem with the category images, please find attached an image with 3 screen prints
1 - Is when I load the category page (no image width or height set)
2 - If I refresh the same page it then displays correctly
3 - If is set fixed image sizes it loads correctly and does not overlap but creates a horrible blank space instead.

Please let me know how to fix this, I am willing to renew my subscription and download the latest version if this will fix the problem.
Last edit: 10 years 1 month ago by SnoozeULooze.co.za.

Please Log in or Create an account to join the conversation.

More
10 years 1 month ago #247215 by nicolas
Replied by nicolas on topic Category images overlap
Hi,

You want to edit the file "listing_div" of the view "category" via the menu Display>Views and remove the code:
data-consistencyheight=".hikashop_subcontainer"

Please Log in or Create an account to join the conversation.

More
10 years 1 month ago #247387 by SnoozeULooze.co.za
Hi

I can't find that line of code in the listing_div
Code:
<?php /** * @package HikaShop for Joomla! * @version 2.6.0 * @author hikashop.com * @copyright (C) 2010-2015 HIKARI SOFTWARE. All rights reserved. * @license GNU/GPLv3 http://www.gnu.org/licenses/gpl-3.0.html */ defined('_JEXEC') or die('Restricted access'); ?><?php $mainDivName=$this->params->get('main_div_name'); $carouselEffect=$this->params->get('carousel_effect'); $enableCarousel=$this->params->get('enable_carousel'); $textCenterd=$this->params->get('text_center'); $this->align="left"; if($textCenterd){ $this->align="center"; } $height=$this->params->get('image_height'); $width=$this->params->get('image_width'); $borderClass=""; if($this->params->get('border_visible',1) == 1){ $borderClass="hikashop_subcontainer_border"; } if($this->params->get('border_visible',1) == 2){ $borderClass="thumbnail"; } if(empty($width) && empty($height)){ $width=$this->image->main_thumbnail_x; $height=$this->image->main_thumbnail_y; } $exists=false; if(!empty($this->rows)){ $row=reset($this->rows); if(!empty($row->file_path)){ jimport('joomla.filesystem.file'); if(JFile::exists($row->file_path)){ $exists=true; }else{ $exists=false; } } } if(!$exists){ $config = hikashop_config(); $path = $config->get('default_image'); if($path == 'barcode.png'){ $file_path=HIKASHOP_MEDIA.'images'.DS.'barcode.png'; } if(!empty($path)){ jimport('joomla.filesystem.file'); if(JFile::exists($this->image->main_uploadFolder.$path)){ $exists=true; } }else{ $exists=false; } if($exists){ $file_path=$this->image->main_uploadFolder.$path; } }else{ $file_path=$this->image->main_uploadFolder.$row->file_path; } if(!empty($file_path)){ if(empty($width)){ $imageHelper=hikashop_get('helper.image'); $theImage = new stdClass(); list($theImage->width, $theImage->height) = getimagesize($file_path); list($width, $height) = $imageHelper->scaleImage($theImage->width, $theImage->height, 0, $height); } if(empty($height)){ $imageHelper=hikashop_get('helper.image'); $theImage = new stdClass(); list($theImage->width, $theImage->height) = getimagesize($file_path); list($width, $height) = $imageHelper->scaleImage($theImage->width, $theImage->height, $width, 0); } } $this->newSizes = new stdClass(); $this->newSizes->height=$height; $this->newSizes->width=$width; $this->image->main_thumbnail_y=$height; $this->image->main_thumbnail_x=$width; $app = JFactory::getApplication(); $in_hikashop_context = (JRequest::getString('option') == HIKASHOP_COMPONENT && in_array(JRequest::getString('ctrl','category'), array('category', 'product'))); $cid = 0; $last_category_selected = 0; if($in_hikashop_context) { if(JRequest::getString('ctrl','category') == 'product' && JRequest::getString('task','listing') == 'show') { $last_category_selected = (int)$app->getUserState(HIKASHOP_COMPONENT.'.last_category_selected', 0); $config =& hikashop_config(); $pathway_sef_name = $config->get('pathway_sef_name', 'category_pathway'); $cid = JRequest::getInt($pathway_sef_name, 0); } else { $cid = JRequest::getInt('cid', 0); } } if(!empty($this->rows)){ $pagination = $this->config->get('pagination','bottom'); if(in_array($pagination,array('top','both')) && $this->params->get('show_limit') && $this->pageInfo->elements->total > $this->pageInfo->limit->value){ $this->pagination->form = '_top'; ?> <form action="<?php echo hikashop_currentURL();?>" method="post" name="adminForm_<?php echo $this->params->get('main_div_name').$this->category_selected;?>_top"> <div class="hikashop_subcategories_pagination hikashop_subcategories_pagination_top"> <?php echo $this->pagination->getListFooter($this->params->get('limit')); ?> <span class="hikashop_results_counter"><?php echo $this->pagination->getResultsCounter(); ?></span> </div> <input type="hidden" name="filter_order_<?php echo $this->params->get('main_div_name').$this->category_selected;?>" value="<?php echo $this->pageInfo->filter->order->value; ?>" /> <input type="hidden" name="filter_order_Dir_<?php echo $this->params->get('main_div_name').$this->category_selected;?>" value="<?php echo $this->pageInfo->filter->order->dir; ?>" /> <?php echo JHTML::_( 'form.token' ); ?> </form> <?php } ?> <div class="hikashop_subcategories" data-consistencyheight=".hikashop_subcontainer"> <?php if($enableCarousel){ $this->setLayout('carousel'); echo $this->loadTemplate(); } else{ $columns = (int)$this->params->get('columns'); if(empty($columns) || $columns<1) $columns = 1; $width = (int)(100/$columns)-1; $current_column = 1; $current_row = 1; if($this->params->get('only_if_products','-1')=='-1'){ $config =& hikashop_config(); $defaultParams = $config->get('default_params'); $this->params->set('only_if_products',@$defaultParams['only_if_products']); } $only_if_products = $this->params->get('only_if_products',0); if(HIKASHOP_RESPONSIVE) { switch($columns) { case 12: case 6: case 4: case 3: case 2: case 1: $row_fluid = 12; $span = $row_fluid / $columns; break; case 10: case 8: case 7: $row_fluid = $columns; $span = 1; break; case 5: $row_fluid = 10; $span = 2; break; case 9: // special case $row_fluid = 10; $span = 1; break; } $span = constant('HK_GRID_COL_'.$span); if($row_fluid == 12) echo '<div class="'.HK_GRID_ROW.'">'; else echo '<div class="row-fluid-'.$row_fluid.'">'; if(HK_GRID_THUMBNAILS !== false && HK_GRID_THUMBNAILS != '') echo '<ul class="'.HK_GRID_THUMBNAILS.'">'; } $found = 0; if($in_hikashop_context) { $found = $last_category_selected; foreach($this->rows as $row) { if($cid == $row->category_id) { $found = (int)$row->category_id; $app->setUserState(HIKASHOP_COMPONENT.'.last_category_selected', (int)$row->category_id); break; } } } $current_parent_category = 0; foreach($this->rows as $row){ if (!empty($row->childs) && array_key_exists($found, $row->childs)) $current_parent_category = $row->childs[$found]->category_parent_id; } foreach($this->rows as $row){ if($only_if_products && $row->number_of_products<1) continue; $class = ($found == $row->category_id) ? ' hikashop_current_category' : ''; $class = ($current_parent_category == $row->category_id) ? ' hikashop_current_parent_category' : ''; if(!HIKASHOP_RESPONSIVE) { ?> <div class="hikashop_category hikashop_category_column_<?php echo $current_column; ?> hikashop_category_row_<?php echo $current_row.$class; ?>" style="width:<?php echo $width;?>%;"> <div class="hikashop_container"> <div class="hikashop_subcontainer <?php echo $borderClass; ?>"> <?php } else { ?> <<?php echo (HK_GRID_THUMBNAILS !== false && HK_GRID_THUMBNAILS != '') ? 'li' : 'div'; ?> class="<?php echo $span; ?> hikashop_category hikashop_category_column_<?php echo $current_column; ?> hikashop_category_row_<?php echo $current_row.$class; ?>"> <div class="hikashop_container"> <div class="hikashop_subcontainer <?php echo $borderClass; ?>"> <?php } $this->row =& $row; echo $this->loadTemplate($this->params->get('div_item_layout_type')); if($this->params->get('child_display_type','inherit')=='inherit'){ $config =& hikashop_config(); $defaultParams = $config->get('default_params'); $this->params->set('child_display_type',$defaultParams['child_display_type']); } if($this->params->get('child_limit','')==''){ $config =& hikashop_config(); $defaultParams = $config->get('default_params'); $this->params->set('child_limit',$defaultParams['child_limit']); } switch($this->params->get('child_display_type')){ case 'nochild': default: break; case 'allchildsexpand': $limit = $this->params->get('child_limit'); case 'allchilds': if(!empty($this->row->childs)){ ?> <ul class="hikashop_category_list"> <?php $i=0; foreach($this->row->childs as $child){ if($only_if_products && $child->number_of_products<1) continue; if(!empty($limit) && $i >= $limit){ break; } $i++; $link = $this->getLink($child); $class = ($found == $child->category_id) ? ' hikashop_current_subcategory' : ''; ?> <li class="hikashop_category_list_item<?php echo $class; ?>"> <a href="<?php echo $link; ?>"> <?php echo $child->category_name; if($this->params->get('number_of_products',0)){ echo ' ('.$child->number_of_products.')'; } ?> </a> </li> <?php } ?> </ul> <?php } break; } if(!HIKASHOP_RESPONSIVE) { ?> </div> </div> </div> <?php } else { ?> </div> </div> </<?php echo (HK_GRID_THUMBNAILS !== false && HK_GRID_THUMBNAILS != '') ? 'li' : 'div'; ?>> <?php } if($current_column>=$columns){ $current_row++; if(!HIKASHOP_RESPONSIVE) { ?> <div style="clear:both"></div> <?php } $current_column=0; } $current_column++; } if(HIKASHOP_RESPONSIVE) { if(HK_GRID_THUMBNAILS !== false && HK_GRID_THUMBNAILS != '') echo '</ul>'; echo '</div>'; } } ?><div style="clear:both"></div> </div> <?php if(in_array($pagination,array('bottom','both')) && $this->params->get('show_limit') && $this->pageInfo->elements->total > $this->pageInfo->limit->value){ $this->pagination->form = '_bottom'; ?> <form action="<?php echo hikashop_currentURL();?>" method="post" name="adminForm_<?php echo $this->params->get('main_div_name').$this->category_selected;?>_bottom"> <div class="hikashop_subcategories_pagination hikashop_subcategories_pagination_bottom"> <?php echo $this->pagination->getListFooter($this->params->get('limit')); ?> <span class="hikashop_results_counter"><?php echo $this->pagination->getResultsCounter(); ?></span> </div> <input type="hidden" name="filter_order_<?php echo $this->params->get('main_div_name').$this->category_selected;?>" value="<?php echo $this->pageInfo->filter->order->value; ?>" /> <input type="hidden" name="filter_order_Dir_<?php echo $this->params->get('main_div_name').$this->category_selected;?>" value="<?php echo $this->pageInfo->filter->order->dir; ?>" /> <?php echo JHTML::_( 'form.token' ); ?> </form> <?php } }

Please Log in or Create an account to join the conversation.

More
10 years 1 month ago #247388 by lousyfool
Replied by lousyfool on topic Category images overlap
It's there. Around line 62 find this:
Code:
<div class="hikashop_products" data-consistencyheight=".hikashop_subcontainer">
and change it to:
Code:
<div class="hikashop_products">

Need help with customisations of layouts, style or other site development? PM me!
(Don't forget to turn on "E-mail notification of new messages" )

Please Log in or Create an account to join the conversation.

More
10 years 1 month ago #247389 by SnoozeULooze.co.za
Thank you I found it on line 118, clearly, I was not looking properly.

The fix seems to have worked thanks for the help

Please Log in or Create an account to join the conversation.

Time to create page: 0.167 seconds
Powered by Kunena Forum