Improvement saving/updating product prices

<td> <?php echo (!empty($row->price_id) ? $row->price_id : '--' ); ?><input type="hidden" id="price[price_id][<?php echo $i;?>]" name="price[price_id][<?php echo $i;?>]" value="<?php echo @$row->price_id; ?>" /> </td>

function updatePrices($element,$status){ if(count($element->prices)){ $delete_where = array(); $update_price_currency_id = array(); $update_price_value = array(); $update_price_min_quanity = array(); $update_where = array(); $insert = array(); foreach($element->prices as $price){ if(empty($price->price_value)){ $delete_where[] = (int)$price->price_id; } elseif($price->price_id){ $update_price_currency_id[] = sprintf("WHEN %d THEN %d ", $price->price_id, (int)$price->price_currency_id); $update_price_value[] = sprintf("WHEN %d THEN '%s' ", $price->price_id, (float)$price->price_value); $update_price_min_quanity[] = sprintf("WHEN %d THEN %d ", $price->price_id, (int)$price->price_min_quantity); $update_where[] = (int)$price->price_id; } else { $insert[]='('.(int)$price->price_currency_id.','.$status.','.(int)$price->price_min_quantity.','.(float)$price->price_value.')'; } } if(!empty($update_where)){ $query = 'UPDATE IGNORE '.hikashop::table('price').' SET price_currency_id = CASE price_id '.implode(' ',$update_price_currency_id).' END, price_value = CASE price_id '.implode(' ',$update_price_value).' END, price_min_quantity = CASE price_id '.implode(' ',$update_price_min_quanity).' END WHERE price_product_id='.$status.' AND price_id IN ('.implode(',',$update_where).');'; $this->database->setQuery($query); $this->database->query(); } if(!empty($insert)){ $query = 'INSERT IGNORE INTO '.hikashop::table('price').' (price_currency_id,price_product_id,price_min_quantity,price_value) VALUES '.implode(',',$insert).';'; $this->database->setQuery($query); $this->database->query(); } if(!empty($delete_where)){ $query = 'DELETE FROM '.hikashop::table('price').' WHERE price_product_id='.$status.' AND price_id IN ('.implode(',',$delete_where).');'; $this->database->setQuery($query); $this->database->query(); } } }

function updatePrices($element,$status){ $filters=array('price_product_id='.$status); if(count($element->prices)){ $ids = array(); foreach($element->prices as $price){ if(!empty($price->price_id)) $ids = $price->price_id; } if(!empty($ids)){ $filters[]= 'price_id NOT IN ('.implode(',',$ids).')'; } } $query = 'DELETE FROM '.hikashop::table('price').' WHERE '.implode(' AND ',$filters); $this->database->setQuery($query); $this->database->query(); if(count($element->prices)){ $insert = array(); foreach($element->prices as $price){ if(empty($price->price_value)) continue; if(empty($price->price_id)) $price->price_id = 'NULL'; $line = '('.(int)$price->price_currency_id.','.$status.','.(int)$price->price_min_quantity.','.(float)$price->price_value.','.$price->price_id; if(hikashop::level(2)){ if(empty($price->price_access)){ $price->price_access = 'all'; } $line.=','.$this->database->Quote($price->price_access); } $insert[]=$line.')'; } if(!empty($insert)){ $select = 'price_currency_id,price_product_id,price_min_quantity,price_value,price_id'; if(hikashop::level(2)){ $select.=',price_access'; } $query = 'REPLACE '.hikashop::table('price').' ('.$select.') VALUES '.implode(',',$insert).';'; $this->database->setQuery($query); $this->database->query(); } } }