W3C HTML5 Validation problem

LukeDouglas
Topic Author
Offline

11 years 5 months ago #197630 by LukeDouglas

W3C HTML5 Validation problem was created by LukeDouglas

-- HikaShop version -- : 2.4.0
-- Joomla version -- : 3.4.1
-- PHP version -- : 5.4.33
-- Browser(s) name and version -- : Multiple
-- Error-message(debug-mod must be tuned on) -- : Errors found while checking this document as HTML5!

baylissgallery.com

On the W3C validation for BaylissGallery.com ( W3C Validation Link ), we are getting an iframe error on the HikaShop Content Module for the Featured Product.

Could you implement HTML5 compliant changes in your next update?

Here is the error message:

Code:

Error Line 715, Column 190: Bad value {handler: 'iframe',size: {x: 480, y: 140}} for attribute rel on element a: The string {handler: is not a registered keyword.

				<div class="hikashop_container">

Syntax of list of link-type keywords:
    A whitespace-separated list of link types, with no duplicate keywords in the list. Each link type must be listed as allowed on <a> and <area> in the HTML specification, or must be listed as allowed on <a> and <area> on the Microformats wiki, or must be an absolute URL. You can register link types on the Microformats wiki yourself. 

Error Line 715, Column 370: Bad value {handler: 'iframe',size: {x: 480, y: 140}} for attribute rel on element a: The string {handler: is not a registered keyword.

				<div class="hikashop_container">

Syntax of list of link-type keywords:
    A whitespace-separated list of link types, with no duplicate keywords in the list. Each link type must be listed as allowed on <a> and <area> in the HTML specification, or must be listed as allowed on <a> and <area> on the Microformats wiki, or must be an absolute URL. You can register link types on the Microformats wiki yourself. 

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

11 years 5 months ago #197638 by Jerome

Replied by Jerome on topic W3C HTML5 Validation problem

Hi,

I am sorry but for the errors you got ; we can't.
The "rel handler" you have is the mootools lightbox system which is provided by Joomla itself.
You can see to switch to another lightbox system for your popup and your image popup (like "bootstrap" and "shadowbox") but you have to be sure that your template it compatible with.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Please Log in or Create an account to join the conversation.

LukeDouglas
Topic Author
Offline

11 years 5 months ago #197713 by LukeDouglas

Replied by LukeDouglas on topic W3C HTML5 Validation problem

Jerome,

I installed Mootools Enabler / Disabler and enabled all disabling of Mootools but that didn't work. Any other suggestions?

Luke

Please Log in or Create an account to join the conversation.

LukeDouglas
Topic Author
Offline

11 years 5 months ago #197763 by LukeDouglas

Replied by LukeDouglas on topic W3C HTML5 Validation problem

Jermone,

One of the Joomla admins stated this:

The possible "a rel" values are listed here: www.w3schools.com/tags/att_a_rel.asp

Hikashop is using this value: "{handler: 'iframe',size: {x: 480, y: 140}}"

This has nothing to do with MooTools, it's a problem with Hikashop. They just shouldn't assign this value to "rel".

A workaround would be to modify Hikashop's core to address this problem.

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

11 years 5 months ago #197769 by Jerome

Replied by Jerome on topic W3C HTML5 Validation problem

Hi,

Please read carefully what I wrote

The "rel handler" you have is the mootools lightbox system which is provided by Joomla itself.

I never wrote that it was mootools, but I wrote it was "mootools lightbox system" ; it means that it is a lightbox system which use mootools.
There is a nuance which had his importance.

So, if you read the rest of my message, I wrote that you have to use another popup system in HikaShop.
Please follow my indications.

The mootools modal (SqueezeBox) is provided by the javascript file "/media/system/js/modal.js" and is available since Joomla 1.5 and is still available in Joomla 3.4.
The only (and unique) way to use that SqueezeBox is to put a rel on a "a" link.
The other solution is to use another popup system ; like I suggested you in my previous message.

API Joomla for JHTML::_('behavior.modal')
api.joomla.org/cms-3/classes/JHtmlBehavior.html#method_modal

More details about the API of behavior.modal
api.joomla.fr/joomla25/d1/d74/classJHtml...5128b86e49164b9b7a5d

Example of use of modal in Joomla from docs.joomla website:
docs.joomla.org/Creating_a_modal_form_field

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Please Log in or Create an account to join the conversation.

LukeDouglas
Topic Author
Offline

11 years 5 months ago #197793 by LukeDouglas

Replied by LukeDouglas on topic W3C HTML5 Validation problem

OK, I understand what you are saying now.

So I have edited the configuration for the display to use a different popup mode.

However, I am still getting the same validation errors. Am I missing something?

Luke

Please Log in or Create an account to join the conversation.

nicolas
Offline

11 years 5 months ago #197811 by nicolas

Replied by nicolas on topic W3C HTML5 Validation problem

Hi,

The notice popup of the add to cart buttons always use the mootools popup system for now even if you change that setting.
In order to avoid that, you would have to change the "when a product is added to the cart" option of the HikaShop configuration so that it doesn't display the notice popup.
And that will remove that warning from the w3c validator.

Note that it is not because the w3c validator says that it is not valid that it means that it is a problem. The rel attribute used by the mootools popup system has been used a whole decade on many websites and works fine, and doesn't create any problem.

Please Log in or Create an account to join the conversation.

LukeDouglas
Topic Author
Offline

11 years 5 months ago #197931 by LukeDouglas

Replied by LukeDouglas on topic W3C HTML5 Validation problem

Nicholas,

I looked at all of the configuration options but could not find the "when a product is added to the cart" or I might be blind. Which configuration tab is it under?

Also, I know that websites work just find that do not validate correctly as I've used validation for well over a decade. However, I do have some clients that 'require' that their sites validate. I don't want to close a client because of this issue.

Luke

Please Log in or Create an account to join the conversation.

nicolas
Offline

11 years 5 months ago #197955 by nicolas

Replied by nicolas on topic W3C HTML5 Validation problem

Hi,

The exact name is "After a product is added to the cart". It's in the main tab.

Please Log in or Create an account to join the conversation.

LukeDouglas
Topic Author
Offline

11 years 5 months ago #198077 by LukeDouglas

Replied by LukeDouglas on topic W3C HTML5 Validation problem

Nicholas,

Well no wonder I couldn't see it. It's not there and I do have the current Hikashop version 2.4.0. Any ideas?

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

11 years 5 months ago #198080 by Jerome

Replied by Jerome on topic W3C HTML5 Validation problem

Hi,

The exact name is "After a product is added to the cart". It's in the main tab.

Please read carefully the Nicolas' message.

hint : you're not in the right tab.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Please Log in or Create an account to join the conversation.

LukeDouglas
Topic Author
Offline

11 years 5 months ago #198198 by LukeDouglas

Replied by LukeDouglas on topic W3C HTML5 Validation problem

OK, I found it. It was actually in the 'Cart' section of the 'Main' tab. It was not set to "Stay and display a popup notice" anyway. It was set to "Always go to the checkout". I changed it to "Always stay on the same page" but that didn't fix the problem.

Any other ideas?

Please Log in or Create an account to join the conversation.

nicolas
Offline

11 years 5 months ago #198232 by nicolas

Replied by nicolas on topic W3C HTML5 Validation problem

Hi,

I see that the code was changed in the add to cart system in order to fix something else which changed that behavior.
Change the line:
if($redirect=='ask_user' || hikashop_loadUser() == null){

to:
if($redirect=='ask_user'){
in the file administrator/components/com_hikashop/helpers/cart.php and that will remove that.

Please Log in or Create an account to join the conversation.

LukeDouglas
Topic Author
Offline

11 years 5 months ago #198277 by LukeDouglas

Replied by LukeDouglas on topic W3C HTML5 Validation problem

Nicholas,

That fixed it! Thanks.

However, you indicated that the code was original changed to fix something else. Would changing this code re-create a problem that the original code fixed? I would much rather have a 'validation' problem than to break the shopping cart from functioning properly.

Luke

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

11 years 5 months ago #198310 by Jerome

Replied by Jerome on topic W3C HTML5 Validation problem

Hi,

The commit that Nicolas pointed include several modifications and that specific modification might not be kept.
So I think that the revert that Nicolas wrote will be include in the next HikaShop release.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Please Log in or Create an account to join the conversation.

bdthemes
Offline

11 years 4 months ago #203184 by bdthemes

Replied by bdthemes on topic W3C HTML5 Validation problem

Hello hikashop guys, why you not use any other lightbox system for it? it will be a good decision if you use any others lightbox plugin.

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

11 years 4 months ago #203190 by Jerome

Replied by Jerome on topic W3C HTML5 Validation problem

Hi,

We are not opposed to, and we are already proposing "shadowbox" in the image lightbox systems

But if you have good solutions for the "content" popup system we are open to suggestions.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Please Log in or Create an account to join the conversation.

bdthemes
Offline

11 years 4 months ago #203518 by bdthemes

Replied by bdthemes on topic W3C HTML5 Validation problem

use magnefic popup or something like it: dimsemenov.com/plugins/magnific-popup/

Please Log in or Create an account to join the conversation.

Time to create page: 0.278 seconds