Squeezebox trouble after updates

nicolas
Away

10 years 5 months ago #237743 by nicolas

Replied by nicolas on topic Squeezebox trouble after updates

Hi,

Remove the line:
JHTML::_('behavior.tooltip');
in the file components/com_hikashop/views/checkout/view.html.php and that will fix this one.

Please Log in or Create an account to join the conversation.

olivnewton
Topic Author
Offline

10 years 5 months ago #237855 by olivnewton

Replied by olivnewton on topic Squeezebox trouble after updates

it was present twice, i removed it both times, hope that was ok!
no more JS errors, hope that was it now!
was quite a work to get it REAL-mootools-free...!

one problem remains after the update, in step-1 and step-5 (overview of the order incl. price, taxes, shipping costs etc.) there is no SHIPPING showing (but it gets added in the overall sum, i checked).
we do have an old override for cart.php with many style changes, so i tried adding the changed bit after the update inside lines 168-178 of the override, but had no luck... changed it back to how it was for now.
i am sure you can point out whats wring in an instance!!!

Please Log in or Create an account to join the conversation.

nicolas
Away

10 years 5 months ago #237867 by nicolas

Replied by nicolas on topic Squeezebox trouble after updates

Hi,

The problem is indeed coming from the cart file of the view checkout.
It uses this code now for the display of the shipping fees:

Code:

if(!empty($this->shipping)) {
?>
				<tr>
					<?php echo $td; ?>
					<td id="hikashop_checkout_cart_shipping_title" class="hikashop_cart_shipping_title hikashop_cart_title">
						<?php echo JText::_('HIKASHOP_SHIPPING'); ?>
					</td>
					<td class="hikashop_cart_shipping_value" data-title="<?php echo JText::_('HIKASHOP_SHIPPING'); ?>">
						<span class="hikashop_checkout_cart_shipping">
<?php
			if(isset($this->value)) {
				echo $this->value;
			} else {
				$shipping_price = null;
				foreach($this->shipping as $shipping) {
					if(!isset($shipping->shipping_price) && isset($shipping->shipping_price_with_tax) ) {
						$shipping->shipping_price = $shipping->shipping_price_with_tax;
						//$shipping->shipping_price_with_tax = 0.0;
					}
					if(isset($shipping->shipping_price)) {
						if($shipping_price === null)
							$shipping_price = 0.0;
						if(bccomp($taxes,0,5)==0 || !$this->params->get('price_with_tax') || !isset($shipping->shipping_price_with_tax)) {
							$shipping_price += $shipping->shipping_price;
						} else {
							$shipping_price += $shipping->shipping_price_with_tax;
						}
					}
				}
				if($shipping_price !== null) {
					echo $this->currencyHelper->format($shipping_price, $this->full_total->prices[0]->price_currency_id);
				}
			}
?>
						</span>
					</td>
				</tr>
<?php
		}

Please Log in or Create an account to join the conversation.

olivnewton
Topic Author
Offline

10 years 5 months ago #238367 by olivnewton

Replied by olivnewton on topic Squeezebox trouble after updates

nice! works!
no more JS errors so far.
we just did a last thourough test and teh following issue came up, which i dont know if it is related to all of those changes or not:

in step-1 (address), if i uncheck the box "delivery address is the same as billing address", then new fields to enter a new address appear, and no matter if i edit them and SAVE or CANCEL, after clicking on one of those two buttons it automatically advances to the next step (delivery method)

is this intended? i believe this is no good usability. can this be changed?

Please Log in or Create an account to join the conversation.

nicolas
Away

10 years 5 months ago #238387 by nicolas

Replied by nicolas on topic Squeezebox trouble after updates

Hi,

For the save, I believe it's intended because the page might need to change when the address changes.
For the cancel, it should indeed not do that. We've added a patch on our end for that.
Change the line:

Code:

if(JRequest::getVar('tmpl', '') == 'component') {

to:

Code:

if(JRequest::getVar('tmpl', '') == 'component' && JRequest::getVar('task', '') !='show') {

in the file "show" of the view "address" via the menu Display>Views and that should correct this behaviour.

Please Log in or Create an account to join the conversation.

olivnewton
Topic Author
Offline

10 years 5 months ago #238504 by olivnewton

Replied by olivnewton on topic Squeezebox trouble after updates

ok, it makes sense only for cancel.
now it does not jump to the next step anymore, but another weird behaviour appears:
- there remains an empty address (the checkbox "same as billing address" is still unchecked)
- if i manually delete this address, it jumps to the next step
- now i wonder (as a thoughtful user) if the checkbox is still unchecked or not, so i go one step back and all is ok

wouldnt it be better instead, if there is no empty address at all after "cancel"?
or
if i manually delete the empty address, it should stay on this step and rather set the checkbox back to "checked"?

i am not sure what is better or even if another solutions is better, it just feels weird the way it is now...

Please Log in or Create an account to join the conversation.

nicolas
Away

10 years 5 months ago - 10 years 5 months ago #238518 by nicolas

Replied by nicolas on topic Squeezebox trouble after updates

Hi,

Thank you for your feedback. I've spent a few hours testing the different combinations, and ways the address system can work and came up with a solution which works quite nicely.
I've had to modify several files at different places so I've generated a zip with the modified files so that you can compare them and change the places.
You'll see that I've reverted the change of my previous message to do it differently.

This attachment is hidden for guests.
Please log in or register to see it.

We'll also publish next week a new version with these changes included.

Last edit: 10 years 5 months ago by nicolas.

The following user(s) said Thank You: olivnewton

Please Log in or Create an account to join the conversation.

olivnewton
Topic Author
Offline

10 years 5 months ago #238733 by olivnewton

Replied by olivnewton on topic Squeezebox trouble after updates

this is brilliant! works really good the address changes. tested all thouroughly.
i am glad i could help!

finally i guess the project mootools-free is for (at least) me, so far successfully finished
thanks for all great support

Please Log in or Create an account to join the conversation.

olivnewton
Topic Author
Offline

9 years 8 months ago #260287 by olivnewton

Replied by olivnewton on topic Squeezebox trouble after updates

Sorry for reopening this, but could it be that after the last Joomla Updates, all the changes made with add/change address are now not working? We did not update HikaShop since then! Still using 2.6.1, but obviously Joomla has been updated many times due to the heavy security issues. Currently running on: J3.6.5
Any idea?

Please Log in or Create an account to join the conversation.

nicolas
Away

9 years 8 months ago #260293 by nicolas

Replied by nicolas on topic Squeezebox trouble after updates

Hi,

Joomla changed some things with the popups since then yes. And we had to add fixes in HikaShop to counter that. So you might have to update. Noe however that with HikaShop 3.0.0, a lot of things changed so it would be better to first try on a copy of the website.

HikaShop 3.0.0 is a lot more mootools free than the 2.x.x versions.
The only thing left is the carousel system which you don't use.

Please Log in or Create an account to join the conversation.

Time to create page: 0.237 seconds