- Posts: 610
- Thank you received: 13
Issue with mass select and changing status in the back end
- mohairbears
-
Topic Author
- Offline
Less
More
8 months 1 week ago #370645
by mohairbears
-- HikaShop version -- : 6.3
-- Joomla version -- : 5.4
-- PHP version -- : 8.2
Hi, 2 issues on the back end orders page:
1. cannot 'mass select' like we can on all other back end pages?
2. cannot change the 'status' from outside the order? we used to be able to?
Guessing the 2 are related as they both in the orders page.
Thanks
-- Joomla version -- : 5.4
-- PHP version -- : 8.2
Hi, 2 issues on the back end orders page:
1. cannot 'mass select' like we can on all other back end pages?
2. cannot change the 'status' from outside the order? we used to be able to?
Guessing the 2 are related as they both in the orders page.
Thanks
Please Log in or Create an account to join the conversation.
8 months 1 week ago #370647
by nicolas
Replied by nicolas on topic Issue with mass select and changing status in the back end
Hi,
This indicates a JavaScript error on the page, which leads to both mechanisms not working. Please provide a backend access so that we can check:
www.hikashop.com/support/contact-us.html
This indicates a JavaScript error on the page, which leads to both mechanisms not working. Please provide a backend access so that we can check:
www.hikashop.com/support/contact-us.html
Please Log in or Create an account to join the conversation.
8 months 1 week ago #370669
by nicolas
Replied by nicolas on topic Issue with mass select and changing status in the back end
Hi,
Looking at the HTML source of your page, I can see that the onchange attributes on the status dropdown selects have been rewritten to on-change (with a hyphen), and the onclick on the mass select checkbox has been rewritten to on-click. These are not valid HTML event attributes, so the browser simply ignores them which is why both features are broken.
This is not coming from HikaShop. Our code outputs the correct onchange and onclick attributes. The modification is most likely done by RSFirewall, which sanitizes inline JavaScript event handlers as part of its XSS protection.
The event handlers may have been sanitized when the override file was created or processed. You can delete the view override for order / listing via the menu Display>Views and it will fix the problem.
You can also configure an exception in RSFirewall's configuration for the HikaShop view overrides so that it doesn't happen again in the future.
Looking at the HTML source of your page, I can see that the onchange attributes on the status dropdown selects have been rewritten to on-change (with a hyphen), and the onclick on the mass select checkbox has been rewritten to on-click. These are not valid HTML event attributes, so the browser simply ignores them which is why both features are broken.
This is not coming from HikaShop. Our code outputs the correct onchange and onclick attributes. The modification is most likely done by RSFirewall, which sanitizes inline JavaScript event handlers as part of its XSS protection.
The event handlers may have been sanitized when the override file was created or processed. You can delete the view override for order / listing via the menu Display>Views and it will fix the problem.
You can also configure an exception in RSFirewall's configuration for the HikaShop view overrides so that it doesn't happen again in the future.
Please Log in or Create an account to join the conversation.
- mohairbears
-
Topic Author
- Offline
Less
More
- Posts: 610
- Thank you received: 13
8 months 6 days ago #370680
by mohairbears
Replied by mohairbears on topic Issue with mass select and changing status in the back end
Hi, Sent you backend access to this a couple of days ago and nothing has changed?
I have been in hospital for an op but out now.
Thanks
I have been in hospital for an op but out now.
Thanks
Please Log in or Create an account to join the conversation.
8 months 6 days ago #370681
by nicolas
Replied by nicolas on topic Issue with mass select and changing status in the back end
Hi,
As I tried to explain in my previous message, the problem is not a bug in HikaShop, it comes from a customization on your end.
And I gave you the solution you can apply in order to fix the problem, in my previous message:
As I tried to explain in my previous message, the problem is not a bug in HikaShop, it comes from a customization on your end.
And I gave you the solution you can apply in order to fix the problem, in my previous message:
So, I believe I've done my part on this issue.You can delete the view override for order / listing via the menu Display>Views and it will fix the problem.
Please Log in or Create an account to join the conversation.
- mohairbears
-
Topic Author
- Offline
Less
More
- Posts: 610
- Thank you received: 13
8 months 6 days ago #370684
by mohairbears
Replied by mohairbears on topic Issue with mass select and changing status in the back end
Hi, Yes I can see that if I delete my custom it works, the question is I have been using my edit for years with not issues is there something wrong with the code? it looks correct.
When I delete the - and save it just puts it - back in again??
I do need this edit as its a vital part of our order processing to see the shipping cost without going into every order?
line 159 <!-- MY EDIT -->
<th class="hikashop_order_shipping_title title">
<?php echo JHTML::_('grid.sort', JText::_('HIKASHOP_SHIPPING'), 'b.order_full_price', $this->pageInfo->filter->order->dir, $this->pageInfo->filter->order->value ); ?>
</th>
<!-- END OF EDIT -->
line 366<!--MY EDIT-->
<td class="hikashop_shipping_total_value"<?php echo $attributes; ?>>
<?php echo $this->currencyHelper->format($row->order_shipping_price,$row->order_currency_id);?>
</td>
<!--END OF EDIT-->
thanks
When I delete the - and save it just puts it - back in again??
I do need this edit as its a vital part of our order processing to see the shipping cost without going into every order?
line 159 <!-- MY EDIT -->
<th class="hikashop_order_shipping_title title">
<?php echo JHTML::_('grid.sort', JText::_('HIKASHOP_SHIPPING'), 'b.order_full_price', $this->pageInfo->filter->order->dir, $this->pageInfo->filter->order->value ); ?>
</th>
<!-- END OF EDIT -->
line 366<!--MY EDIT-->
<td class="hikashop_shipping_total_value"<?php echo $attributes; ?>>
<?php echo $this->currencyHelper->format($row->order_shipping_price,$row->order_currency_id);?>
</td>
<!--END OF EDIT-->
thanks
Please Log in or Create an account to join the conversation.
8 months 6 days ago #370686
by nicolas
Replied by nicolas on topic Issue with mass select and changing status in the back end
Hi,
As I said in a previous message, the problem is not with your custom code, it's with a security mechanism in RSFirewall on your website which breaks the code in the view file when it is being saved.
So, if you want to be able to save that change without the listing breaking, you need to check with the RSFirewall support how to configure it so that it doesn't mess with the saving of your modifications. Or you disable that extension temporarily while you do the change.
As I said in a previous message, the problem is not with your custom code, it's with a security mechanism in RSFirewall on your website which breaks the code in the view file when it is being saved.
So, if you want to be able to save that change without the listing breaking, you need to check with the RSFirewall support how to configure it so that it doesn't mess with the saving of your modifications. Or you disable that extension temporarily while you do the change.
Please Log in or Create an account to join the conversation.
- mohairbears
-
Topic Author
- Offline
Less
More
- Posts: 610
- Thank you received: 13
8 months 6 days ago #370691
by mohairbears
Replied by mohairbears on topic Issue with mass select and changing status in the back end
Hi, I have contacted them but no answer yet.
Disabling the plugin does not work so could it be something else doing this?
thanks
Disabling the plugin does not work so could it be something else doing this?
thanks
Please Log in or Create an account to join the conversation.
8 months 5 days ago #370692
by nicolas
Replied by nicolas on topic Issue with mass select and changing status in the back end
Hi,
You probably didn't disable everything that needs to be disabled. Usually, big extensions have several plugins, on top of the component.
If you want, you can circumvent the problem by manually creating the override via Joomla's interface instead of HikaShop's:
guide.joomla.org/user-manual/templates/t...s-template-overrides
You probably didn't disable everything that needs to be disabled. Usually, big extensions have several plugins, on top of the component.
If you want, you can circumvent the problem by manually creating the override via Joomla's interface instead of HikaShop's:
guide.joomla.org/user-manual/templates/t...s-template-overrides
Please Log in or Create an account to join the conversation.
- mohairbears
-
Topic Author
- Offline
Less
More
- Posts: 610
- Thank you received: 13
8 months 5 days ago #370695
by mohairbears
Replied by mohairbears on topic Issue with mass select and changing status in the back end
Hi, They answered and the solution was to put my fixed ip into the safe list.
Thanks
Thanks
The following user(s) said Thank You: nicolas
Please Log in or Create an account to join the conversation.
Time to create page: 0.085 seconds