PayPal Standard Payments does not redirect

Dorgo
Topic Author
Offline

11 years 10 months ago - 11 years 10 months ago #178221 by Dorgo

PayPal Standard Payments does not redirect was created by Dorgo

-- HikaShop version -- : 2.3.4
-- Joomla version -- : 2.5.27
-- PHP version -- : 5.3.29
-- Browser(s) name and version -- : N/A
-- Error-message(debug-mod must be tuned on) -- : Uncaught SyntaxError: Unexpected token

Please wait while you are redirected to PayPal
If you are not redirected after 10 seconds, please click on the button below.

But nothing happens. Even after fixing the obvious javascript error.

FYI, Internet Explorer Conditional Comments go around the script declaration. Not inside.
msdn.microsoft.com/en-au/library/ms537512(v=vs.85).aspx

Code:

	<script type="text/javascript">
		<!--
		document.getElementById('hikashop_paypal_form').submit();
		//-->
		<!--[if IE]>
			document.getElementById('hikashop_paypal_button').style.display = 'none';
			document.getElementById('hikashop_paypal_button_message').innerHTML = '';
		<![endif]-->
	</script>

Should be:

Code:

	<!--[if IE]>
	<script type="text/javascript">
			document.getElementById('hikashop_paypal_button').style.display = 'none';
			document.getElementById('hikashop_paypal_button_message').innerHTML = '';
	</script>
	<![endif]-->

Who is writing this stuff ...?

Last edit: 11 years 10 months ago by Dorgo.

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

11 years 10 months ago #178288 by Jerome

Replied by Jerome on topic PayPal Standard Payments does not redirect

Hi,

Yes, I already fixed it last week (and I slapped the person who commited that).
The current HikaShop 2.3.4 package have this fix.

regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Please Log in or Create an account to join the conversation.

Dorgo
Topic Author
Offline

11 years 10 months ago #178429 by Dorgo

Replied by Dorgo on topic PayPal Standard Payments does not redirect

Jerome wrote: The current HikaShop 2.3.4 package have this fix.

I am running 2.3.4

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

11 years 10 months ago #178431 by Jerome

Replied by Jerome on topic PayPal Standard Payments does not redirect

Hi,

I know that, you wrote it.
But I'm asking you to re-download it because I said that we updated it.
Sorry, it wasn't clear enough in my previous message.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Please Log in or Create an account to join the conversation.

jmbgreen
Offline

11 years 10 months ago #178467 by jmbgreen

Replied by jmbgreen on topic PayPal Standard Payments does not redirect

I arrived here to inform you also about this bug. Glad I see you have this addressed.

Please Log in or Create an account to join the conversation.

Dorgo
Topic Author
Offline

11 years 10 months ago - 11 years 10 months ago #178490 by Dorgo

Replied by Dorgo on topic PayPal Standard Payments does not redirect

Jerome wrote: I know that, you wrote it.
But I'm asking you to re-download it because I said that we updated it.
Sorry, it wasn't clear enough in my previous message.
Regards,

You are joking right? You have released multiple versions with the same version number ?! :sick:

When you update something you need to change the version number. Otherwise there is no point having a version number.

Since you are clearly new to software development, you might want to have a read of en.wikipedia.org/wiki/Software_versioning

Software versioning is the process of assigning either unique version names or unique version numbers to unique states of computer software

Last edit: 11 years 10 months ago by Dorgo.

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

11 years 10 months ago #178496 by Jerome

Replied by Jerome on topic PayPal Standard Payments does not redirect

Hi,

I'm not joking.
Before we put the version as stable (activation of the automatic updates) ; we can update the package.
When there is no more blocking issue with the release, we put the package as stable, activate the automatic updates and we do not make more hot fixes.

The paypal issue as been fixed 2 days after the first release ; two weeks before the automatic update.

For the rest, you can see with Nicolas

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Please Log in or Create an account to join the conversation.

Dorgo
Topic Author
Offline

11 years 10 months ago - 11 years 10 months ago #178500 by Dorgo

Replied by Dorgo on topic PayPal Standard Payments does not redirect

You have the latest stable version of HikaShop Business: 2.3.4

... but apparently not, as there was a new 2.3.4 released today.

com_hikashop_business_v2.3.4_2014-11-06_12-12-44.tar.gz
com_hikashop_business_v2.3.4_2014-10-28_05-28-42.tar.gz

Here is a list of files that were changed (not counting the .xml files that were updated to show yesterday's date)

Code:

administrator/components/com_hikashop/classes/address.php
administrator/components/com_hikashop/classes/discount.php
administrator/components/com_hikashop/classes/field.php
administrator/components/com_hikashop/classes/filter.php
administrator/components/com_hikashop/classes/mail.php
administrator/components/com_hikashop/classes/order.php
administrator/components/com_hikashop/classes/shipping.php
administrator/components/com_hikashop/extensions/plg_hikashop_group/group.php
administrator/components/com_hikashop/extensions/plg_hikashop_userpoints/userpoints.php
administrator/components/com_hikashop/extensions/plg_hikashoppayment_authorize/authorize.php
administrator/components/com_hikashop/extensions/plg_hikashoppayment_paypal/paypal_end.php
administrator/components/com_hikashop/extensions/plg_hikashoppayment_paypalexpress/paypalexpress.php
administrator/components/com_hikashop/extensions/plg_hikashoppayment_sagepay/sagepay.php
administrator/components/com_hikashop/extensions/plg_hikashoppayment_sofort/sofort.php
administrator/components/com_hikashop/extensions/plg_hikashoppayment_webmoney/webmoney.php
administrator/components/com_hikashop/extensions/plg_system_hikashopregistrationredirect/hikashopregistrationredirect.php
administrator/components/com_hikashop/helpers/helper.php
administrator/components/com_hikashop/helpers/importvm.php
administrator/components/com_hikashop/helpers/pagination.php
administrator/components/com_hikashop/helpers/update.php
administrator/components/com_hikashop/views/badge/tmpl/form.php
administrator/components/com_hikashop/views/config/tmpl/main.php
administrator/components/com_hikashop/views/modules/tmpl/form.php
components/com_hikashop/controllers/checkout.php
components/com_hikashop/views/category/tmpl/listing_list.php
components/com_hikashop/views/order/tmpl/show.php
components/com_hikashop/views/order/view.html.php
language/en-GB/en-GB.com_hikashop.ini
media/com_hikashop/css/otree.css

Nothing in the changelog , but language/en-GB/en-GB.com_hikashop.ini contains

Code:

;since 2.3.5
PAYMENT_CAPTURE_ORDER_STATUS="Payment capture order status"

Last edit: 11 years 10 months ago by Dorgo.

Please Log in or Create an account to join the conversation.

nicolas
Offline

11 years 10 months ago #178502 by nicolas

Replied by nicolas on topic PayPal Standard Payments does not redirect

Hi,

The date on the package is the date of the day you do the download. It has nothing to do with the version. You can find the build number in the advanced parameters of the HikaShop configuration. That number will change each time we generate a hotfix package after the release.

Please Log in or Create an account to join the conversation.

Dorgo
Topic Author
Offline

11 years 10 months ago - 11 years 10 months ago #181041 by Dorgo

Replied by Dorgo on topic PayPal Standard Payments does not redirect

Are you sure your update mechanism is working correctly?

Three times now I have checked and hikashop cheerfully reports:

You have the latest stable version of HikaShop Business: 2.3.4

.... but I find there is a different version of 2.3.4 published.

Compare the three versions of 'version' 2.3.4 attached.

Last edit: 11 years 10 months ago by Jerome.

Please Log in or Create an account to join the conversation.

Dorgo
Topic Author
Offline

11 years 10 months ago #181042 by Dorgo

Replied by Dorgo on topic PayPal Standard Payments does not redirect

Also, despite the MSDN article, the conditional tags only work when inside the script declaration.

Please, test yourself before changing, but only the following works for me:

Code:

	<script type="text/javascript">
		<!--[if IE]>
		document.getElementById('hikashop_paypal_button').style.display = 'none';
		document.getElementById('hikashop_paypal_button_message').innerHTML = '';
		<![endif]-->
	</script>
	<script type="text/javascript">
		<!--
		document.getElementById('hikashop_paypal_form').submit();
		//-->
	</script>

Please Log in or Create an account to join the conversation.

Xavier
Offline

11 years 10 months ago #181144 by Xavier

Replied by Xavier on topic PayPal Standard Payments does not redirect

Hi,

First of all, please don't attach archive of our component on the forum: This is a violation of our copyright !

Then, you have to download again the latest version from our website and install it over your current install.
It is still the 2.3.4 but with some corrections like the one you need.

The code to use is:

Code:

	<script type="text/javascript">
		<!--
		document.getElementById('hikashop_paypal_form').submit();
		//-->
	</script>
	<!--[if IE]>
	<script type="text/javascript">
			document.getElementById('hikashop_paypal_button').style.display = 'none';
			document.getElementById('hikashop_paypal_button_message').innerHTML = '';
	</script>
	<![endif]-->

Please Log in or Create an account to join the conversation.

Dorgo
Topic Author
Offline

11 years 10 months ago - 11 years 10 months ago #181203 by Dorgo

Replied by Dorgo on topic PayPal Standard Payments does not redirect

Xavier wrote: First of all, please don't attach archive of our component on the forum: This is a violation of our copyright !

Sorry about uploading the archive. It was not intentional.

Xavier wrote: Then, you have to download again the latest version from our website and install it over your current install.
It is still the 2.3.4 but with some corrections like the one you need.

So, to get this straight:

You release 2.3.4 (version ?)
A notice is displayed in hikashop for users on 2.3.3
they upgrade to whichever version of 2.3.4 you currently have published
You release another 2.3.4
You release another 2.3.4
Customers don't receive an update notification, because it's published as the same version

So what is your recommendation for keeping the component up to date? Should I schedule to download the latest version of the latest version each week and compare with the previous version?

Do you publish a changelog for the patch versions of your released versions?

I highly recommend adopting semver.org/ as a solution to this problem.

Last edit: 11 years 10 months ago by Dorgo.

Please Log in or Create an account to join the conversation.

Dorgo
Topic Author
Offline

11 years 10 months ago #181204 by Dorgo

Replied by Dorgo on topic PayPal Standard Payments does not redirect

Xavier wrote: Hi,
The code to use is:

Code:

<script type="text/javascript">  </script>

Well this does not work in my testing on IE8.
The button is still visible and the redirect does not trigger.

Please Log in or Create an account to join the conversation.

Xavier
Offline

11 years 10 months ago #181335 by Xavier

Replied by Xavier on topic PayPal Standard Payments does not redirect

Hi,

If this code is not working so I think that you have a javascript error on your website.
And because of this error the other scripts are not executed correctly, so the button is not hidden.

Please check that thanks to your browser console.

Please Log in or Create an account to join the conversation.

mdaelectronics
Offline

11 years 9 months ago #183388 by mdaelectronics

Replied by mdaelectronics on topic PayPal Standard Payments does not redirect

Hi Guys,

If i wanted to add the code manually which file am i editing?

public_html/components/com_hikashop/controllers/checkout.php ?

Please Log in or Create an account to join the conversation.

nicolas
Offline

11 years 9 months ago #183390 by nicolas

Replied by nicolas on topic PayPal Standard Payments does not redirect

Hi,

It's the plugins/hikashoppayment/paypal/paypal_end.php

Please Log in or Create an account to join the conversation.

Time to create page: 0.297 seconds