- Posts: 34
- Thank you received: 1
Product Listing layout margin bug
13 years 1 month ago - 13 years 1 month ago #117169
by ximbo
Product Listing layout margin bug was created by ximbo
--website
audleymotors.smsidat.com/accessories
(shows correctly now with the modification detailed below)
-- HikaShop version -- : 2.2
-- Joomla version -- : 3.1
-- PHP version -- : 5.3
Not sure if this is a bug, but the second row on the product listing view can't fit the same number of items as the first due to the margin on the first item, so I had to add the following to the front end CSS:
Note that this already exists for the row-fluid class:
However the div on the product listing page uses the row-fluid-10 variant.
Could you confirm if this is a bug or something I'm doing wrong somewhere! Thanks
- Another thing I forgot to mention was that if the titles/description are a bit longer and so the item is larger in height compared to the other products, it pushes the product on the row below down a row.. hope this is making sense. I'd expect it to rather just push the entire row below a little further down to give it minimum margin space between the longest item on top and the items below.
Just fixed this by adding clear:both to the css, alternatively could have given the <li> an explicit height
Is this all correct? Seems to work anyway
-- HikaShop version -- : 2.2
-- Joomla version -- : 3.1
-- PHP version -- : 5.3
Not sure if this is a bug, but the second row on the product listing view can't fit the same number of items as the first due to the margin on the first item, so I had to add the following to the front end CSS:
Code:
.row-fluid-10 .hikashop_product_column_1, .row-fluid-10 .hikashop_category_column_1 {
margin-left: 0 !important;
}
Note that this already exists for the row-fluid class:
Code:
.row-fluid .hikashop_product_column_1, .row-fluid .hikashop_category_column_1 {
margin-left: 0 !important;
}
However the div on the product listing page uses the row-fluid-10 variant.
Could you confirm if this is a bug or something I'm doing wrong somewhere! Thanks
- Another thing I forgot to mention was that if the titles/description are a bit longer and so the item is larger in height compared to the other products, it pushes the product on the row below down a row.. hope this is making sense. I'd expect it to rather just push the entire row below a little further down to give it minimum margin space between the longest item on top and the items below.
Just fixed this by adding clear:both to the css, alternatively could have given the <li> an explicit height
Code:
.row-fluid-10 .hikashop_product_column_1, .row-fluid-10 .hikashop_category_column_1 {
margin-left: 0 !important;
clear:both
}
Is this all correct? Seems to work anyway
Last edit: 13 years 1 month ago by ximbo.
Please Log in or Create an account to join the conversation.
13 years 1 month ago #117190
by Jerome
Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.
Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.
Replied by Jerome on topic Product Listing layout margin bug
Hi,
You did quite well.
We will add the margin-left for the other "row-fluid" like you did. About the clear I will test this improvement on other sites but it looks to work perfectly on your website.
Thanks !
You did quite well.
We will add the margin-left for the other "row-fluid" like you did. About the clear I will test this improvement on other sites but it looks to work perfectly on your website.
Thanks !
Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.
Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.
Please Log in or Create an account to join the conversation.
13 years 1 month ago #117204
by ximbo
Replied by ximbo on topic Product Listing layout margin bug
Sure, I added clear:both on both row types, all seems to work fine now.
Please Log in or Create an account to join the conversation.
Time to create page: 0.147 seconds