- Posts: 7
- Thank you received: 1
Hikashop user plugin form view is not well formed
12 years 8 months ago - 12 years 8 months ago #140086
by ropreoso
Hikashop user plugin form view is not well formed was created by ropreoso
-- url of the page with the problem -- :
www.sator.cz
(Not accessible for public yet.)
-- HikaShop version -- : 2.2.3
-- Joomla version -- : 2.5.11
-- PHP version -- : 5.2.9
-- Browser(s) name and version -- : Google Chrome 30.0.1599.101 m
-- Error-message(debug-mod must be tuned on) -- : N/A
Here is source code of plugins/system/hikashopuser/hikashopuser.php starting on line 225 with highlighted bug. <dl> is not well formed. Depending on HIKASHOP_J30 only begin part of tag or end part of tag is generated.
if(HIKASHOP_J30){
$data .= '<fieldset class="hikashop_user_edit"><legend>'.JText::_('HIKASHOP_USER_DETAILS').'</legend><dl>';
}else{
$data .= '<fieldset class="hikashop_user_edit"><legend>'.JText::_('HIKASHOP_USER_DETAILS').'</legend>';
}
foreach($extraFields as $fieldName => $oneExtraField) {
if(HIKASHOP_J30){
$data .= '<div class="control-group"><div class="control-label"><label>'.$fieldsClass->getFieldName($oneExtraField).'</label></div><div class="controls">';
}else{
$data .= '<dt><label>'.$fieldsClass->getFieldName($oneExtraField).'</label></dt><dd>';
}
$onWhat='onchange';
if($oneExtraField->field_type=='radio')
$onWhat='onclick';
$data .= $fieldsClass->display($oneExtraField,@$user->$fieldName,'data[user]',false,' '.$onWhat.'="hikashopToggleFields(this.value,\''.$fieldName.'\',\'user\',0);"');
if(HIKASHOP_J30){
$data .= '</div></div>';
}else{
$data .= '</dd>';
}
}
if(HIKASHOP_J30){
$data .= '</fieldset>';
}else{
$data .= '</dl></fieldset>';
}
-- HikaShop version -- : 2.2.3
-- Joomla version -- : 2.5.11
-- PHP version -- : 5.2.9
-- Browser(s) name and version -- : Google Chrome 30.0.1599.101 m
-- Error-message(debug-mod must be tuned on) -- : N/A
Here is source code of plugins/system/hikashopuser/hikashopuser.php starting on line 225 with highlighted bug. <dl> is not well formed. Depending on HIKASHOP_J30 only begin part of tag or end part of tag is generated.
if(HIKASHOP_J30){
$data .= '<fieldset class="hikashop_user_edit"><legend>'.JText::_('HIKASHOP_USER_DETAILS').'</legend><dl>';
}else{
$data .= '<fieldset class="hikashop_user_edit"><legend>'.JText::_('HIKASHOP_USER_DETAILS').'</legend>';
}
foreach($extraFields as $fieldName => $oneExtraField) {
if(HIKASHOP_J30){
$data .= '<div class="control-group"><div class="control-label"><label>'.$fieldsClass->getFieldName($oneExtraField).'</label></div><div class="controls">';
}else{
$data .= '<dt><label>'.$fieldsClass->getFieldName($oneExtraField).'</label></dt><dd>';
}
$onWhat='onchange';
if($oneExtraField->field_type=='radio')
$onWhat='onclick';
$data .= $fieldsClass->display($oneExtraField,@$user->$fieldName,'data[user]',false,' '.$onWhat.'="hikashopToggleFields(this.value,\''.$fieldName.'\',\'user\',0);"');
if(HIKASHOP_J30){
$data .= '</div></div>';
}else{
$data .= '</dd>';
}
}
if(HIKASHOP_J30){
$data .= '</fieldset>';
}else{
$data .= '</dl></fieldset>';
}
Last edit: 12 years 8 months ago by ropreoso.
Please Log in or Create an account to join the conversation.
12 years 8 months ago #140146
by nicolas
Replied by nicolas on topic Hikashop user plugin form view is not well formed
Thanks for the report !
We'll add that fix in next version of HikaShop.
We'll add that fix in next version of HikaShop.
Please Log in or Create an account to join the conversation.
Time to create page: 0.185 seconds