Missing error message on not valid VAT

-- HikaShop version -- : 5.0.3
-- Joomla version -- : 4.4.4
-- PHP version -- : 8.2
-- Browser(s) name and version -- : any

Hi,

when saving in backend the billing address with VAT filled and the check is not valid, Hika does not show any error and just cancels saving. We have only format VAT check enabled.

Thanks,

Jan

Hello,

Please provide us your Address custom field configuration via a screenshot in order to allow us to try to reproduce your current issue.
You can active the Joomla Debug (in maximum level) in order to see if that provide any clues around your issue, and if yes provide a screenshot well to show us error message.
Regards

Hi,

thanks for the answer - it is the field address_vat - I am attaching the custom field details.

But I tried to find more details and found that response on saving the address is this:

So it shows the error and then goes back so the error is gone. I found it in /administrator/com_hikashop/controllers/user.php - method saveaddress().

Is there some special reason for this behavior?

Thanks, Jan

Hello,

Unfortunately this will not be enough to allow us to understand what is not working.
Can you complete it with these elements:
- An Url link to your backend (administrator)
- Backend user references (with maximum Acl)
- Your VAT number in order to be sure that we reproduce your issue.

Note : Use our Contact us form to provide these elements, and don't forget to add an Url link to this topic.
Regards

Hi,

I don't think you need backend access - it is production system and so I cannot allow anyone to enter it as admin. But I can show you precisely what I meen.

• We use only VAT format check (Configuration - Main - VAT number check - Format check)
• Editing customer in backend - billing or shipping address, it does not matter
• I make some change to address (eg name or street) and at the same time I fill in the wrong VAT, that doesn't pass the format check (eg XXX)
• The process finishes without any visible error but the changes are not saved

The reason is that the user controller (/administrator/com_hikashop/controllers/user.php) in saveaddress method returns javascript "javascript: history.go(-1);" and so the error "The VAT number you entered is not valid" shows only for split of second and then disappears.

Similar behaviour is also when editing customer address on order. I submits without any visible error but does not save the changes.

So please just try to show an error when saving not correctly formatted VAT. This is not urgent just for some future realease.

Thanks, Jan

Hi,

Thank you for your feedback. I see what you mean.
We'll look at improving this.

Hi, are there any news on this? I tested on latest 6.1.1 and it seems the same

Hi,

This was added to HikaShop 5.1.1 almost 1 year ago with the changelog entry:

We've improved the address saving in the user edit form of the HikaShop backend so that it properly display error messages when necessary

www.hikashop.com/support/documentation/5...ashop-changelog.html
The code change removes the history.go(-1); in the file back/controllers/user.php
i.imgur.com/pqgPzKE.png
I personally did this patch and tested it. After the change I was not able to reproduce the issue anymore and properly got an error message in the popup.
Could you please double check ?

Hi,

you are right, it is repaired on customer edit. But the same bug is on the order edit page when editing billing or shipping address. No error shown on incorrect VAT entry and not saving the other changed data without any message.

Thanks, Jan

Hi,

Thanks for reporting this. I had missed your mention of that other problem in your previous message.
We'll be adding a patch for this with the next version of HikaShop.