- Posts: 200
- Thank you received: 75
Error notices when using cursor filter
10 years 1 month ago #248195
by GW
Error notices when using cursor filter was created by GW
-- HikaShop version -- : 2.6.3
-- Joomla version -- : 3.6.2
Hi,
when using a cursor filter for anything else than the price we get several error notices, see attached screenshot.
In the filter.php file, we can see on line 2039 the currency variables are only defined if($filter->filter_data=='price')
However, on line 2066 and line 2081 the variables $currencies and $crurency_id are assumed to always exist. If we're not mistaken, this can be fixed by checking the filter_data again first by changing line 2066 and 2081 from
to
Hopefully this can be fixed with the next release, thanks!
Kind regards,
-- Joomla version -- : 3.6.2
Hi,
when using a cursor filter for anything else than the price we get several error notices, see attached screenshot.
In the filter.php file, we can see on line 2039 the currency variables are only defined if($filter->filter_data=='price')
However, on line 2066 and line 2081 the variables $currencies and $crurency_id are assumed to always exist. If we're not mistaken, this can be fixed by checking the filter_data again first by changing line 2066 and 2081 from
Code:
if($currencies[$crurency_id]->currency_locale['p_cs_precedes']){
to
Code:
if($filter->filter_data=='price' && $currencies[$crurency_id]->currency_locale['p_cs_precedes']){
Hopefully this can be fixed with the next release, thanks!
Kind regards,
Please Log in or Create an account to join the conversation.
10 years 1 month ago #248201
by Jerome
Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.
Replied by Jerome on topic Error notices when using cursor filter
Hi,
Thanks for the report ; we will fix that issue in the next release.
Regards,
Thanks for the report ; we will fix that issue in the next release.
Regards,
Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.
Please Log in or Create an account to join the conversation.
9 years 7 months ago #262783
by GW
Replied by GW on topic Error notices when using cursor filter
Hi,
the error we mentioned in our first post months ago appears again in Hikashop 3 [1702171813] when having a cursor filter applied on anything other than the price:
Because $currency_id is defined on line 2069 only if($filter->filter_data == 'price').
Hopefully this can be fixed again, thanks!
the error we mentioned in our first post months ago appears again in Hikashop 3 [1702171813] when having a cursor filter applied on anything other than the price:
Code:
Notice: Undefined variable: currency_id in \administrator\components\com_hikashop\classes\filter.php on line 2094
Notice: Undefined variable: currency_id in \administrator\components\com_hikashop\classes\filter.php on line 2109
Because $currency_id is defined on line 2069 only if($filter->filter_data == 'price').
Hopefully this can be fixed again, thanks!
Please Log in or Create an account to join the conversation.
9 years 7 months ago #262804
by nicolas
Replied by nicolas on topic Error notices when using cursor filter
Hi,
Thank you for your feedback. It's actually a new message but yes, the cause is pretty similar. I've added a patch on our end in order to fix that.
Thank you for your feedback. It's actually a new message but yes, the cause is pretty similar. I've added a patch on our end in order to fix that.
Please Log in or Create an account to join the conversation.
Time to create page: 0.143 seconds