Paypal_end amount order_numer

erickb
Topic Author
Offline

12 years 11 months ago #128622 by erickb

Paypal_end amount order_numer was created by erickb

-- HikaShop version -- : 222
-- Joomla version -- : 2514

dans paypal_end je ne recupere pas le total ni le numero de commande avec :

$currencyClass = hikashop_get('class.currency');
$amount = $currencyClass->format($order->order_full_price,$order->order_currency_id);
$order_number = $order->order_number;

comment les recuperer ?
merci

Please Log in or Create an account to join the conversation.

nicolas
Offline

12 years 11 months ago - 12 years 9 months ago #128687 by nicolas

Replied by nicolas on topic Paypal_end amount order_numer

Depuis la version 2.2.0, $order n'est plus disponible
Il faut donc faire comme cela:

Code:

$currencyClass = hikashop_get('class.currency');
$orderClass = hikashop_get('class.order');
$order = $orderClass->get($this->vars['invoice']);
$amount = $currencyClass->format($order->order_full_price,$order->order_currency_id);
$order_number = $order->order_number;

Last edit: 12 years 9 months ago by Jerome.

Please Log in or Create an account to join the conversation.

erickb
Topic Author
Offline

12 years 11 months ago - 12 years 11 months ago #128689 by erickb

Replied by erickb on topic Paypal_end amount order_numer

merci mais je vais essayer sinon $this->order_number,$this->amount ne marchent pas directement ?

Last edit: 12 years 11 months ago by erickb.

Please Log in or Create an account to join the conversation.

nicolas
Offline

12 years 11 months ago #128703 by nicolas

Replied by nicolas on topic Paypal_end amount order_numer

pas que je sache non.

Please Log in or Create an account to join the conversation.

erickb
Topic Author
Offline

12 years 11 months ago #128716 by erickb

Replied by erickb on topic Paypal_end amount order_numer

ok merci

Please Log in or Create an account to join the conversation.

erickb
Topic Author
Offline

12 years 9 months ago #134899 by erickb

Replied by erickb on topic Paypal_end amount order_numer

Je reviens sur cette question car je ne récupère rien avec

$currencyClass = hikashop_get('class.currency');
$orderClass = hikashop_get('class.order');
$order = $orderClass->get($this->vars);
$amount = $currencyClass->format($order->order_full_price,$order->order_currency_id);
$order_number = $order->order_number;

les 2 variables $amount et $order_number sont vides alors que $this->payment_name retourne sa valeur
$this->order_number et $this->amount sont vides aussi alors que dans toutes les autres méthodes de paiement ça marche

pourquoi est ce different avec paypal et que faut il faire pour avoir ces valeurs ?

merci

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

12 years 9 months ago - 12 years 9 months ago #135074 by Jerome

Replied by Jerome on topic Paypal_end amount order_numer

Bonjour,

Voilà pourquoi il est important d'utiliser la balise "code".
Car un : $order = $orderClass->get($this->vars);
va se lire correctement avec la balise ajoutée:

Code:

$order = $orderClass->get($this->vars['invoice']);

.
La magie des BBcode !

Avec une petite analyse du nom de la variable "vars", on peut en déduire rapidement qu'il s'agit d'un tableau et non d'un numéro de commande. Nous sommes assez stricte sur les nom des variable que nous utilisons afin qu'ils soient le plus compréhensible possible à la lecture et à l'écriture.

Cordialement,

PS: Vous pouvez essayer de "quote" mon message pour voir que le "invoice" est bien dans mon example sans les balises de code.

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Last edit: 12 years 9 months ago by Jerome.

Please Log in or Create an account to join the conversation.

erickb
Topic Author
Offline

12 years 9 months ago #135079 by erickb

Replied by erickb on topic Paypal_end amount order_numer

je veux bien mais ca n'explique toujours pas pourquoi dans les autres payments_end on attrapes tout directement avec
$this->order_number
$this->amount

sinon oui ca marche mais un code egal partout serait preferable

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

12 years 9 months ago #135101 by Jerome

Replied by Jerome on topic Paypal_end amount order_numer

erickb wrote: je veux bien mais ca n'explique toujours pas pourquoi dans les autres payments_end on attrapes tout directement avec
$this->order_number
$this->amount

Quels autres ?!
Je suis désolé Erick mais je ne vois pas de quels autres tu parle, nous avons dans les 60 plugins de paiement ; j'en ai fait une bonne moitié et je n'ai jamais passé "order_numer" ou "amount" en référence au plugin.

Cordialement,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Please Log in or Create an account to join the conversation.

erickb
Topic Author
Offline

12 years 9 months ago #135103 by erickb

Replied by erickb on topic Paypal_end amount order_numer

voila le code original de plugins/hikashoppayment/banktransfer/banktransfer_end.php
je lis bien $this->order_number, $this->amount

Code:

<?php
/**
 * @package	HikaShop for Joomla!
 * @version	2.2.2
 * @author	hikashop.com
 * @copyright	(C) 2010-2013 HIKARI SOFTWARE. All rights reserved.
 * @license	GNU/GPLv3 http://www.gnu.org/licenses/gpl-3.0.html
 */
defined('_JEXEC') or die('Restricted access');
?><div class="hikashop_banktransfer_end" id="hikashop_banktransfer_end">
	<span class="hikashop_banktransfer_end_message" id="hikashop_banktransfer_end_message">
		<?php echo JText::_('ORDER_IS_COMPLETE').'<br/>'.
		JText::sprintf('PLEASE_TRANSFERT_MONEY',$this->amount).'<br/>'.
		$this->information.'<br/>'.
		JText::sprintf('INCLUDE_ORDER_NUMBER_TO_TRANSFER',$this->order_number).'<br/>'.
		JText::_('THANK_YOU_FOR_PURCHASE');?>
	</span>
</div>
<?php
if(!empty($this->return_url)){
	$doc = JFactory::getDocument();
	$doc->addScriptDeclaration("window.addEvent('domready', function() {window.location='".$this->return_url."'});");
}

Please Log in or Create an account to join the conversation.

erickb
Topic Author
Offline

12 years 9 months ago #135104 by erickb

Replied by erickb on topic Paypal_end amount order_numer

pareil pour check_end.php

Code:

<?php
/**
 * @package	HikaShop for Joomla!
 * @version	2.2.2
 * @author	hikashop.com
 * @copyright	(C) 2010-2013 HIKARI SOFTWARE. All rights reserved.
 * @license	GNU/GPLv3 http://www.gnu.org/licenses/gpl-3.0.html
 */
defined('_JEXEC') or die('Restricted access');
?><div class="hikashop_check_end" id="hikashop_check_end">
	<span class="hikashop_check_end_message" id="hikashop_check_end_message">
		<?php
		echo JText::_('ORDER_IS_COMPLETE').'<br/>'.
		JText::sprintf('PLEASE_SEND_CHECK',$this->amount).'<br/>'.
		$this->information.'<br/>'.
		JText::sprintf('INCLUDE_ORDER_NUMBER_TO_CHECK',$this->order_number).'<br/>'.
		JText::_('THANK_YOU_FOR_PURCHASE');?>
	</span>
</div>
<?php
if(!empty($this->payment_params->return_url)){
	$doc = JFactory::getDocument();
	$doc->addScriptDeclaration("window.addEvent('domready', function() {window.location='".$this->payment_params->return_url."'});");
}

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

12 years 9 months ago #135110 by Jerome

Replied by Jerome on topic Paypal_end amount order_numer

Bonjour,

Ces deux plugins ne sont pas réellement des plugins de paiement (dans le sens ou il n'y a pas de plateform de paiement).
Ils ont un besoin spécifique dans le end d'afficher le montant et la référence car il faut faire un paiement manuel.
C'est donc un ajout spécifique.

Cordialement,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Please Log in or Create an account to join the conversation.

erickb
Topic Author
Offline

12 years 9 months ago #135111 by erickb

Replied by erickb on topic Paypal_end amount order_numer

ok mais l'ideal que tout soit rigoureusement pareil dans le code et dans n'importe quel paiement_end on a besoin de montrer le numero de commande et le montant
ce serait un plus d'avoir ca par defaut

merci

Please Log in or Create an account to join the conversation.

Jerome
Offline
HikaShop core developer

12 years 9 months ago #135113 by Jerome

Replied by Jerome on topic Paypal_end amount order_numer

Bonjour,

L'idée est déjà notée

Cordialement,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Please Log in or Create an account to join the conversation.

erickb
Topic Author
Offline

12 years 9 months ago #135114 by erickb

Replied by erickb on topic Paypal_end amount order_numer

Please Log in or Create an account to join the conversation.

Time to create page: 0.314 seconds