New products not marked for approval

  • Posts: 306
  • Thank you received: 42
  • Hikamarket Multivendor Hikashop Business
7 years 11 months ago #238347

-- HikaShop version -- : 2.6.2
-- HikaMarket version -- : 1.6.7
-- Joomla version -- : 3.5.1
-- PHP version -- : 5.4.29

Hi

When a vendor adds a new product it is not marked for approval. In the database the 'product_type' field contains 'main' but I think it should be 'waiting_approval'.

I have 'Use Product Approvals' set to Yes:



regards
Trevor

Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 26007
  • Thank you received: 4004
  • MODERATOR
7 years 11 months ago #238350

Hi,

Please check the ACL of your vendor ; the setting "use product approvals" is one part of the system.
Because if a vendor have the right "product/approve" ; his products will be directly approved.
(and for users of the main vendor ; it also allow them to approve products of other vendors).

Here code from the HikaMarket product class :

	if($config->get('product_approval', 0) && !hikamarket::acl('product/approve'))
		$product->product_type = 'waiting_approval';

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 306
  • Thank you received: 42
  • Hikamarket Multivendor Hikashop Business
7 years 11 months ago #238390

The vendor has global ACL set:



and in the global ACL, Product Approve is disabled:



I also tried setting the non-global vendor acl settings with the same results.

Another issue that I have just noticed is that the Warehouse setting for the product is not displaying correctly if viewed from the vendor control panel. (I have renamed 'Warehouse' to 'Despatch'):
Back end product edit:



Vendor admin view of the product:



These all look similar to the problem I reported a few days ago: http://www.hikashop.com/forum/19-hikamarket/883556-shipping-methods-not-displayed-on-product-edit-pag.html

Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 26007
  • Thank you received: 4004
  • MODERATOR
7 years 11 months ago #238391

Hi,

Thanks for the screenshots ; I'll try to reproduce your issue in my local website using the same configuration.

I fixed the warehouse namebox with the same fixe which has been added into HikaShop.
That patch will be include in the next release (and I'll update the demo website during the afternoon with the latest dev package).

For the shipping price per product issue ; I gave the patch to Mohamed for the HikaMarket part and he made some modifications in the HikaShop plugin in order to handle the shipping method setting.
I can't reproduce the issue in my local website with the patches and the demo website should be the same because it uses recent packages.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 306
  • Thank you received: 42
  • Hikamarket Multivendor Hikashop Business
7 years 11 months ago #238421

Thanks for the update.

Would you like a login to our site?

regards
Trevor

Last edit: 7 years 11 months ago by trevsmiff.

Please Log in or Create an account to join the conversation.

  • Posts: 26007
  • Thank you received: 4004
  • MODERATOR
7 years 11 months ago #238495

Hi,

I have updated the demo website with latest packages (HikaShop and HikaMarket) ; the best would be to test and reproduce the issue there (so I can analyze all the data and perform some debug).

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 306
  • Thank you received: 42
  • Hikamarket Multivendor Hikashop Business
7 years 11 months ago #238511

Hi

I have tested the problem with the warehouse not being displayed on the vendor's view of the product and can reproduce it on the demo site:

I created a product from the vendor control panel called 'Another product approval test' with a warehouse called 'Warehouse 1'

Product viewed from the back-end admin:



The warehouse is not displayed when the product is viewed from the vendor's control panel:



I also tested the problem with new products not being marked for approval and as far as I can see the problem seems to exist on the demo site but I might not have set the ACL properly!

Best regards
Trevor

Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 26007
  • Thank you received: 4004
  • MODERATOR
7 years 11 months ago #238520

Hi,

Please do not mix the issues in one single post.
We are talking about the product approval here.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 306
  • Thank you received: 42
  • Hikamarket Multivendor Hikashop Business
7 years 11 months ago #238585

OK, but I feel that they are related.

Would you like me to split one off into a new topic?

Please Log in or Create an account to join the conversation.

  • Posts: 26007
  • Thank you received: 4004
  • MODERATOR
7 years 11 months ago #238586

Hi,

That topic is about the product approval ; let's stay on the product approval.
The part of the warehouse namebox is closed. I told you that the patch was made and it has been propagated in the demo website this afternoon (like I wrote yesterday night).

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 306
  • Thank you received: 42
  • Hikamarket Multivendor Hikashop Business
7 years 11 months ago #238600

I have just tested the warehouse problem on the demo site and it appears to be working OK now. Has this fix been applied to the download package?

I will re-test the approval problem again on the demo site.

Trevor

Please Log in or Create an account to join the conversation.

  • Posts: 26007
  • Thank you received: 4004
  • MODERATOR
7 years 11 months ago #238603

Hi,

See : www.hikashop.com/support/documentation/1...arket-changelog.html

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 306
  • Thank you received: 42
  • Hikamarket Multivendor Hikashop Business
7 years 11 months ago #238663

Hi Jerome

I guess you meant http://www.hikashop.com/support/documentation/integrated-documentation/30-hikamarket/global-informations/147-hikamarket-changelog.html

I will be away for all of May and I have agreed with the site owners that we will postpone launch of the site until I return in early June. Perhaps 1.7.0 will be released by then and these issued will be resolved.

Best regards
Trevor

Please Log in or Create an account to join the conversation.

  • Posts: 26007
  • Thank you received: 4004
  • MODERATOR
7 years 11 months ago #238665

Hi,

My link is the right one and is working perfectly.
So I meant what I wrote :)

HikaMarket 1.7.0 has passed the latest tests and should be release during the day.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 306
  • Thank you received: 42
  • Hikamarket Multivendor Hikashop Business
7 years 11 months ago #238666

When I clicked on the link it took me to this page:



Thanks
Trevor

Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 26007
  • Thank you received: 4004
  • MODERATOR
7 years 11 months ago #238668

Hi,

You have to click on the link here ; in the website. Not in the email where the link is truncated with "..."
When I told you that the link is working it's because I used the right and the perfect link that you can find in the documentation and that documentation page hasn't moved and is the same URL since the first day I created it on February 2013.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 306
  • Thank you received: 42
  • Hikamarket Multivendor Hikashop Business
7 years 11 months ago #238674

Thanks Jerome

Really appreciate all the work you are doing.

Trevor

The following user(s) said Thank You: Jerome

Please Log in or Create an account to join the conversation.

  • Posts: 306
  • Thank you received: 42
  • Hikamarket Multivendor Hikashop Business
7 years 11 months ago #238726

Hi Jerome

I have installed 1.7.0 and initial tests indicate that the problems have been fixed :cheer:

I like the new ACL, much easier to understand.

Thank you very much.

Best regards
Trevor

Last edit: 7 years 11 months ago by trevsmiff.

Please Log in or Create an account to join the conversation.

  • Posts: 26007
  • Thank you received: 4004
  • MODERATOR
7 years 11 months ago #238727

Thanks for your feedback :)

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

Moderators: Obsidev
Time to create page: 0.134 seconds
Powered by Kunena Forum