Product Line with both serials and license files.

I'd like to ask about directions for next case

1) we have product line, where some products need SERIAL, and some products need license file (and only file, without any serial).

QUESTION 1: Do we need 2 different plugins? Or this can be done via single plugin?

I am asking because about file - in docs can be found only mention of onBeforeSerialDownloadFile() trigger, and it says: "Download plugins allow you to create unique downloadable files"
But serials are in generator-plugin...


2) Besides trigger depends on $serial parameter

QUESTION 2: Why file should depend on serial? In our case this have no sense.


3) Yes, I have found your own plugin AttachSerial, but it not helps at all -- a lots of own logic hides they main how to work with FILE. I have only learn, that plugin must to save file into own folder and check this in path.

QUESTION 3: If we must save generated files in the folder of plugin, how we cleanup that files if something bad happens? In our pref solution we did generate files into /tmp folder

4) so we have produce Valentina Server. When user buy it, in the email must be attached ZIP file with license file or even set of files. Our code can produce this ZIP ... What happens next?

QUESTION: HikaShop will save this file automatically into DB for this order - product ?
and then in folder of plugin file should be deleted?

Jerome wrote: Hi,
2. HikaSerial is base on the fact that you have a unique content.
If you don't have a serial, you don't have a base to generate a unique file in the way that, if the customer re-download the file, he will receive the same file.
The file is unique depending the "serial", not unique each time he will download it.

Jerome wrote: 3. The plugin "attach serial" is not the best sample for the trigger onBeforeSerialDownloadFile ; even if the code for the function is not really big.
If you follow the fact that a file depend on a serial, you can re-generate the exact same file using the serial.
You can otherwise store the file path in the "extra data" of the serial in order to resend it easily (and put it in a secure folder).

4. HikaShop or HikaSerial does not store any file into DB.
If you plugin generate a file, you have to store that file or generate it dynamically. It will be related to your plugin.
But you can use the HikaShop "secure upload folder" to store your files (like : media/com_hikashop/upload/safe/my_hikaserial_plugin/ )
Regards,

Well, I have read onBeforeSerialDownloadFile() in that AttachSerial plugin ...
and I think I still do not see
HOW I should return file from this function?

public function onBeforeSerialDownloadFile(&$filename, &$do, &$file, &$serials) {

    // Let I have put file into absolute position.
    $pathWhereFile = "/tmp/dummy.zip";        

    What is next?
    - I should assign this into  $file?
    - or RETURN it ?
    - else?
}

Jerome wrote: If you do not need a serial to generate your file, so you do not need HikaSerial and you can just use the HikaShop triggers to generate you file ; like HikaSerial does.
Like I told you, the goal of HikaSerial is to work with serials ; if you're outside of his main goal it means that you might not need it.

Jerome wrote: The HikaSerial trigger "onBeforeSerialDownloadFile" is a special "onBeforeDownloadFile" HikaShop trigger
www.hikashop.com/support/support/documen...onBeforeDownloadFile

So just don't use HikaSerial and use directly HikaShop.

Dear Jerome,

so far we have got working serials for our products. This is very good.
Now I return back to question of license files.
Please forget our discussions before.

TASK IS:
user chose product VSERVER,
he get letter with attached ZIP file, which we can generate from info
"UserName;OS"

On this page of HikaSerial docs
www.hikashop.com/support/documentation/1...e-in-hikaserial.html

is said:

Serial possibilities
With HikaSerial (custom) plugins:
Unique file attachment

So how we can get this functionality?
What are the key moments here even if to look on AttachSerial plugin?
We do not need GUI for options in our plugin as have AttachSerial ...

All I want is, let I have file at $path = /tmp/license.zip
And I want that this file was attached

public function generate(&$pack, &$order, $quantity, &$serials) 
{
     $serial = "RuslanZasukhin;Mac";
     $serials[] = $serial;
}

public function onBeforeSerialDownloadFile(&$filename, &$do, &$file, &$serials) 
{
      $pathWhereFile = "/tmp/license.zip";        
       
      ... how to attach to email?
}

Thank you very much!

I think that finally I have to see all mechanisms and how they work together.
I did add FILE to product, and yes this have start call that trigger, from OrderDetails page on click. GOOD.
I can see trigger call, and var_dump of params. All is in place what I need. GOOD.
And email have similar link (but it little differ) still need to check it also calls trigger.

First of all, I will try to play with ZIP archive ... to make it real download.
Then make working our alga,
Then I will try attach ZIP to email

Again, thank you a lots, Jerome!

Hi Jerome,

Again I need your help and advice.

I try implement call-system as you name it.
- into product I have added file "#hikaserial:valentina:licenses.zip"
- and I was able to see letter with LINK
- then I click it and get trigger onBeforeSerialDownloadFile() called.
- then our code produces correct license file after parsing of our pseudo-serial, I see it on disk

But final step -- return that file to HikaShop so download start -- NOT WORKS

This is simplified a little code of function which I try ...
as you can see in comment, my function returns full path to generated file.
I assign it into $filename. I have try to assign it into $file->file_path also ...

But I still get page "Brand Listing" with message FILE NOT FOUND.

May be problem comes from Mac OS X?
I develop this under Mac OS X and MAMP....
Main site will be on Linux ...

	public function onBeforeSerialDownloadFile( &$filename, &$do, &$file, &$serials ) 
	{
		// We take serial and split it:
		$serial = $serials[0];
		$parts = explode( ";", $serial->serial_data );

		$filename = create_license_for_vserver_free( $parts, $file );

		// now $filename is "/tmp/Ruslan Zasukhin/license_win_4430337204584841"
		
		// Also I have try to add this:
		$file->file_path = $filename;
		$file->file_name = $fileName;  // full path or only file name. Both tested.
	}

Yes, I will add that protection lines on start of function. Just for now I want to get something working.

So it looks I do correct things, with assignment to $filename.
Okay I will check caller code now and may be will add logs there to see var values.

* Is it possible to see code of your small plugin?
I not very see what you mean with send on the fly without disk touch ...
You mean just make memory buffer and pass it to $filename? But they want path here no?

Aha, sending in this way and exit I have see already.
I did think this is to ATTACH file to email letter.
But file, image in AttachSerial, still is generated on disk, right?

I am going try this way also after "download on call" will start to work.
If they both will work -- this can be good.