Feature Request: Generate Serials only for defined shipping methods

Hello,

HikaSerial 6.1.0 introduced new triggers : "onCustomAttachSerialRule" and "onDisplayCustomAttachSerialOptions".

The first trigger allows to add a new custom rule and be able to not attach the serial in an email.
The second one allows the creation of new settings which will be displayed in the plugin config page (the HikaSerial one).

Regards,

Hello,

After my last message, I started to work on an update of the developer documentation page.
www.hikashop.com/support/documentation/1...ncustompdfserialrule

You will find the function definition with the parameters.
Full examples are not yet available for all the existing triggers but it should help you for the start.

Regarding the second trigger, the idea of the trigger (like the other "additional settings"), is to let the plugin display (echo) its HTML content.
The first parameter gives the needed information regarding the "name" of the input.
To understand how you can integrate, best is to take a look at the view itself (where the trigger is called), directly within the plugin folder.

But for your case, you might not need the second trigger ; just the first one could be suffisent if you want to apply the behavior on every orders depending on the shipping method.
The "$params" variable contains the HikaShop order object (directly provided by HikaShop) ; and you should be able to read the information you need to determine if you want to refuse the inclusion of the serial in the email (using the "$do" variable).

Regards,

Hello,

You don't have to modify anything in HikaSerial. There is a need of building something.

As previously explained ; you want a custom feature which need to be provide by a custom plugin.
It means it requires some development to create that plugin.
Custom development and software support are different ; so we can't provide you that custom plugin, but we can provide developer documentation to help you (and IA tools) to understand how to integrate with HikaSerial.

The triggers "onCustomPdfSerialRule" / "onCustomAttachSerialRule" are the triggers you need (depending if you're using PDF Serials or Attach Serials).

For more details regarding the custom plugin creation, there is also a HikaShop documentation page : www.hikashop.com/support/documentation/6...r-documentation.html

Regards,

Hello,

Regarding the HikaSerial plugin (the HikaShop plugin has another goal) ; it could be more straigh forward.
The order shipping ID can be retrieve directly on the order object ; which is already available via "$params->order" in the function "applyRule" ; so with the function "resolveOrderId" you could have another one named "extractShippingId".
So you could remove the function "getOrderShippingIds" since the information should be already available. Having a fallback is interesting but should not be required regarding the current context.
So you could just use the function "isOrderShippingAllowed" since "$params->order" is the object you're looking for.

Cache on "isShippingAllowed" is interesting but will not improve performances since there will be just one "orderId" in the page call context.

Otherwise the trigger "onSerialOrderPreUpdate" seems to not be required.

Regards,

Just forgot!

Otherwise the plugin seems to do the job
As explained, it could be more "direct" but there is no "error" or issue in the plugin!