maybe bug in hikasubscription

Hello,

It's not a bug since you have a limitation system that HIkaSerial can't be aware of.
For HikaSerial rules, the customer do have the right to renew and it proposes the available products to perform renewals.
The fact that a production addition in the cart is refused by another plugin is problematic for your case but is not something which can be known in advance.

Regards

Hi,

That's not easy to add. First it's quite a lot of code to check that the product still match all the limits setup. So a lot of work would be needed for that.
Also, it adds a lot of processing to run the different MySQL queries for each product for each limit to check if it's possible or not to add it to the cart. It's fine to do that when you're using the add to cart button, since you're doing the check for only one product, but on a products listing or a subscriptions listing, it could lead to the page crashing as this process would run for each product.
Plus, if the users would see the add to cart button and use it normally, until one day the button is removed, they would wonder what's going on and think there is a bug. Now, they get the button and when they click on it, they get a proper error message from the limit system telling them why they can't use the button. I think that this way of working is better for the user.

Hi,

So if I understand you correctly, you're saying that when you use an add to cart button on a product with a limit (from the Products>Limits menu of HikaShop) reached on products listing, you get the notification box with the error message from the limit system saying that the product could not be added to the cart because the limit has been reached.
But if you use the "renew" button for a subscription using that same product as a renewal product, you don't get the notification box with the error message.
Did I understand correctly ?
Could you provide a screenshot of the settings of that limit and a screenshot of the product settings please ?