Small error: Add to cart button not in correct HTML position

  • Posts: 200
  • Thank you received: 75
8 years 3 months ago #261351

-- HikaShop version -- : 3.0.0 [1702040056]
-- Joomla version -- : 3.6.5

Hi,

looks like a small error, with add to cart legacy set to No and the product quantity input method set to something different than Default, the add to cart/wishlist buttons do not appear in the correct position in the HTML markup, see also attached image from the demo site.
Before they were always inside the div hikashop_product_quantity_div, but with legacy set to No they appear outside of the div.

EDIT: ah, with the new add to cart system we see the buttons are now generated in the "add_to_cart_ajax" view, so that's why. Still, might we suggest to put the buttons inside a similar div as in legacy mode for consistency and ease of styling?

Kind regards,

Attachments:
Last edit: 8 years 3 months ago by GW.

Please Log in or Create an account to join the conversation.

  • Posts: 83905
  • Thank you received: 13581
  • MODERATOR
8 years 3 months ago #261360

Hi,

It's actually not an error but an improvment. These buttons shouldn't be in the quantity DIV. The quantity div should be for the quantity input. And the buttons should be in their own div, like it is now. That allows for more possibility of customization where you want separate them on the layout. Before that wasn't possible.
This change however requires the CSS of the template to be adapted to that and the template on our demo website isn't.
I actually had to add some custom CSS to the template of the demo website for the default display to look correct by default as this template requires the frontend CSS of HikaShop to be disabled but didn't get any update yet to get the add to cart and quantity elements to display properly thanks to new CSS.
So if it displays bad on your end, you might need to add some CSS but the fact that the HTML is now like that is normal and is how we wanted it to be. That's actually part of why we have a legacy setting so that you can revert to the old way of displaying the quantity/add to cart for your custom views/CSS/template.

The following user(s) said Thank You: GW

Please Log in or Create an account to join the conversation.

Time to create page: 0.067 seconds
Powered by Kunena Forum