Pb with products listing after update to hikashop 4.2 version

  • Posts: 112
  • Thank you received: 8
  • Hikashop Business
4 years 8 months ago #309211

-- HikaShop version -- : 4.2
-- Joomla version -- : 3.9.10
-- PHP version -- : 7.3.5

I updated to 4.2 and the products listing in English (translation with falang) are not showing anymore ??
The page is loading but the listing of the products in English is not showing.
On an other menu (in english) it shows all the categories instead of one only.
There seems to be a pb with menus: the menu titles are "product category" whatever the menu in english is.
what can I do ?
When I revert to version 4.1 everything is working fine
I updated the local site on my computer so I can't show it to you online
Thank you

Attachments:
Last edit: 4 years 8 months ago by sophie11.

Please Log in or Create an account to join the conversation.

  • Posts: 81515
  • Thank you received: 13069
  • MODERATOR
4 years 8 months ago #309216

Hi,

Are you using the latest version of Falang ? If no, I would recommend updating.
Also, try to disable Falang and its system plugins temporarily to see if it's linked to it.
And try to switch to the default template to see if it's linked to view overrides.
Knowing all this will already help better understand the situation.

Please Log in or Create an account to join the conversation.

  • Posts: 112
  • Thank you received: 8
  • Hikashop Business
4 years 8 months ago #309320

Hi Nicolas
thank you for your answer

I use Falang 3.0.0 which is not the latest but a recent version, and it is working fine with Hikashop 4.1
When I disable falang system plugins the English part of the site doesn't work at all as it is the secondary language.
I tried with Protostar and the problem remains: no product listing.

When I get to the English page "women's leather bracelets" the title of the page is "product category" but it should be "women's leather bracelets". It is the same with all the English pages, the titles are wrongand all the same "product category" and no listing products load in the page.

My falang subscrition has just run out and I don't want to renew it right now as I don't have that many English speaking customers.
I contacted Falang regarding my problem but got no answer from them.

Regards
Sophie

Please Log in or Create an account to join the conversation.

  • Posts: 81515
  • Thank you received: 13069
  • MODERATOR
4 years 8 months ago #309339

Hi,

I'm not sure why you would have that problem.

Could you provide a backend and a FTP access to a copy of the website with the issue along with a link to this thread via our contact form so that we can look into it ?
www.hikashop.com/support/contact-us.html

Please Log in or Create an account to join the conversation.

  • Posts: 4510
  • Thank you received: 611
  • MODERATOR
4 years 8 months ago #309480

Hello Sophie11,

I have a look on your website backend and I think I get the root issue, it seems that you don't have Item Menu for en-gb language and so the url link can lead to nothing.
You have to create for each language an Item Menu, see my screenshot to better understand my point :



Hope this will help you to solve your issue.
regards

Last edit: 4 years 8 months ago by Philip.

Please Log in or Create an account to join the conversation.

  • Posts: 112
  • Thank you received: 8
  • Hikashop Business
4 years 8 months ago #309491

Hi
Thank you for your answer but it doesn't solve my pb.
The issue only happens with hikashop 4.2 not 4.1 and the menu items are the same !!
The menu items are translated with falang when you click on the french menu item you can see the translation with falang and it works fine with the site www.fifibirndecuir.fr which is with hikashop 4.1 and the site www.fifibrindecuir.fr/copy115 is with hikashop 4.2 and the English doesn't work on that site
All the menu items are exactly the same the only difference is hikashop version.
So it does come from my hikashop 4.2
Can you, please check it up again

i've had my website up and running for over 2 years in French and English with the same menu items. I've updated hikashop many times and I've never had any problem. Only with this new version 4.2 the English product listings don't load. I haven't changed anything at all so it should be working but it doesn't.
Hope you can help
thank you
Sophie

Last edit: 4 years 8 months ago by sophie11.

Please Log in or Create an account to join the conversation.

  • Posts: 81515
  • Thank you received: 13069
  • MODERATOR
4 years 8 months ago #309561

Hi,

Thank you for the accesses. I was able to investigate the issue.
The line:
$this->params->set('selectparentlisting', $p->selectparentlisting);
was missing after the line:
$p = $menu->params->get('hk_'.$type,false);
in the file components/com_hikashop/views/product/view.html.php
After adding it, it works fine on your copy website.
We'll add the change on our end too.

Please Log in or Create an account to join the conversation.

  • Posts: 112
  • Thank you received: 8
  • Hikashop Business
4 years 8 months ago #309629

Great !
Thank you so much for fixing the issue so quickly

Please Log in or Create an account to join the conversation.

  • Posts: 112
  • Thank you received: 8
  • Hikashop Business
4 years 6 months ago #312042

Hi Nicolas
Just to let you know that I've updated to version 4.2.1and the line $this->params->set('selectparentlisting', $p->selectparentlisting);
is still missing from view.html.php !
Regards

Last edit: 4 years 6 months ago by sophie11.

Please Log in or Create an account to join the conversation.

  • Posts: 81515
  • Thank you received: 13069
  • MODERATOR
4 years 6 months ago #312043

Hi,

I cannot confirm this.
I just checked the latest build of the 4.2.1 release and the line is there:
monosnap.com/file/aF3zxB2GZexlgTJMJ1tnQPWyixcwQN
It's also there in the 4.2.2 that was released last week.

Please Log in or Create an account to join the conversation.

  • Posts: 112
  • Thank you received: 8
  • Hikashop Business
4 years 6 months ago #312221

Hi Nicolas

I've updated my test site with hikashop 4.2.2 and I am sorry to say that the problem with the English listing not displaying is still there !
test site = www.fifibrindecuir.fr/copy115
Women's and Men's bracelets not displaying

I've had a look into the view.html.php and when I delete the following code block

	try {
				if(!empty($menu->params)) {

					$p = $menu->params->get('hk_'.$type,false);

					if(!empty($p->selectparentlisting))
						$this->params->set('selectparentlisting', $p->selectparentlisting);
					if(HIKASHOP_J30)
						$this->params->set('content_synchronize', 1);
					$this->params->set('recently_viewed', 0);
				}
			} catch(Exception $e) {
			}
and replace it with the one from previous version
 $p = $menu->params->get('hk_'.$type,false);
			$this->params->set('selectparentlisting', $p->selectparentlisting);
			if(HIKASHOP_J30)
				$this->params->set('content_synchronize', 1);
			$this->params->set('recently_viewed', 0);
it works fine

Please let me know if you need access to the site
Thanks
Sophie

Last edit: 4 years 6 months ago by nicolas.

Please Log in or Create an account to join the conversation.

  • Posts: 81515
  • Thank you received: 13069
  • MODERATOR
4 years 6 months ago #312225

Hi,

Well, the difference there are only to prevent errors.
Try to use that code instead:

	try {
				if(!empty($menu->params)) {

					$p = $menu->params->get('hk_'.$type,false);

					if(!empty($p->selectparentlisting))
						$this->params->set('selectparentlisting', $p->selectparentlisting);
				}
					if(HIKASHOP_J30)
						$this->params->set('content_synchronize', 1);
					$this->params->set('recently_viewed', 0);
			} catch(Exception $e) {
			}

Please Log in or Create an account to join the conversation.

  • Posts: 112
  • Thank you received: 8
  • Hikashop Business
4 years 6 months ago #312231

I tried your suggestion but it doesn't work

Please Log in or Create an account to join the conversation.

  • Posts: 81515
  • Thank you received: 13069
  • MODERATOR
4 years 6 months ago #312239

Hi,

I used the FTP access you had provided before to check the situation and I had to come up with a more elaborated version to make it work in all the cases:

try {
				if(!empty($menu)) {
					$menuParams = $menu->getParams();
					if(!empty($menuParams)) {
						$p = $menuParams->get('hk_'.$type,false);
						if(!empty($p->selectparentlisting))
							$this->params->set('selectparentlisting', $p->selectparentlisting);
					}
				}
				if(HIKASHOP_J30)
					$this->params->set('content_synchronize', 1);
				$this->params->set('recently_viewed', 0);
			} catch(Exception $e) {

			}
I've added the change for you and it seems good now. We'll add that change on our end too.

Please Log in or Create an account to join the conversation.

  • Posts: 112
  • Thank you received: 8
  • Hikashop Business
4 years 6 months ago #312244

It works fine
Perfect service .... as usual !
Thank you for your time

Please Log in or Create an account to join the conversation.

  • Posts: 81515
  • Thank you received: 13069
  • MODERATOR
4 years 6 months ago #312245

Thanks !
If you didn't do it yet, don't hesitate to post a comment on the JED and spread the love, it helps a lot :)
extensions.joomla.org/extensions/extensi...opping-cart/hikashop

Please Log in or Create an account to join the conversation.

Time to create page: 0.079 seconds
Powered by Kunena Forum