Pagination not correct after changing limit

-- HikaShop version -- : 4.2.2
-- Joomla version -- : 3.9.15

Hi,

we noticed when changing the number of products displayed in a listing, the pagination buttons do not seem to be correct when you are on a different page than the first page.

You can also see this on the Hikashop Demo website by following these steps:
1. In the backend, we created some more products to have a few more pages of products.
2. On the frontend go to Products Listing -> Display in List
3. Eight products are displayed. Go to a next page, e.g. page 2.
4. Now change the number of products displayed from 8 to e.g. 16
5. The webpage will display 16 products and move back to page nr. 1
However, all links to the other pages are now incorrect.

If you check the links, they are all limitstart=8 while it should be limitstart=16, limitstart=32, limitstart=48, etc.
This goes wrong every time a user is on any page > 1 and changes the limit.
We hope this can be fixed asap.
Thanks.

Hi,

hmm, we updated to the latest install package 4.2.2 [2002031612] and got rid of any overrides, but still doesn't appear to be working, we don't see any change.

Did you test by following our steps in the first post?
If you go to any page other than the first page and change the nr. of products displayed, then all the pagination buttons are wrong and they're all identical with the same "limitstart".

Thanks for looking into it.

Hello,

I wasn't able to reproduce it on my end. Can you send us a temporary back-end access to your website so that we can directly test it ?
You can send it using our contact form, by specifying a link to that thread in your message :
www.hikashop.com/support/contact-us.html

Kind regards,
Mohamed Thelji.

Hi,

our live website is not exactly suitable for testing, we'll see if we can set up a separate test-website when we have time.
However, I think you can test on your own Hikashop Demo website because you can also see the exact same thing happening there.

Just follow the steps in our first post on the Demo website and you will see the pagination buttons are not correct after changing the number of products displayed in a listing. That is precisely also what happens on our website.

Hello,

We succeed to reproduce it on our end thanks to your instructions. to fix it you'll just have to edit the file "administrator\components\com_hikashop\helpers\pagination.php" and change that line :

$current_url = str_replace(array('limitstart'.$this->hikaSuffix.'='.$old_start, 'limitstart'.$this->hikaSuffix.'-='.$old_start), array('limitstart'.$this->hikaSuffix.'='.$start, 'limitstart'.$this->hikaSuffix.'-'.$start), $current_url);

$current_url = preg_replace('#limitstart'.$this->hikaSuffix.'(=|-)[0-9]+#','limitstart'.$this->hikaSuffix.'${1}'.$start, $current_url);

Hi,

the above edit has fixed the initial error, however we now notice changing the nr. of products per page and pagination goes wrong when in combination with filters.

Unfortunately the Hikashop Demo website doesn't have filters, but I think it is fairly easy to reproduce:

1. Apply a filter on a product listing, e.g. a color, size, whatever
2. Change the number of products displayed per page, e.g. from 8 to 16
It will display 16 products, but all pagination buttons are now wrong.

We can see this is because as soon as a filter is applied, there is never any "limit" parameter added to the pagination URL's and the browser therefore won't remember the nr. of products displayed. So the "limitstart" is ok, but the "limit" is missing and therefore it will always revert back to displaying 8 products.

Hopefully this can also be fixed, thanks.


EDIT: As an additional note, this only happens with "Redirect POST mode" set to "Yes", but for us it is quite important to keep this set to Yes.
Also, we found this actually doesn't have anything to do with filters, it is just because as soon as the "limitstart=0" is already present in the URL then things go wrong and the "limit" parameter never gets added.

Hello,

EDIT: As an additional note, this only happens with "Redirect POST mode" set to "Yes", but for us it is quite important to keep this set to Yes.
Also, we found this actually doesn't have anything to do with filters, it is just because as soon as the "limitstart=0" is already present in the URL then things go wrong and the "limit" parameter never gets added.

Hello,

After a lot of testing I wasn't able to reproduce it on my end with or without the "redirect POST mode" set to yes.
Can you give us a temporary access to your website back-end and FTP so that we can directly test and debug it on your website ? Thank you.
You can send it using our contact form and by specifying a link to that thread in your message :
www.hikashop.com/support/contact-us.html

Kind regards,
Mohamed.

Hi,

for some reason we didn't receive a notification of your reply and were too busy to check the forum for a while, apologies.
We'd prefer not to have anyone meddling on our live website if that's alright, but we've tried with a clean install of Joomla and Hikashop, and the problem we experience is also there. To see the issue is easy, what we did:

1. Clean install of Joomla
2. Clean install of Hikashop (4.2.3) with example products
3. Go to Configuration -> Advanced and change "Redirect POST mode" to Yes

4. On frontend go to products listing and manually add &limitstart=0 to the URL (to simulate using a filter, since this is also added when using filters)
5. Scroll to bottom of page and change the number of products displayed from e.g. 21 to 42
6. Now try going to the second page

It doesn't work. It will always reset the nr. of products displayed back to 21 and stay on the first page.

This is also what we tried to explain in our previous message. For things to go wrong, you have to have these 3 conditions:
- "Redirect POST mode" set to Yes
- limitstart must be present in url but NOT limit (which happens when applying filters)
- you must change the number of products displayed

Then pagination is all messed up and doesn't work, which for us is quite a big deal since almost all of our visitors make use of filters.
Hopefully this will help to reproduce and fix the issue, thanks.

Hello,

I just tested it with :
- The "Redirect POST mode" option set to Yes
- the "limitstart" parameter present in the url but NOT the "limit" one
- a different number of product displayed

and it worked fine, can you send us information about how you configured the filter you used ?

We'd prefer not to have anyone meddling on our live website if that's alright, but we've tried with a clean install of Joomla and Hikashop, and the problem we experience is also there.

You can check on our website for example here:

Hello,

Thank you for these information, we succeed to reproduce an issue using both filters and the pagination. We'll debug it and fix it as soon as possible and get back to you !

Kind regards,
Mohamed.

Hello,

Can you edit the file "administrator\components\com_hikashop\helpers\pagination.php" and change these lines :

if(isset($_POST['limit'.$this->hikaSuffix]) && isset($_GET['limit'.$this->hikaSuffix])){
	$ret = true;
	$old_limit = (int)$_GET['limit'.$this->hikaSuffix];
	$current_url = preg_replace('#limit'.$this->hikaSuffix.'(=|-)[0-9]+#','limit'.$this->hikaSuffix.'${1}'.$this->limit, $current_url);
}

if(isset($_POST['limit'.$this->hikaSuffix]) && isset($_GET['limit'.$this->hikaSuffix])){
	$ret = true;
	$old_limit = hikaInput::get()->getInt('limit'.$this->hikaSuffix);
	$current_url = preg_replace('#limit'.$this->hikaSuffix.'(=|-)[0-9]+#','limit'.$this->hikaSuffix.'${1}'.$this->limit, $current_url);
}

Hm, that doesn't seem to change anything.

We've added your above patch on our website and you can check it, but your only change is to $old_limit, which isn't used anywhere at all in the pagination.php file and therefore doesn't affect anything, correct? (Just like $old_start a few lines above, they seem to be leftovers from older hikashop versions where they were still used)
Thanks.

Hello,

You're right my bad, I sent you the wrong fix. Can you download the last Hikashop version through our website, install it and test it again ? Thank you.

Kind regards,
Mohamed.

Hi,

thank you, that is an improvement, but still not working in all cases.
If you apply a filter directly after landing on a product listing page, neither $_POST nor $_GET is set, so limit will now be correctly added to the pagination buttons urls. Good!

However, if you apply a filter and then immediately change the nr. of products displayed, the pagination buttons will still be incorrect and limit will not be added. That is because in this case in pagination.php $_GET is not set, but $_POST is, so that $ret_limit = true and the limit parameter will still not be appended to the urls by your added check on line 166, if($ret_start && $ret_limit).

The problem is, if limit is only set in POST, it should still be added to the url for pagination to work correctly. I think this can be solved by changing line 161 from

$ret_limit = true;

if(isset($_GET['limit'.$this->hikaSuffix])) $ret_limit = true;

Hello,

I think it's already what we have in our code and it's working fine :

		if(isset($_POST['limit'.$this->hikaSuffix]) || isset($_GET['limit'.$this->hikaSuffix])){
			$ret_limit = true;

Nono, you're not correct, that is not the same at all and your code is not working fine...

Compare your code

if(isset($_POST['limit'.$this->hikaSuffix]) || isset($_GET['limit'.$this->hikaSuffix])){
	$ret_limit = true;
	......
}
if($ret_start && $ret_limit)
	return $current_url;
elseif($ret_start && !$ret_limit)
	return $current_url . '&limit='.$this->limit;

if(isset($_POST['limit'.$this->hikaSuffix]) || isset($_GET['limit'.$this->hikaSuffix])){
	if(isset($_GET['limit'.$this->hikaSuffix])) $ret_limit = true;
	......
}
if($ret_start && $ret_limit)
	return $current_url;
elseif($ret_start && !$ret_limit)
	return $current_url . '&limit='.$this->limit;

Hello,

and try to spot the difference, what happens if only $_POST[ 'limit' ] is set.
In your code, limit will then not be appended to $current_url, but it needs to be added for pagination to work. In our code it will.