ORDER_END_MESSAGE appearing in emails after 4.6.0 update

  • Posts: 201
  • Thank you received: 18
  • Hikashop Business Hikashop Essential
5 days 7 minutes ago #342642

-- HikaShop version -- : 4.6.0
-- Joomla version -- : 3.10.10
-- PHP version -- : 7.4.30
-- Error-message(debug-mod must be tuned on) -- : None

Minor issue in emails being sent after 4.6.0 update.

ORDER_END_MESSAGE just now appears at the bottom of Order administrator notification emails.

Doesn't appear on customer emails, however.

All the email templates have 4.6.0 so I don't believe I have any overrides in place.

Happening on two sites.

Searched the language files and the constant is missing completely.

I added it in as an override (just a blank entry) and seems fine now.

I don't know if that was there before or if this is something new.

If it is new, what is it supposed to be, anything important or just basically a footer?

Did something go wrong with the upgrade or just a missing constant?

Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 75835
  • Thank you received: 11829
  • MODERATOR
4 days 13 hours ago #342651

Hi,

I'm not able to reproduce the problem on my end with several websites.
Note that ORDER_END_MESSAGE is not a translation constant. It's an email HTML tag. So it's normal you don't find it in the translation file.

At the end of the "HTML" section of the order admin notification (when you edit it via the menu System>Emails), you have that tag:
{TXT:ORDER_END_MESSAGE}
That tag is automatically removed by the system when the email is generated.

What you're describing indicates that either that tag was changed to for example ORDER_END_MESSAGE in the HTML section, or that there is a bug when replacing empty tags, but only in some cases because otherwise I would have the issue too.

The simplest solution in the short term is to remove that text / tag from the HTML section of the email. It doesn't have any purpose for that email anyways.

Please Log in or Create an account to join the conversation.

  • Posts: 201
  • Thank you received: 18
  • Hikashop Business Hikashop Essential
4 days 7 hours ago #342667

Odd, it wasn't showing up before under 4.5.1 and only now under 4.6.0.

It happening on another site as well, so that makes it three sites impacted so far.

Here is another quirk - with the langue override in place, the tag no longer shows in the preview but it still goes out in the actual email.

Please Log in or Create an account to join the conversation.

  • Posts: 75835
  • Thank you received: 11829
  • MODERATOR
4 days 3 hours ago #342670

Hi,

So did you check the HTML section of the email ? What did you see there ?

Please Log in or Create an account to join the conversation.

  • Posts: 201
  • Thank you received: 18
  • Hikashop Business Hikashop Essential
4 days 3 hours ago #342677

I commented out the text but it was the stock (no customizations).

Attached is a screenshot of one of the sites I haven't touched with customization.

Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 75835
  • Thank you received: 11829
  • MODERATOR
3 days 13 hours ago #342688

Hi,

Ok, I think I understand what's going on.
I've added a patch in HikaShop for this. I think it should help.
Download again the install package of HikaShop on our website and install it on yours and you'll get the patch.

The following user(s) said Thank You: jazzmang

Please Log in or Create an account to join the conversation.

  • Posts: 201
  • Thank you received: 18
  • Hikashop Business Hikashop Essential
3 days 3 hours ago #342708

Looks like it is working as it should (like before 4.6.0 upgrade).

The following user(s) said Thank You: nicolas

Please Log in or Create an account to join the conversation.

Time to create page: 0.064 seconds
Powered by Kunena Forum