Editing the email coupon value

-- HikaShop version -- : 3.2.0
-- Joomla version -- : 3.8.0
-- PHP version -- : 7.1.9
-- Browser(s) name and version -- : All
-- Error-message(debug-mod must be tuned on) -- : Nil

I have an issue with editing the email content in relation to the value of the coupon.
The coupon value is 5%.
In the global configuration apply discounts is set to before taxes.
Detailed Tax display is selected.
Show taxed prices is set to both.
Tax is set to 20%

I have a requirement that the subtotal is shown excluding VAT, this has been easy to achieve by adjusting the various views, the last one being the email template.

I know I am using the correct template because I have been able to adjust it to show the subtotal without tax, below are the lines of code which I expected to adjust to display in the email the coupon calculated "before tax"

	if(bccomp($data->cart->order_discount_price,0,5)) {
		if($config->get('price_with_tax')) {
			$t = $currencyHelper->format($data->cart->order_discount_price * -1, $data->cart->order_currency_id);
		}else{
			$t = $currencyHelper->format(($data->cart->order_discount_price - @$data->order_discount_tax) * -1, $data->order->order_currency_id);
		}
		$cartFooters[] = array(
			'NAME' => JText::_('HIKASHOP_COUPON'),
			'VALUE' => $t
		);
	}

Hi Nicolas,

Thanks for confirming my logic was correct, because I have show both with and without taxes enabled, I need to adjust the (true) line, because the result I want is what would normally be (false) I copied the false line into the true line.

The issue is the coupon value isn't changing in the email....

Dave

I have worked on this all day and have come to the conclusion that adding to line 254 "$data->order_discount_tax" isn't having an effect on the email at all. Unfortunately I am having to keep the shop offline until the correct email is being sent.

Below is what I have in the preload of the email template...

if($config->get('price_with_tax')) {
			$t = $currencyHelper->format($data->cart->order_discount_price - @$data->order_discount_tax) * -1, $data->cart->order_currency_id);
		}else{
			$t = $currencyHelper->format(($data->cart->order_discount_price - @$data->order_discount_tax) * -1, $data->order->order_currency_id);
		}
		$cartFooters[] = array(
			'NAME' => JText::_('HIKASHOP_COUPON'),
			'VALUE' => $t
		);

OK... I have found where the bug is in the coding!

Line 256 should read:

$t = $currencyHelper->format(($data->cart->order_discount_price - @$data->order_discount_tax) * -1, $data->order->order_currency_id);

$t = $currencyHelper->format(($data->cart->order_discount_price - @$data->cart->order_discount_tax) * -1, $data->order->order_currency_id);