Adding Fontawesome Icons?

  • Posts: 37
  • Thank you received: 5
10 years 2 weeks ago #199783

I can't thank you enough Lionel! You in-depth explanations are very helpful and it makes perfect sense, for now this is a workaround tat I am willing to live with until I can make the proper edits or get a professional to look at it.

Thanks so much for you time!

Please Log in or Create an account to join the conversation.

  • Posts: 26232
  • Thank you received: 4035
  • MODERATOR
10 years 2 weeks ago #199768

Hi,

@Jethro
Good to know that you solved your issue.

@lionel75
You can use a translation override to change a text and add some HTML markup if you want.
The fact that it's an override means that it is just for you and you won't loose your overrides with updates..

I really don't understand why you criticized the solution we proposed.
It is working and it respects the requirement of "fontawesome icons".
Other ways are probably possible, we just tried to gave the simplest one.

Regards,


Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.
Last edit: 10 years 2 weeks ago by nicolas.

Please Log in or Create an account to join the conversation.

  • Posts: 37
  • Thank you received: 5
10 years 2 weeks ago #199833

Well it seems as though changing the button style to CSS has caused am minor issue, on the product listing page the add to cart button does not add items to the cart, but rather links directly to the product page...

hmmmm..... www.smart-drones.com/store/category/13-accessories

Please Log in or Create an account to join the conversation.

  • Posts: 846
  • Thank you received: 92
10 years 2 weeks ago #199898

@Jerome it not my aim to comment in a negative way how hks resolve an issue. IT really nice that hks see this issue and already implement a way to resolve it by create a widget (button) to place the texte label in other location in the html code ( I use the word html code because many HTML tag can be use to have the look and feel of a button and behaviour). Most of the time i give low level answer ( css html code ) and hikashop has already implement a gui widget backend to use . The problem is that we can't guess that this button is already implement in hks ( don't know it location) and could resolve our issue ( even name label around/in button sometime don't tell/help us the functionnalities of the button ) . I never write that the way you do is wrong it is only another way and i don't study it to say if it is ok or not ( jethro write in a way it is ok and i have a look to his website where many iconS appear ).
All CMS is for "newbies" because is a click games for install high level extension but you need to use the extension in the way they are implemented .

newbies is not really negative : i understand it like click but to know where to click it need like programming ( css php html ) time and learning curve of gui interface . I really amaze about some hks user website ..... Search about a post where i say the template is really great and the user should already know what i wrote ( very technical) because i study the template layout and find it very professionnal ! .

I am not against translation override but translation is for word not for a mix of word and html tag !!
Best ( for me ) is to use translation overide AND layout override when you want to change html tag structure name hiearchy logic .

regard's

Last edit: 10 years 2 weeks ago by lionel75.

Please Log in or Create an account to join the conversation.

  • Posts: 26232
  • Thank you received: 4035
  • MODERATOR
10 years 2 weeks ago #199879

Hi,

When you click on "add to cart", you are also click on the link for the product image. So the "add to cart" form is processing but the call of the product page stop the form submission.
The "add to cart" button "onclick" should cancel the click event.. It's an issue related to your template design.

Regards,


Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

Time to create page: 0.073 seconds
Powered by Kunena Forum