Hi,
I don't think the changes in the view would be necessary for that.
For example, for the line:
echo JText::_('PRICE_DISCOUNT_END').'</span>';
instead of changing it to :
echo '</span>'.JText::_('PRICE_DISCOUNT_END').'</span>';
you could change the translation override from:
PRICE_DISCOUNT_END="<br />For : "
to:
PRICE_DISCOUNT_END="</span><br />For : "
and for the line:
echo '<span class="hikashop_product_price_before_discount">'.JText::_('PRICE_DISCOUNT_START');
you could use in the same way the translation override:
PRICE_DISCOUNT_START="From : <span class='test1'>"
So you should already be able to do what you want with just translation overrides.
However, I agree with you that you would be a good idea to add an extra span with a class there so that people wanting to style the price itself won't have to use translation overrides and can just add their CSS.
So I'll do something for that. Thanks for the feedback.