The routing for brand list pages fails in the product detail

  • Posts: 16
  • Thank you received: 0
  • Hikashop Multisite
1 week 5 days ago #371604

-- HikaShop version -- : 6.4.1
-- Joomla version -- : 5.4.5
-- PHP version -- : 8.3.21
-- Browser(s) name and version -- : Firefox 149.0.2
-- Error-message(debug-mod must be tuned on) -- : Routing for Brand list page failes in product detail view

On the product details page, the block 'show_dimensions' renders a link to the 'brand page', but it always routes to the first menu item.


This code calls the hikashopMenuClass (/administrator/components/com_hikashop/classes/menus.php) and tries to search for a menu item that has the key 'content_type' and value 'manufacturer'. No matter what i try i can't manage to create a menu item with those params.

After the code can't find a menu item it returns the first menu item in the list.

Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 85550
  • Thank you received: 13997
  • MODERATOR
1 week 4 days ago #371609

Hello,

Thanks for the detailed report. You identified correctly where the problem was: the menu-item lookup in hikashopMenuClass is matching manufacturer-listing menus too narrowly. Specifically, it is comparing the menu's selected category against a single category id picked by a SELECT with no LIMIT or ORDER BY, so a category-listing menu pointing to a brand other than the one that row happens to return is not recognised as a manufacturer listing, and the fallback then returns an unrelated menu item.

We have broadened the lookup so that any category-listing menu whose selected category has category_type=manufacturer is now accepted, in addition to menus that explicitly carry content_type=manufacturer in their params. The change is in the 6.4.1 branch. Please download the latest 6.4.1 build from your member area on our website and install it over your current installation. After the update your brand link should route through your intended manufacturer-listing menu instead of the first available HikaShop menu.

The following user(s) said Thank You: E. van Doorne

Please Log in or Create an account to join the conversation.

  • Posts: 16
  • Thank you received: 0
  • Hikashop Multisite
1 week 2 days ago #371646

I have downloaded the 6.4.1 installer, but when saving our brand menu item, the `param` column does not have a 'content_type' defined or filled. I have downloaded the 6.4.1 installer from my account -> my subscriptions -> hikashop multisites -> latest stable version. Do i need to use a different installer?

Please Log in or Create an account to join the conversation.

  • Posts: 85550
  • Thank you received: 13997
  • MODERATOR
1 week 2 days ago #371647

Hi,

No. It doesn't need it. You can use a categories / products listing menu item with the "main category" setting set to the main "brand" category, or a brand.
The system will now automatically look for a menu item matching with the brand, or with a menu item matching with the main brand category.

Please Log in or Create an account to join the conversation.

  • Posts: 16
  • Thank you received: 0
  • Hikashop Multisite
5 days 23 hours ago #371680

We actually already have such menu items in place, both for the main "Brands' category as well as for numerous individual brands. Yet the brand redirects from the individual product's pages do not work and route incorrectly to the first me menu item.

Please Log in or Create an account to join the conversation.

  • Posts: 85550
  • Thank you received: 13997
  • MODERATOR
5 days 20 hours ago #371682

Hi,

Since we're not able to reproduce the issue anymore, please provide a backend access and a FTP access so that we can look into the situation on your website directly. Maybe there's a corner case that isn't handled properly.
www.hikashop.com/support/contact-us.html

Please Log in or Create an account to join the conversation.

Time to create page: 0.338 seconds
Powered by Kunena Forum