Little inconsistency with "Totals"

-- HikaShop version -- : 2.3.0

No drama at all, nothing "wrong", just one of my long stories, this time on a tiny little inconsistency in between different parts of the package:

• In the checkout cart, you use as default HIKASHOP_TOTAL="Total" and HIKASHOP_FINAL_TOTAL="Final total".
• When showing an order or (at least backend) invoice, you use as default SUBTOTAL="Subtotal" and HIKASHOP_TOTAL="Total".

Other areas I haven't checked, but from a quick search across the entire site it appears that more files are affected (though thankfully HIKASHOP_FINAL_TOTAL is rare).

Not sure why you're using different terms - I'm not aware of any legal requirement for different terms at different stages of the ordering/invoicing process - or is there anything I don't know of?
IMHO it'd make sense, avoid occasional irritation and keep accountants happy if it were consistently the same in all docs and views.

While at it, me thinks that "Subtotal" and "Total" is never wrong and makes the best sense as e.g. it's often 'not that final' during checkout...
Unfortunately, it's not an easy fix per language override since HIKASHOP_TOTAL is used for both different purposes. So, here and now it takes more editing of views... and in this regard it'd be nice to know if this will be straightened out anytime soon in the grand scheme of things - then I'd wait a bit to make my update easier and even more worthwhile

P.S.: Maybe it is already straightened out in 2.3.1... I haven't updated yet, and apologise if my note is long obsolete!

Thanks for responding, Nicolas - on a Sunday night... uh oh.

As I was trying to say, using a language override doesn't work for making it consistent - unless you wanted to name it all the same, e.g. all "Total", nothing else. I thought of the language override thingy, too, but as mentioned, HIKASHOP_TOTAL is being used somewhere for the "subtotal", and elsewhere for the "grand total". So, you can't rename that to either term to fix a view without messing up at least one other.

To put it in another way, you are using 3 variables for 2 positions across various views, where one variable is eventually used in both positions in different views...

What?! YOU are 'lost'??? Uh oh, the world is in danger...

As said in the beginning, it's not a big thing. You really only need two terms, one usually referred to as subtotal (kinda 'net'), and the other the grand total after discounts, freight and taxes.

A search on my site produces that HIKASHOP_FINAL_TOTAL is the exotic term, used mostly in a bunch of emails, and in the checkout cart. Getting rid of it and replacing it isn't a huge task, then.

Leaves SUBTOTAL and HIKASHOP_TOTAL, where the names speak for themselves, and thankfully they are in the vast majority of views and stuff already in use as such.

Interestingly, if I'm not completely wrong now, where HIKASHOP_FINAL_TOTAL is being used, that's where HIKASHOP_TOTAL ends up in the wrong place - in the position of 'subtotal'.

So, the clean-up isn't too bad:

1. Search and find HIKASHOP_FINAL_TOTAL across all files.
2. Replace it with HIKASHOP_TOTAL (="Grand total").
3. In these same files, you bet that there is HIKASHOP_TOTAL already, only in the "wrong" position. Where it is in these files - and only in these - replace it with SUBTOTAL (="Subtotal").

Bingo, that should be it.

Looks like it's only 7 or 8 files that are affected/"infected", and a check on the language file, which takes the infamous 10 seconds, lol. See, not huge. But nasty if it keeps popping up weirdly, and even nastier if users wanted to have it straight and right, then needing to go through another set of customised files just for that...

Hope it helps.