Invoice PDF prints off Black Page?

  • Posts: 575
  • Thank you received: 11
  • Hikashop Business
2 years 11 months ago #351932

-- HikaShop version -- : 4.7.2
-- Joomla version -- : 4.3.1
-- PHP version -- : 8
-- Browser(s) name and version -- : Firefox

Hi, Since updating to J4 and installing the new invoice PDF, when selecting multiple orders to print, it now prints a blank page between each order (see screen dumps) it did not previously do this?

Rgds



Attachments:
Last edit: 2 years 11 months ago by mohairbears.
The following user(s) said Thank You: leitzdesign

Please Log in or Create an account to join the conversation.

  • Posts: 85610
  • Thank you received: 14019
  • MODERATOR
2 years 11 months ago #351942

Hi,

In the file plugins/hikashop/attachinvoice/attachinvoice.php there is the line:

$content = implode('<div style="page-break-before:always"></div>',$pdfContent);
It defines what separates the invoices.
In some cases, it's possible that the page break leads to an extra page between the invoices.
In that case, change the line to:
$content = implode('',$pdfContent);
and it should work like you expect it to.

The following user(s) said Thank You: leitzdesign

Please Log in or Create an account to join the conversation.

  • Posts: 575
  • Thank you received: 11
  • Hikashop Business
2 years 11 months ago #352045

Hi, Yes that has fixed it.

Thank you

Please Log in or Create an account to join the conversation.

  • Posts: 31
  • Thank you received: 0
  • Hikashop Business
2 years 4 months ago #358060

Thank you for the fix! I have battled this for years because I was told it was a browser issue. This update removed the blank pages, and now I can save multiple invoice PDFs without having to remove numerous blank pages.

Please Log in or Create an account to join the conversation.

  • Posts: 575
  • Thank you received: 11
  • Hikashop Business
2 days 5 hours ago #371917

Hi, You have changed the line above and it (line 245) 'still' prints out blank pages.

I have changed it to what you previously suggested, and fortunately it still works by removing them.

Rgds

Please Log in or Create an account to join the conversation.

  • Posts: 85610
  • Thank you received: 14019
  • MODERATOR
2 days 1 hour ago #371918

Hi,

Since the version of the PDF invoice plugin you have, the page break between invoices is no longer hardcoded in the PHP file. It is now a translation string called INVOICE_SEPARATOR, so that you can change it from Joomla without having to edit the plugin again after each update.

To override it:

1. In Joomla, go to System, Manage, Language Overrides.
2. Pick the site or administrator side (whichever you generate the PDFs from) and your language.
3. Click New, set the language constant to INVOICE_SEPARATOR and leave the override text empty (or set it to whatever you want between invoices).
4. Save.

Once that is in place, no more blank page between invoices and the change will survive future HikaShop updates and PDF invoice plugin updates so you do not have to re-apply your file edit each time. Could you try that on your end and let us know how it goes?

Please Log in or Create an account to join the conversation.

Time to create page: 0.492 seconds
Powered by Kunena Forum