Variant Class

  • Posts: 316
  • Thank you received: 14
  • Hikashop Business
4 weeks 3 hours ago #321958

Hi

I am using RO CSVI to create export reports etc.

When carrying out an export the variants are showing html. The following question has been asked:

This message contains confidential information


I would appreciate feedback please?

Thanks

David

Please Log in or Create an account to join the conversation.

  • Posts: 70194
  • Thank you received: 10508
  • MODERATOR
3 weeks 6 days ago #321960

Hi,

The product_name column can contain HTML. HikaShop doesn't forbid it. It's used sometimes to add a <br/> tag to the product name so that it displays on two lines and is cut where the merchant wants.
Now HikaShop doesn't do anything specific with the HTML tags added in the product_name. They are stored "as is".
I suppose that the issue is that the name's double quote was escaped by the patch for both the value of the option and the text of the option but it should only be escaped for the value (so that it doesn't break the HTML tag of the option) but that's not necessary for the text, and if you do it for the text, then the escape character will appear in the select.

Please Log in or Create an account to join the conversation.

  • Posts: 316
  • Thank you received: 14
  • Hikashop Business
2 weeks 4 days ago #322259

Hi Nicolas

the reply I received is below.

This message contains confidential information

Attachments:

Please Log in or Create an account to join the conversation.

  • Posts: 70194
  • Thank you received: 10508
  • MODERATOR
2 weeks 3 days ago #322264

Hi,

As I said in my previous message, the product_name can contain HTML code.
So the short answer to

My concern was if your product_name was actually stored with HTML in database or not.

is "Yes, it is".

Please Log in or Create an account to join the conversation.

  • Posts: 316
  • Thank you received: 14
  • Hikashop Business
2 weeks 3 days ago #322302

Hi Nicolas

thanks for the reply.

There actually seems to be an issue with the product ID when exporting information. Product ID is 4300 and the variants ID's are 4301 & 4302. When exporting via the CSV Export is is retuning a product id of 4735 which is a totally different product.

An odd behaviour with that component.

David B)

Please Log in or Create an account to join the conversation.

  • Posts: 70194
  • Thank you received: 10508
  • MODERATOR
2 weeks 3 days ago #322304

Hi,

Well, I'm not familiar with how RO CSVi is coded or even how it works as I've never used it myself.
So I wouldn't be able to help with that.

Please Log in or Create an account to join the conversation.

  • Posts: 316
  • Thank you received: 14
  • Hikashop Business
2 weeks 3 days ago #322321

Hi Nicolas


that part has now bee resolved. B)

Have a good weekend

David

The following user(s) said Thank You: Philip

Please Log in or Create an account to join the conversation.

  • Posts: 316
  • Thank you received: 14
  • Hikashop Business
1 week 6 days ago #322414

Hi Nicolas

The issue seems to be that a " is part of the product code so for instance

Moloch Action Figure 6" Black Series_6 is actually being read as Moloch Action Figure 6 which means that the variants are not being exported.

This message contains confidential information

Please Log in or Create an account to join the conversation.

  • Posts: 70194
  • Thank you received: 10508
  • MODERATOR
1 week 5 days ago #322416

Hi,

We don't forbid the use of double quotes in product codes.
But it would indeed be better to avoid using it in namekeys/codes etc. Places which can be used as the value of an option of a dropdown.

Now it seems that this dropdown is in RO CSVi if I understand correctly ?
In that case, the value should be escaped when added to the value of the option of the dropdown and that would avoid the dropdown breaking.
Here is a page about this issue:
stackoverflow.com/questions/4015345/how-...side-html-attributes

Please Log in or Create an account to join the conversation.

Time to create page: 0.077 seconds
Powered by Kunena Forum