Vendor frontend control panel can't delete categories

  • Posts: 31
  • Thank you received: 0
5 years 2 months ago #303272

-- url of the page with the problem -- : demo.hikashop.com/index.php/fr/hikamarke...anel/category#delete
-- HikaShop version -- : 4.0.1
-- HikaMarket version -- : 3.0.0
-- Joomla version -- : 3.9.2
-- PHP version -- : 7.1.23
-- Browser(s) name and version -- : firefox

Hello,
I check on the demo website of hikamarket, and i found that a vendor can't delete a category, the "are you sure" popup display correctly but when press ok there is a javascript error and no category deleted.
Same on my website...

Please Log in or Create an account to join the conversation.

  • Posts: 26000
  • Thank you received: 4004
  • MODERATOR
5 years 2 months ago #303284

Hello,

Indeed ; there was still a "product_id" instead of "category_id" in the listing view.
I fixed it and uploaded new packages with the patch.

Thank for the report

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 31
  • Thank you received: 0
5 years 2 months ago #303293

ok, yes i also try to change "product_id" to "category_id" but now i have a 403 error " forbiden access"

the action form url is : <form action="<?php echo hikamarket::completeLink('category&task=delete'); ?>"

but there isn't categories delete ACL for vendor in vendor access page....

Please Log in or Create an account to join the conversation.

  • Posts: 26000
  • Thank you received: 4004
  • MODERATOR
5 years 2 months ago #303295

Hello,

When I imported the interface of the product listing into the category listing, some parts were forgotten.
It will be fix in the next version (which should be released soon since HikaShop 4.0.2 is available).

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 31
  • Thank you received: 0
5 years 1 month ago #304448

I made the update (hikashop and hikamarket) i can delete the category now, but i can't edit caterories more than once.... i look in db when category type change from product to vendor, after that you can't edit them anymore...

Please Log in or Create an account to join the conversation.

  • Posts: 26000
  • Thank you received: 4004
  • MODERATOR
5 years 1 month ago #304451

Hello,

Can you please provide more details about the context ?
What category are you editing with your vendor ?

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 31
  • Thank you received: 0
5 years 1 month ago #304471

in the front end i'm connected with a vendor account, i go to the vendor cpanel front end, i go to categories management, i create one category, i edit this category and save, i edit again this category (last change are ok) and save, i edit again and my last change are lost. if i save, and edit again nothing is saved...

Please Log in or Create an account to join the conversation.

  • Posts: 26000
  • Thank you received: 4004
  • MODERATOR
5 years 1 month ago #304476

Hello,

The issue is related to something in the HikaShop core. In order to fix category tree errors, HikaShop do copy the parent category type from to the child category.. But with HikaMarket the vendor categories are special one.
While there was already something in HikaMarket to handle the creation of vendor category, some things changed in the core and I didn't see that issue coming.
I talked with Nicolas and we think that the core should keep its security code ; but I will need to add some code within HikaMarket in order to be able to create the vendor and the product sub-categories.

Since Nicolas will soon publish a new HikaShop release and I have some patch pending in HikaMarket ; I think it will be a good moment to also perform a new release.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 31
  • Thank you received: 0
5 years 1 month ago #304514

ok, i try to roll back to previous version but the problem was already there... so i wait for next release...

Please Log in or Create an account to join the conversation.

  • Posts: 26000
  • Thank you received: 4004
  • MODERATOR
5 years 1 month ago #304515

Hello,

Yes, unfortunately the code in the HikaShop core is there since some months and you're the first to report the issue.
The problem is only related when you edit a category which is directly under the vendor category.
The patch is ready in HikaMarket ; I still have few elements to finish and I will perform a release.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 31
  • Thank you received: 0
5 years 3 weeks ago #305115

Hello,
Any news about new hikamarket update ?
Thank you !

I have some other bug,

When you edit product pictures in front end if you have plenty of picture you can't navigate with page number or next previous bottom buttons.
My solution : add this line " JFactory::getDocument()->addScript($this->baseurl.'/media/system/js/core.js'); " at the begining of view : HikaMarket - uploadmarket / galleryimage.php

when you edit price product in front end, if you type HT Price then clic ok button the TTC is updated and price is saved, BUT if you type TTC then clic ok HT is not updated and price is saved as 0€ (not a big bug but....)
My solution : change in HikaMarket - form view "onchange" to "onkeyup" (this way i have also direct/instant update of price)

And in backend i can't edit joomla user account : i get error : Call to undefined function hikashop_get() (hikashop related) update : this is one of my plugin which cause problm=em...

Last edit: 5 years 3 weeks ago by Atelierin8.

Please Log in or Create an account to join the conversation.

  • Posts: 26000
  • Thank you received: 4004
  • MODERATOR
5 years 3 weeks ago #305126

Hello,

1 - We are still working on some improvements ; we had some reports during the past days and are currently performing implementations.

2 - While I do have an issue with the non display of the page numbers, I can navigate in the pagination using the previous/next buttons.
I don't really why the core.js file is not loaded in your case but if it's not loaded ; it can explain for sure why the previous/next buttons are not working (since it uses a JS function from that file to submit the page modification)

3 - The update of HT and TTC is based on the "blur" and "change" events (so mostly when the input lost the focus).
In my test website, I was not able to reproduce your issue ; can you reproduce it in our demo website ?

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 31
  • Thank you received: 0
5 years 1 week ago #305757

For 3, yes same problem on your demo website (with firefox or chrome), in fact, if you type in field TTC and direct click on "OK" (without cliking somewhere between this actions) price stay at 0€

Please Log in or Create an account to join the conversation.

  • Posts: 26000
  • Thank you received: 4004
  • MODERATOR
5 years 6 days ago #305776

Hello,

Thank you for the details ; I know understand more the kind of issue you're having.
Can you also reproduce it in the HikaShop backend for the price edition ?

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 31
  • Thank you received: 0
5 years 5 days ago #305796

yes except that in backend, if you type HT then clik ok, only the HT is saved the TTC is 0 €
invers is aslo true, you type TTC then HT is 0 €

Please Log in or Create an account to join the conversation.

  • Posts: 26000
  • Thank you received: 4004
  • MODERATOR
5 years 4 days ago #305819

Hello,

Thank you for your feedback.

I have notified the HikaShop team about the similar issue in the price edition in the backend.
I cannot provide a fast patch for that in HikaMarket but I'm thinking about various ways to solve it ; it could be a delay of the price validation (which will wait for the ajax callback for the price) or it could be the storage of a special value in the field to indicate that only on kind of price was entered by the user (so HikaMarket will process the other price using the tax rule).
Since we are finalizing the next HikaMarket release, that patch will be include.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 31
  • Thank you received: 0
5 years 4 days ago #305833

hello,
Like i said previously "My solution : change in HikaMarket - form view "onchange" to "onkeyup" (this way i have also direct/instant update of price)"
For me it's simple and i don't see any problem...

Please Log in or Create an account to join the conversation.

  • Posts: 26000
  • Thank you received: 4004
  • MODERATOR
5 years 3 days ago #305838

Hello,

It is indeed a possibility but I would perform a lot of AJAX call each time you press a key in the input box.
Due to possible delay, it's even possible that one call return before another and that the input will be fill with an incorrect value...
By using the "onkeyup" I would then prefer to just perform a simple multiplication in JavaScript and not having to use an AJAX call ; but that multiplication need to be sure of the tax rate rules. Since all the tax processing is in the HikaShop core system (in PHP), the Ajax call avoid some problem by using the same code for that part too.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

Moderators: Obsidev
Time to create page: 0.087 seconds
Powered by Kunena Forum