Discount - discount_product_id DB limitation of length

  • Posts: 32
  • Thank you received: 2
6 years 3 weeks ago #290262

-- HikaShop version -- : 3.4.0

Hi,

When working in a CSV who need to be imported via phmymadmin on the "hikashop_discount" table, i noticed there is a limitation on the "discount_product_id" : varchar, 255 length

What do you think about that ?
In the backend, are the limitation handled ?

On my side, i got for exemple 1 line with 355char length of product id(for "discount_product_id"), for now, i gonna split the line...

Please Log in or Create an account to join the conversation.

  • Posts: 81509
  • Thank you received: 13064
  • MODERATOR
6 years 3 weeks ago #290264

Hi,

You can just change the type of the column to "text" via phpmyadmin if you need more characters.
The PHP code in HikaShop doesn't have the limitation. It's only at the MySQL level.

Please Log in or Create an account to join the conversation.

  • Posts: 32
  • Thank you received: 2
6 years 3 weeks ago #290300

Hi,

If i change from varchar to mediumtext, what happen on next hikashop update ?
If you dont plan to change in your side for a next update (maybe too complicated), i will stick on another way

thx for your feedback

Please Log in or Create an account to join the conversation.

  • Posts: 81509
  • Thank you received: 13064
  • MODERATOR
6 years 3 weeks ago #290315

Hi,

There is nothing to do for hte next update. It will stay like that. Updates will only add tables and columns if missing, they won't change the type of the columns.

Please Log in or Create an account to join the conversation.

Time to create page: 0.058 seconds
Powered by Kunena Forum