Check for missing $url_itemid

Start
Prev
1
Next
End

neo191987
Topic Author
Offline

Posts: 410
Thank you received: 15

1 year 1 month ago #349791

Hi, can you please check your all components for missing $url_itemid, this is causing some problems with Joomla 4. The links would look like this if missing /index.php/component/hikashop/address.

For example

<?php echo hikashop_completeLink('address'); ?>

To be changed to

<?php
$url_itemid=(!empty($this->Itemid)?'&Itemid='.$this->Itemid:'');
echo hikashop_completeLink('address'.$url_itemid);
?>

This fixes this issue

Last edit: 1 year 1 month ago by neo191987.

Please Log in or Create an account to join the conversation.

nicolas
Online

Posts: 81511
Thank you received: 13066
MODERATOR

1 year 1 month ago #349795

Hi,

We've been adding Itemid parameters in the URLs in many places in the past 2 years. Also, not having the Itemid in a URL doesn't automatically generate an error. It's only in some cases that it does, and you don't want to add it everywhere either (not in the backend for example).
So it's harder and harder to know where we would be missing them as there are less and less of them.
Let us know when you found one and we'll be happy to fix it.

We'll add that change on our end. Thanks.

The following user(s) said Thank You: neo191987

Please Log in or Create an account to join the conversation.

neo191987
Topic Author
Offline

Posts: 410
Thank you received: 15

1 year 1 month ago #349803

Hi, of course only for the front end. This causes some problems I have noticed. In the event that no Itemid has entered, it does not get the current menu ID and Breadcrumb will not be displayed correctly.

Last edit: 1 year 1 month ago by neo191987.

Please Log in or Create an account to join the conversation.

neo191987
Topic Author
Offline

Posts: 410
Thank you received: 15

1 year 1 month ago #350299

4.7.2 is good job. I had also written the same patch. HikaAuction and HikaSerial should also be checked out. For example User control panel>Serials, Subscriptions, Subscription Downloads and Bidding history.