Found 2 errors (v 2.0.1)

  • Posts: 410
  • Thank you received: 15
6 years 3 months ago #284815

-- HikaShop version -- : 3.2.2
-- HikaMarket version -- : 2.0.1

Hi, I found two problems.
1. Orders -> Billing address -> Edit address -> after I enter the address and click on the OK button, display the following error: Unknown column 'Array' in 'where clause'
2. Orders -> Product list -> Add new product -> If we choose a product worth about 10 euros without VAT, will be shown with an accrued Bulgarian VAT. The problem is that if I change with another VAT, the base price (the price without VAT) will be deducted and will show the value of the price with Bulgarian VAT instead of charging the indicated VAT. In my opinion, it should show the price without VAT and then charge that VAT.



Attachments:
Last edit: 6 years 3 months ago by neo191987.

Please Log in or Create an account to join the conversation.

  • Posts: 26000
  • Thank you received: 4004
  • MODERATOR
6 years 3 months ago #284817

Hello,

1 - Thanks for the report.
The problem is in the HikaShop core, for the Field class.
In that file, please replace

	public function getFilteredInput($type, &$oldData, $report = true, $varname = 'data', $force = false, $area = '') {
		$allCat = $this->getCategories($type, $oldData);
		$fields =& $this->getData($area, $type, false, $allCat);
		$data = $this->getInput($type, $oldData, $report, $varname, $force, $area);

		if(!$data)
			return $data;

		if($type== 'entry' && $area == 'frontcomp') {
By
	public function getFilteredInput($type, &$oldData, $report = true, $varname = 'data', $force = false, $area = '') {
		$typeName = $type;
		if(is_array($type)) {
			$typeName = $type[1];
		}
		$allCat = $this->getCategories($typeName, $oldData);
		$fields =& $this->getData($area, $typeName, false, $allCat);
		$data = $this->getInput($type, $oldData, $report, $varname, $force, $area);

		if(!$data)
			return $data;

		if($typeName == 'entry' && $area == 'frontcomp') {
So it will handle correctly the parameter $type when it's an array (like it is handle the in the getInput function).

2 - While in HikaShop you can modify the price, the tax value and the tax rule without any restriction ; we decided to just let you have the access to one value and let the system process the other values.
So yes, we decided to let the vendor have an access to the price with tax and then deduce the price without tax and the tax value because if you change the tax rate, the price that the customer paid stay the same.
Now you can still perform a view override in order to change the way that it's processed. It is purely some hidden fields and some javascript (which read the tax rate dynamically) ; there is no web-service call so all is in the view.

Regards,

Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.
The following user(s) said Thank You: neo191987

Please Log in or Create an account to join the conversation.

Moderators: Obsidev
Time to create page: 0.083 seconds
Powered by Kunena Forum