Something in the latest update brakes my template

  • Posts: 110
  • Thank you received: 6
8 years 7 months ago #253275

-- HikaShop version -- : 2.6.4
-- Joomla version -- : 3.6.3
-- PHP version -- : 5.6.27
-- Browser(s) name and version -- : firefox

When I updated to the latest hikashop version brakes the product view. It sends the right sidebar under the main product braking the layout.

Also when I use additional images under the main product image they brake and show distorted.

Please Log in or Create an account to join the conversation.

  • Posts: 83992
  • Thank you received: 13604
  • MODERATOR
8 years 7 months ago #253302

Hi,

It likely comes from the view overrides of your template.
If you rename the folder templates/YOUR_TEMPLATE/html/hikashop/product and try again, it should display fine confirming that.
In that case, you need to do several things:
- rename the files in that folder one by one, in order to identify the one with the problem.
- contact your template provider or the person who customized the view file to see if they can fix that for you.
- if they can't, you have to get the modifications from the old view and move them to the new version of the view file. However, regarding the right sidebar, an easy solution is to simply add one or several </div> at the end of the view file which creates the problem. For the image issue, I can't give an easy solution.

The following user(s) said Thank You: tomhika

Please Log in or Create an account to join the conversation.

  • Posts: 110
  • Thank you received: 6
8 years 7 months ago #253308

Hello, thank you for your help. I customized the template myself.
I realize that what makes a difference is if a product has a comment or not. If it does the product page is render correctly, if it doesn't it brakes the template.
Before I made the post I tried
- renaming the file structure from the show_default.php and even the html override folder
- delete all custom css
- Checking all the divs on dreamweaver to make sure all the markup was correct

Here is the Hikashop product view with the default Hikashop files. You see that the problem still there and the images still distorted.
www.trooky.com/pop-culture-shirts/item/chick-magnet-1

Last edit: 8 years 7 months ago by tomhika.

Please Log in or Create an account to join the conversation.

  • Posts: 83992
  • Thank you received: 13604
  • MODERATOR
8 years 7 months ago #253310

Hi,

Ok, I had a look at the page.
As far as I can see, I already gave you the solution. There is a missing </div>.
You can see that I can get the same result as before by changing the width/float of the different elements of your template:
take.ms/2uwo0
take.ms/Bnukc
So that points to either the template missing some positioning CSS or some shift on the divs due to missing closing tags.
And since it displays fine on other pages, it can only be some missing closing tag.

Please Log in or Create an account to join the conversation.

  • Posts: 110
  • Thank you received: 6
8 years 7 months ago #253419

Nicolas, thanks for your time and for looking into the issue. However....if it was an open div ...... here is a video of the same problem with the core hikashop files untouched and a completely different template (protostar) clean cache.
www.youtube.com/watch?v=90KwsRdPXVk

Thanks anyway.

Last edit: 8 years 7 months ago by tomhika.

Please Log in or Create an account to join the conversation.

  • Posts: 83992
  • Thank you received: 13604
  • MODERATOR
8 years 7 months ago #253445

Hi,

Ok, but I checked your link and I don't see the problem:
take.ms/8dOqo
I didn't change any CSS.
So that means that it is an open DIV but in a view override but in the description of the product with the issue.

Please Log in or Create an account to join the conversation.

  • Posts: 110
  • Thank you received: 6
8 years 7 months ago #253534

Thank you for your help. I am not asking to solve the issue anymore. I decided to just give up on hikashop, I have been using it for years and every time there is a new update I encounter issues.... how can you build a reliable site with a product like that? . I will rebuild the store using a different product.

One of the first things I did was make sure the product description html was correct, that there was not an open div even before I contacted you. It is correct.

I realize that if the product had a comment the page would render properly, and I stated that in earlier comments. Here are a couple of pages with no comments on it.

www.trooky.com/pop-culture-shirts/item/chick-magnet-1
www.trooky.com/all-t-shirts/all-countrie...ky-bastard-irish-men

Please Log in or Create an account to join the conversation.

  • Posts: 83992
  • Thank you received: 13604
  • MODERATOR
8 years 7 months ago #253549

Hi,

That's too bad but ok.
I still don't see why it would do that based on whether a product has comments or not.
Let me explain why:
- Here the page as a comment and it displays fine: take.ms/0FGWK
- Here the page as a comment and it doesn't display fine: take.ms/bj4pP
So I understand what you mean but that's not what I see on your website.
So it seems to come from something else than having a comment or not in the product.

Maybe there is a misunderstanding. I'm not necessarily saying that the problem is on your end and that you made a mistake in the product description or view override. These were just possibilities I mentioned so that you would check on them since you hadn't mentioned them. It's also possible that there is a bug in a view file of the current version of HikaShop. I'm not disputing that.
But the fact still remains that it seems that there is a missing div closing tag somewhere on the page. That's the only way I can explain the problem.
And the solution to that will be to add the missing closing tag where it has to go. If it's linked to the comments listing, then it's probable that it would require adding it in the file "listing" of the "vote" view. Maybe at the end ? Maybe somewhere in the middle.

Please Log in or Create an account to join the conversation.

  • Posts: 110
  • Thank you received: 6
8 years 7 months ago #253644

Thanks again Nicolas, and so long.

Please Log in or Create an account to join the conversation.

  • Posts: 110
  • Thank you received: 6
8 years 6 months ago #256974

I see that the latest update fix the problem.....

Please Log in or Create an account to join the conversation.

  • Posts: 110
  • Thank you received: 6
8 years 4 months ago #261410

One thing that is always a constant with Hikashop is that if there is an update .. it will brake my site. On configuration I selected 3 columns, on the menu item for every category selected 3 columns, still my site brakes and shows everything in one column.

According to Hikashop is never their component... its always the user. I tried 3 different templates from different providers just to give hikashop the benefit of doubt, still have the same issue.

Just like the issue with the ugly checkout process that can never seem to be fixed. At this point I'm only using Hikashop to keep my site up while I rebuild using eshop.

I think the main issue is that the developers of Hikashop are making so much money that they do not care about the customer base.

There is one customer that wont be paying you anymore, me

Please Log in or Create an account to join the conversation.

  • Posts: 26253
  • Thank you received: 4040
  • MODERATOR
8 years 4 months ago #261411

Hi,

No, HikaShop does not break your template but some parts of your template are not compatible with the responsive system in HikaShop.
See : www.hikashop.com/forum/install-update/88...-website.html#260428

Regards,


Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

  • Posts: 110
  • Thank you received: 6
8 years 4 months ago #261671

Before I post here I make sure I rule out things, I tried Helix and the shape5 frameworks, made sure all cache was clean. It is not the template.

Last time 2 times I had the same issue I was told by your team that it was Not Hikashop .. but that it was something on my end, then the issue got quietly fixed from your end with no admission of the issue being on your end.

Anyway, have you seen the popup cart and the checkout on eshop? And the price for eshop? and the rating of eshop in the joomla directory? ....

keep blaming the costumer, I was with you for 7 years......

Please Log in or Create an account to join the conversation.

  • Posts: 110
  • Thank you received: 6
8 years 4 months ago #261686

Watch this video and tell me if you still think is on my end.

- Rename the entire html override folder
- Set item's row and columns on the menu item 3 columns
- On main Hika configuration set it to 3 columns
- Cleaned cache at the server level
- cleaned cache at the joomla level

Still shows 1 column, regardless of the template

www.youtube.com/watch?v=7sTg7FceGQs&feature=youtu.be

Please Log in or Create an account to join the conversation.

  • Posts: 4820
  • Thank you received: 654
  • MODERATOR
8 years 4 months ago #261680

Hello,

We are here to help people, not to blame them, I don't see what you means for this point, neither I don't understand the aim of this discussion.
There is a lot of examples where we thanks customer for their feedback that leads to fix HikaShop elements.

Here the aim is to find root issue, and we help customers very often to get it on HikaShop or other components that work with HikaShop.
An E-shop is build with several elements that can leads issues when work together, and of course sometime we can make some mistake, but most often people are happy with our help,

HikaShop rating From JED :




But you can test other solutions, customer are free.

Otherwise, I have a look to your website and your video, I get it, follow me step by step.
Here, your page with the issue and the navigator inspect tool



We see a CSS command that push your div to be in 100% width, that's not normal.



Here, you see that your JCH OPTIMIZ process your css file and especially an old_frontend.css, that don't have to be there because it break the new HikaShop grid system.
And I don't know why this Css file is still there.



Now what to do ?
Remove this frontend_old.css file or the other solution, is to just remove this Css width order, but in the future if we change something in HikaSHop Css, there is some chance that some issue appear again, like in this case.

Regards

Attachments:
Last edit: 8 years 4 months ago by Philip.
The following user(s) said Thank You: tomhika

Please Log in or Create an account to join the conversation.

  • Posts: 110
  • Thank you received: 6
8 years 4 months ago #261793

This conversation HAS A POINT. I don't get the software from you for free, and I have been a costumer for several years now, and I have a problem with the product you sold me. Are you OK with paying for a car with 3 tires?

I have been having this issue for a long time now, and this is the first time someone has gotten to the real root of the problem. I do not know why that file is there, all I do is update with your releases.

In the past (Look on this very tread) the other people trying to "help" have not really help, but made it sound in a real sleek way like it was my fault.

Now to Eshop,
Hikashop reviews: 236
Eshop reviews: 236
Eshop Overall: 100
Eshop Functionality 100
Eshop Ease of use 100
Eshop Documentation 100
Eshop Support 100

I guess none of those several elements that can leads issues when work together have actually let to issues for anyone.

Anyway, thank you for finally getting to the root of the problem.

Please Log in or Create an account to join the conversation.

  • Posts: 26253
  • Thank you received: 4040
  • MODERATOR
8 years 4 months ago #261803

Hi,

Your issue is related to an old CSS file which have a conflict.
By using the default CSS file, that conflict is not present.
So, because you have an old CSS file which has been customized, we indicated you that you have to just remove one line from your customized CSS.

I'm sorry but you had a question and we gave you the answer, the solution.

Now if you want to continue to tell that it is our fault, go ahead but it won't change anything at your problem and the solution won't be different.
Afterwards, because we don't think that your issue is our fault but is due to a conflict with an old customized CSS file in your website ; we argued in that way because we though it was our right to answer to your accusation.
But yes, it does not allow to go further and it does not change the fact that you have one line of CSS to remove.

Like we wrote a lot of times in that forum ; HikaShop 3 is a major release with a lot of new feature and a lot of modifications.
You also have to be careful when you updated Joomla 2.5 to Joomla 3.0 ; some tests were required in order to be sure that everything was good.
It is the exact same thing for the update from HikaShop 2.6 to HikaShop 3.0 ; it is a major release with potential conflicts and your conflicts is one single CSS line.

Regards,


Jerome - Obsidev.com
HikaMarket & HikaSerial developer / HikaShop core dev team.

Also helping the HikaShop support team when having some time or couldn't sleep.
By the way, do not send me private message, use the "contact us" form instead.

Please Log in or Create an account to join the conversation.

Time to create page: 0.112 seconds
Powered by Kunena Forum